[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6976: Fix deep store directory structure

[GitBox]

chenboat commented on a change in pull request #6976:
URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639348510



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -386,11 +386,11 @@ private SegmentMetadata getSegmentMetadata(File 
tempDecryptedFile, File tempSegm
   }
 
   private void completeZkOperations(boolean enableParallelPushProtection, 
HttpHeaders headers, File uploadedSegmentFile,
-      String tableNameWithType, SegmentMetadata segmentMetadata, String 
segmentName, String zkDownloadURI,
-      boolean moveSegmentToFinalLocation, String crypter)
+      String rawTableName, String tableNameWithType, SegmentMetadata 
segmentMetadata, String segmentName,
+      String zkDownloadURI, boolean moveSegmentToFinalLocation, String crypter)
       throws Exception {
     URI finalSegmentLocationURI = URIUtils
-        
.getUri(ControllerFilePathProvider.getInstance().getDataDirURI().toString(), 
tableNameWithType,
+        
.getUri(ControllerFilePathProvider.getInstance().getDataDirURI().toString(), 
rawTableName,
             URIUtils.encode(segmentName));
     ZKOperator zkOperator = new ZKOperator(_pinotHelixResourceManager, 
_controllerConf, _controllerMetrics);
     zkOperator.completeSegmentOperations(tableNameWithType, segmentMetadata, 
finalSegmentLocationURI, uploadedSegmentFile,

Review comment:
       Before my PR, most places already use tablename with type (in fact they 
use offline table name with type). As an example, 
   
   `String offlineTableName = 
TableNameBuilder.OFFLINE.tableNameWithType(rawTableName);`
   
   My changes are making the names more clear and generic. Of course, the deep 
store uri change one is not compatible -- I missed the segment deletion path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org