Jackie-Jiang commented on pull request #6968:
URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-848215710


   > > > For null value support, does this still require enabling null via 
config?
   > > 
   > > 
   > > Yes. The `nullValueFields` are set in `GenericRow` only when the null 
value is enabled in table config. The change in this PR only make ser/de 
preserve the `nullValueFields` info.
   > 
   > If the ser/de preserve the null info, then do we still need the enabling 
config? Or shall we just always enable null handling?
   
   Yes, you still need to enable the null handling in the table config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to