liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r639302238
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -603,6 +653,15 @@ private boolean isPeerURL(String segmentLocation) {
.startsWith(CommonConstants.Segment.PEER_SEGMENT_DOWNLOAD_SCHEME);
}
+ /**
+ * Cache the LLC segment without deep store download uri to {@link
PinotLLCRealtimeSegmentManager#_llcSegmentMapForUpload}.
+ */
+ @VisibleForTesting
+ void cacheLLCSegmentNameForUpload(String realtimeTableName, String
segmentName) {
Review comment:
This is simply to follow the other functions' modifier, which are also
used in testing in this class,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
