[GitHub] [incubator-pinot] amrishlal opened a new pull request #6908: Mitigate calcite NPE bug.

amrishlal opened a new pull request #6908: URL: https://github.com/apache/incubator-pinot/pull/6908 ## Description Calcite code, `SqlNumericLiteral.isInteger()`, throws a NPE while compiling the query `SELECT * FROM testTable WHERE floatColumn > 1.7976931348623157E308`. This PR mitigate

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

codecov-commenter edited a comment on pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#issuecomment-834062294 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] icefury71 commented on issue #4230: NULL value support for all data types

icefury71 commented on issue #4230: URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-840298669 Unfortunately that's not possible with the current implementation. Current implementation will ignore nulls or treat them as default values in the filter operator. Everyth

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

codecov-commenter edited a comment on pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#issuecomment-834062294 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

icefury71 commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631549910 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +135,51 @@ private S

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

icefury71 commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631549329 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +135,51 @@ private S

[incubator-pinot] branch master updated: Allow overriding delimiter in Complex type config (#6905)

This is an automated email from the ASF dual-hosted git repository. yupeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 086c3f6 Allow overriding delimiter in

[GitHub] [incubator-pinot] yupeng9 merged pull request #6905: Allow overriding delimiter in Complex type config

yupeng9 merged pull request #6905: URL: https://github.com/apache/incubator-pinot/pull/6905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] apucher opened a new issue #6907: read pinot.server.tls properties for kafka tls if no other config provided

apucher opened a new issue #6907: URL: https://github.com/apache/incubator-pinot/issues/6907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[incubator-pinot] branch testPBNJ updated: Test pbnj, create 1 segment instead of multiple for each push job. (#6906)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch testPBNJ in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/testPBNJ by this push: new 2e9a8f8 Test pbnj, create 1 segment

[GitHub] [incubator-pinot] jackjlli merged pull request #6906: Test pbnj, create 1 segment instead of multiple for each push job.

jackjlli merged pull request #6906: URL: https://github.com/apache/incubator-pinot/pull/6906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631465800 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProviderFactory.java ## @@ -0,0 +1,84 @@ +/** + *

[GitHub] [incubator-pinot] jtao15 opened a new pull request #6906: Test pbnj, create 1 segment instead of multiple for each push job.

jtao15 opened a new pull request #6906: URL: https://github.com/apache/incubator-pinot/pull/6906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[incubator-pinot] branch testPBNJ created (now 428e2a8)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch testPBNJ in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 428e2a8 Update the javadoc for PinotSegmentRestletResource (#6903) No new revisions were added by this upd

[incubator-pinot] branch master updated (046b255 -> 428e2a8)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 046b255 Add the complex data type transformer for complex type handling (#6845) add 428e2a8 Update t

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6903: Update the javadoc for PinotSegmentRestletResource

Jackie-Jiang merged pull request #6903: URL: https://github.com/apache/incubator-pinot/pull/6903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6903: Update the javadoc for PinotSegmentRestletResource

Jackie-Jiang commented on a change in pull request #6903: URL: https://github.com/apache/incubator-pinot/pull/6903#discussion_r631473305 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -91,6 +91,9 @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6903: Update the javadoc for PinotSegmentRestletResource

mayankshriv commented on a change in pull request #6903: URL: https://github.com/apache/incubator-pinot/pull/6903#discussion_r631466073 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -91,6 +91,9 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631465800 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProviderFactory.java ## @@ -0,0 +1,84 @@ +/** + *

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631463213 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProviderFactory.java ## @@ -0,0 +1,84 @@ +/

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

codecov-commenter edited a comment on pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#issuecomment-834835328 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

mcvsubbu commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631453814 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +135,51 @@ private St

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6905: Allow overriding delimiter in Complex type config

Jackie-Jiang commented on a change in pull request #6905: URL: https://github.com/apache/incubator-pinot/pull/6905#discussion_r631452485 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ## @@ -78,27 +7

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

mcvsubbu commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631448893 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +135,51 @@ private St

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

codecov-commenter edited a comment on pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#issuecomment-834835328 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6905: Allow overriding delimiter in Complex type

yupeng9 opened a new pull request #6905: URL: https://github.com/apache/incubator-pinot/pull/6905 ## Description Part of https://github.com/apache/incubator-pinot/issues/6904 ## Upgrade Notes This PR adds a configuration option `delimiter` in `ComplexTypeConfig` to over

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631441793 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ## @@ -218,6 +251,8 @@ private void regis

[GitHub] [incubator-pinot] yupeng9 opened a new issue #6904: Complex type handling

yupeng9 opened a new issue #6904: URL: https://github.com/apache/incubator-pinot/issues/6904 Today Pinot supports primitive data types (including int, long, float, double, string, bytes), as well as limited multi-value types such as an array of primitive types. Such simple data types allow

[GitHub] [incubator-pinot] yupeng9 closed issue #5280: Add the geospatial support

yupeng9 closed issue #5280: URL: https://github.com/apache/incubator-pinot/issues/5280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[incubator-pinot] branch master updated (dce7479 -> 046b255)

This is an automated email from the ASF dual-hosted git repository. yupeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from dce7479 Move maxBurstQps broker metric in createRateLimiter method (#6898) add 046b255 Add the compl

[GitHub] [incubator-pinot] yupeng9 merged pull request #6845: Add the complex data type transformer for complex type handling

yupeng9 merged pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6845: Add the complex data type transformer for complex type handling

codecov-commenter edited a comment on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827242858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6845: Add the complex data type transformer for complex type handling

codecov-commenter edited a comment on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827242858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch master updated (9b44c21 -> dce7479)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9b44c21 Add config File support(#6787) (#6901) add dce7479 Move maxBurstQps broker metric in createRate

[GitHub] [incubator-pinot] jackjlli merged pull request #6898: Move maxBurstQps broker metric in createRateLimiter method

jackjlli merged pull request #6898: URL: https://github.com/apache/incubator-pinot/pull/6898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6898: Move maxBurstQps broker metric in createRateLimiter method

jackjlli commented on a change in pull request #6898: URL: https://github.com/apache/incubator-pinot/pull/6898#discussion_r631423508 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java ## @@ -149,7 +149,7

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

icefury71 commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631390830 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java ## @@ -131,6 +134,49 @@ private S

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

icefury71 commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631390720 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java ## @@ -586,4 +596,31 @@ p

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631367717 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ## @@ -0,0 +1,42 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

Jackie-Jiang commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r631367102 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java ## @@ -120,6 +126,49 @@ public boolean hasNullValues

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

Jackie-Jiang commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r631366516 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java ## @@ -120,6 +126,49 @@ public boolean hasNullValues

[incubator-pinot] branch master updated (5faf33d -> 9b44c21)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 5faf33d Adjust threadCpuTime calculation (#6886) add 9b44c21 Add config File support(#6787) (#6901)

[GitHub] [incubator-pinot] mcvsubbu merged pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for queries(#6787)

mcvsubbu merged pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

yupeng9 commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r631361540 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java ## @@ -120,6 +126,49 @@ public boolean hasNullValues() {

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

yupeng9 commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r631360408 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java ## @@ -120,6 +126,49 @@ public boolean hasNullValues() {

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631326435 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ## @@ -0,0 +1,42 @@ +/** + * Licens

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for

codecov-commenter edited a comment on pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901#issuecomment-839206763 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6901?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for

codecov-commenter edited a comment on pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901#issuecomment-839206763 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6901?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631309663 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ## @@ -0,0 +1,40 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

Jackie-Jiang commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r631297353 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java ## @@ -120,6 +126,49 @@ public boolean hasNullValues

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631299443 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ## @@ -0,0 +1,40 @@ +/** + * Licens

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for quer

GSharayu commented on a change in pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r631261220 ## File path: compatibility-verifier/compCheck.sh ## @@ -112,14 +121,18 @@ function stopService() { # Starts a Pinot cluster given a specific ta

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for quer

mcvsubbu commented on a change in pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r631251714 ## File path: compatibility-verifier/compCheck.sh ## @@ -112,14 +121,18 @@ function stopService() { # Starts a Pinot cluster given a specific ta

[GitHub] [incubator-pinot] mqliang commented on pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for queries(#6787)

mqliang commented on pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901#issuecomment-839960292 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for quer

mcvsubbu commented on a change in pull request #6901: URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r631233717 ## File path: compatibility-verifier/compCheck.sh ## @@ -169,6 +182,11 @@ COMPAT_TESTER_PATH="pinot-integration-tests/target/pinot-integration-t

[incubator-pinot] branch master updated (d76d5e2 -> 5faf33d)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d76d5e2 Add segment size rule to Recommendation Engine (#6869) add 5faf33d Adjust threadCpuTime c

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6886: Adjust threadCpuTime calculation

siddharthteotia merged pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] CurriedFloat commented on issue #4230: NULL value support for all data types

CurriedFloat commented on issue #4230: URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-839643881 No I want to include null values but as null and not as defaultNullValue so I can distinguish the two cases. If defaultNullValue is zero and nullHandling is enabl

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6845: Add the complex data type transformer for complex type handling

codecov-commenter edited a comment on pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#issuecomment-827242858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr