mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631326435
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ########## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.environmentprovider; + +import java.util.Map; +import org.apache.pinot.spi.env.PinotConfiguration; + +/** + * Environment Provider interface implemented by different cloud providers to customize + * the base pinot configuration to add environment variables & instance specific configuration + */ +public interface PinotEnvironmentProvider { + + String INSTANCE_FAILURE_DOMAIN = "pinot.environment.instance.failureDomain"; + + /** + * Customize base pinot configuration to add environment variables & instance specific configuration + * @return custom pinot configuration map + */ + Map<String, Object> getEnvironment(); Review comment: Let us say, we have two cloud implementations, returning their map that we write to instance config today: Azure returns: {"failureDomain": "foo", "Mem": "1024GB"} And cloudX returns {"failureDomain" : "bar", "Memory" : 64GB"} Assume that at some point later we want to add functionality where pinot behaves depending on memory in the system (say, it routes more queries to servers having more memory, or allocatets more segments, or whatever). What would pinot code look like? (and each provider will claim that they are already providing that information) My guess is it would be like: ` mem = map.get("MEM"); if (mem == null) {mem = map.get("MEMORY");} ` Bad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
