jackjlli commented on a change in pull request #6898:
URL: https://github.com/apache/incubator-pinot/pull/6898#discussion_r631423508
##########
File path:
pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java
##########
@@ -149,7 +149,7 @@ public void testOfflineTableNotnullQuota()
ZKMetadataProvider
.setOfflineTableConfig(_testPropertyStore, OFFLINE_TABLE_NAME,
TableConfigUtils.toZNRecord(tableConfig));
setQps(tableConfig);
- _queryQuotaManager.initTableQueryQuota(tableConfig, brokerResource);
+ _queryQuotaManager.initOrUpdateTableQueryQuota(tableConfig,
brokerResource);
Review comment:
Discussed offline. It's a bit hard to add the test since the value
callback function cannot be directly fetched from broker metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
