[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for queries(#6787)

[GitBox]

mcvsubbu commented on a change in pull request #6901:
URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r631251714



##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -112,14 +121,18 @@ function stopService() {
 # Starts a Pinot cluster given a specific target directory
 function startServices() {
   dirName=$1
+  local CONTROLLER_CONF=$2/ControllerConfig.conf

Review comment:
       Not local, move this up in the script to make it non-local (remove the 
local keyword). You can put it in line 42

##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -169,6 +182,11 @@ 
COMPAT_TESTER_PATH="pinot-integration-tests/target/pinot-integration-tests-pkg/b
 # create subdirectories for given commits
 workingDir=$1
 testSuiteDir=$(absPath "$2")
+
+BROKER_CONF=${testSuiteDir}/config/BrokerConfig.conf

Review comment:
       You will now be able to reuse ${BROKER_CONF} everywhere in the script.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org