desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r631309663
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ########## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.environmentprovider; + +import java.util.Map; +import org.apache.pinot.spi.env.PinotConfiguration; + +/** + * Environment Provider interface implemented by different cloud providers to customize + * the base pinot configuration to add environment variables & instance specific configuration + */ +public interface PinotEnvironmentProvider { + + /** + * Initializes the configurations specific to an environment provider. + */ + void init(PinotConfiguration pinotConfiguration); + + /** + * Customize base pinot configuration to add environment variables & instance specific configuration + * @return custom pinot configuration map + */ + Map<String, String> getEnvironment(); Review comment: The plan is to add all the environment properties under mapFields. If u see the getEnvironment() method returns a Map. For now we are only adding FD information, but other cloud providers can add other environment properties. At HelixServerStarter layer we will update instanceConfig with the entire map returned by getEnvironment() call. Currently, the only thing pinot can derive sense out of is the failure domain information. Pinot can use FD information to assign server to server pools to facilitate segment & replica group assignments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
