mcvsubbu commented on a change in pull request #6890:
URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r631448893
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java
##########
@@ -131,6 +135,51 @@ private String generateServerURL(String tableNameWithType,
String endpoint) {
return String.format("%s/tables/%s/consumingSegmentsInfo", endpoint,
tableNameWithType);
}
+ /**
+ * Utility method to derive ingestion status from consuming segment Info.
Status is HEALTHY if
+ * consuming segment info specifies CONSUMING state for all active segments
across all servers
+ * including replicas.
+ */
+ public TableStatus.IngestionStatus getIngestionStatus(String
tableNameWithType, int timeoutMs) {
+ try {
+ ConsumingSegmentsInfoMap consumingSegmentsInfoMap =
getConsumingSegmentsInfo(tableNameWithType, timeoutMs);
+ for (Map.Entry<String, List<ConsumingSegmentInfo>>
consumingSegmentInfoEntry : consumingSegmentsInfoMap._segmentToConsumingInfoMap
+ .entrySet()) {
+ String segmentName = consumingSegmentInfoEntry.getKey();
+ List<ConsumingSegmentInfo> consumingSegmentInfoList =
consumingSegmentInfoEntry.getValue();
+ if (consumingSegmentInfoList == null ||
consumingSegmentInfoList.isEmpty()) {
+ String errorMessage = "Did not get any response from servers for
segment: " + segmentName;
+ return
TableStatus.IngestionStatus.newIngestionStatus(TableStatus.IngestionState.UNHEALTHY,
errorMessage);
Review comment:
Looks like we return the first time we find a bad consumer. Don't we
want to provide the congestion status of each partition/segment?
Let us say the user finds out that the status is unhealthy (which, btw, they
can also find out using metrics). What would they do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
