[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#issuecomment-755937745 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6419?src=pr&el=h1) Report > Merging [#6419](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r557050072 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/StreamOp.java ## @@ -85,4 +116,118 @@ boolean runOp() { publi

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6440: Add authentication for write endpoints of Controller resources

2021-01-13 Thread GitBox
sajjad-moradi commented on a change in pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440#discussion_r557049902 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java ## @@ -35,4 +35,25 @@ * @return

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6440: Add authentication for write endpoints of Controller resources

2021-01-13 Thread GitBox
kishoreg commented on a change in pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440#discussion_r557049026 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java ## @@ -35,4 +35,25 @@ * @return Wheth

[GitHub] [incubator-pinot] sajjad-moradi commented on pull request #6440: Add authentication for write endpoints of Controller resources

2021-01-13 Thread GitBox
sajjad-moradi commented on pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440#issuecomment-759930512 > Great feature addition! This is long time due for Pinot. Thanks for investing your time on this area. > > Out of curiosity, have you considered implementin

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
yupeng9 commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557031204 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -93,27 +93,37 @@ public BaseFilterOperator run() {

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
mayankshriv commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r557027753 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java ## @@ -239,17 +240,24 @@ private bool

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
mayankshriv commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r557027753 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java ## @@ -239,17 +240,24 @@ private bool

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
mayankshriv commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r557027753 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java ## @@ -239,17 +240,24 @@ private bool

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
mayankshriv commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r557026613 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/FloatDictionary.java ## @@ -30,7 +31,24 @@ public FloatDic

[GitHub] [incubator-pinot] mr-agrwal closed pull request #6438: use tableNameWithType to delete segments from

2021-01-13 Thread GitBox
mr-agrwal closed pull request #6438: URL: https://github.com/apache/incubator-pinot/pull/6438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557020612 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java ## @@ -50,94 +46,164 @@ public clas

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557020178 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java ## @@ -50,94 +46,164 @@ public clas

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557019905 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ## @@ -93,27 +93,37 @@ public BaseFilterOperator run()

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557019310 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/geospatial/MutableH3Index.java ## @@ -18,48 +18,53 @@ */ packa

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557019187 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -260,6 +274,19 @@ p

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557018737 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/H3IndexHandler.java ## @@ -86,72 +88,77 @@ p

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557018411 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/BitmapInvertedIndexReader.java ## @@ -18,84 +18,71 @@ *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
Jackie-Jiang commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557017780 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ## @@ -47,15 +48,15 @@ import or

[GitHub] [incubator-pinot] rec7y33 commented on issue #6201: add table realtime error 500 org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory

2021-01-13 Thread GitBox
rec7y33 commented on issue #6201: URL: https://github.com/apache/incubator-pinot/issues/6201#issuecomment-759890850 > > Hi there I have the exact same problem. How did you fix it? > > I start pinot with docker following guides in quickstart, ingesting data from kafka in another server.

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6441: Bug Fix column metadata, read from the correct property config for ha…

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6441: URL: https://github.com/apache/incubator-pinot/pull/6441#issuecomment-759871683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6441?src=pr&el=h1) Report > Merging [#6441](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] rec7y33 commented on issue #6201: add table realtime error 500 org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory

2021-01-13 Thread GitBox
rec7y33 commented on issue #6201: URL: https://github.com/apache/incubator-pinot/issues/6201#issuecomment-759889001 > > > Hi there I have the exact same problem. How did you fix it? > > > I start pinot with docker following guides in quickstart, ingesting data from kafka in another serv

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6441: Bug Fix column metadata, read from the correct property config for ha…

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6441: URL: https://github.com/apache/incubator-pinot/pull/6441#issuecomment-759871683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6441?src=pr&el=h1) Report > Merging [#6441](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] daniellavoie commented on pull request #6440: Add authentication for write endpoints of Controller resources

2021-01-13 Thread GitBox
daniellavoie commented on pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440#issuecomment-759884459 Great feature addition! This is long time due for Pinot. Thanks for investing your time on this area. Out of curiosity, have you considered implementing autho

[GitHub] [incubator-pinot] codecov-io commented on pull request #6441: Bug Fix column metadata, read from the correct property config for ha…

2021-01-13 Thread GitBox
codecov-io commented on pull request #6441: URL: https://github.com/apache/incubator-pinot/pull/6441#issuecomment-759871683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6441?src=pr&el=h1) Report > Merging [#6441](https://codecov.io/gh/apache/incubator-pinot/pull/6441?s

[GitHub] [incubator-pinot] pradeepgv42 opened a new pull request #6441: Bug Fix column metadata, read from the correct property config for ha…

2021-01-13 Thread GitBox
pradeepgv42 opened a new pull request #6441: URL: https://github.com/apache/incubator-pinot/pull/6441 Bug Fix column metadata, read from the correct property config for hasFSTIndex This is an automated message from the Apach

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r556936513 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java ## @@ -239,17 +240,24 @@ private boolea

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r556936513 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java ## @@ -239,17 +240,24 @@ private boolea

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
yupeng9 commented on a change in pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r556848494 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ## @@ -47,15 +48,15 @@ import org.apa

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r556931457 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/FloatDictionary.java ## @@ -30,7 +31,24 @@ public FloatDicti

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r556931457 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/FloatDictionary.java ## @@ -30,7 +31,24 @@ public FloatDicti

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r556931457 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/FloatDictionary.java ## @@ -30,7 +31,24 @@ public FloatDicti

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
mayankshriv commented on a change in pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r556908539 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/FloatDictionary.java ## @@ -30,7 +31,24 @@ public FloatDic

[GitHub] [incubator-pinot] fx19880617 commented on issue #6439: Support of Mode(Statistics)

2021-01-13 Thread GitBox
fx19880617 commented on issue #6439: URL: https://github.com/apache/incubator-pinot/issues/6439#issuecomment-759775466 Is there an existing library for this? From the definition, seems we need to construct the distributions of the data, seems to be a costly function as well.

[GitHub] [incubator-pinot] pradeepgv42 commented on a change in pull request #6120: Add FST Index using lucene lib to speedup regexp queries

2021-01-13 Thread GitBox
pradeepgv42 commented on a change in pull request #6120: URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r556865318 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/metadata/ColumnMetadata.java ## @@ -97,6 +98,7 @@ public static Co

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#issuecomment-754395900 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6409?src=pr&el=h1) Report > Merging [#6409](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6120: Add FST Index using lucene lib to speedup regexp queries

2021-01-13 Thread GitBox
fx19880617 commented on a change in pull request #6120: URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r556852416 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/metadata/ColumnMetadata.java ## @@ -97,6 +98,7 @@ public static Col

[GitHub] [incubator-pinot] codecov-io commented on pull request #6440: Add authentication for write endpoints of Controller resources

2021-01-13 Thread GitBox
codecov-io commented on pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440#issuecomment-759753751 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6440?src=pr&el=h1) Report > Merging [#6440](https://codecov.io/gh/apache/incubator-pinot/pull/6440?s

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6409: Merge H3-index branch to master

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6409: URL: https://github.com/apache/incubator-pinot/pull/6409#issuecomment-754395900 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6409?src=pr&el=h1) Report > Merging [#6409](https://codecov.io/gh/apache/incubator-pinot/pull

[incubator-pinot] branch master updated (33830cb -> 68fbb9c)

2021-01-13 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 33830cb [TE] suppress the anomaly if current value is NaN (#6428) add 68fbb9c [TE] frontend - harleyjj

[GitHub] [incubator-pinot] jihaozh merged pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
jihaozh merged pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-pinot] branch master updated: [TE] suppress the anomaly if current value is NaN (#6428)

2021-01-13 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 33830cb [TE] suppress the anomaly if cu

[GitHub] [incubator-pinot] jihaozh merged pull request #6428: [TE] suppress the anomaly if current value is NaN

2021-01-13 Thread GitBox
jihaozh merged pull request #6428: URL: https://github.com/apache/incubator-pinot/pull/6428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6418: TLS-support for client-pinot and pinot-internode connections

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#issuecomment-755917563 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6418?src=pr&el=h1) Report > Merging [#6418](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6440: Add authentication for write endpoints of Controller resources

2021-01-13 Thread GitBox
sajjad-moradi opened a new pull request #6440: URL: https://github.com/apache/incubator-pinot/pull/6440 ## Description - This PR modifies `AccessControl` interface to add methods for checking if the client has permission for Controller endpoints which modifies the state of the system ei

[incubator-pinot] branch pinot-internode-tls updated (00be12e -> af7003d)

2021-01-13 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch pinot-internode-tls in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 00be12e test fixes round 2 add af7003d test fixes round 3 No new revisions were added

[GitHub] [incubator-pinot] mr-agrwal opened a new issue #6439: Support of Mode(Statistics)

2021-01-13 Thread GitBox
mr-agrwal opened a new issue #6439: URL: https://github.com/apache/incubator-pinot/issues/6439 Add support of [Mode](https://en.wikipedia.org/wiki/Mode_(statistics)) Function. A couple of strategies for calculating the same can be implemented. 1. Max among the Mode values. 2. A

[GitHub] [incubator-pinot] mr-agrwal opened a new pull request #6438: use tableNameWithType to delete segments from

2021-01-13 Thread GitBox
mr-agrwal opened a new pull request #6438: URL: https://github.com/apache/incubator-pinot/pull/6438 ## Description Fixes Issue https://github.com/apache/incubator-pinot/issues/6436 Ideally, deletion should look at the segments in the table_name_with_type folder as that is where th

[GitHub] [incubator-pinot] amitchopraait opened a new issue #6437: Getting numGroupsLimitReached for medium cardinality column (10000 distinct values)

2021-01-13 Thread GitBox
amitchopraait opened a new issue #6437: URL: https://github.com/apache/incubator-pinot/issues/6437 I have a column with 1 distinct values. select count(distinct(device)) from metrics { "resultTable": { "dataSchema": { "columnNames": [ "distin

[GitHub] [incubator-pinot] mr-agrwal opened a new issue #6436: Deletion of segments not working properly

2021-01-13 Thread GitBox
mr-agrwal opened a new issue #6436: URL: https://github.com/apache/incubator-pinot/issues/6436 When Uploading segments to controller using Segment Uri Push, It is putting the segments in path `fake_job_for_testing_time_based_OFFLINE/fake_job_for_testing_time_based_OFFLINE_18597_18597_0`

[incubator-pinot] branch master updated (3d24302 -> 19e3d51)

2021-01-13 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3d24302 refactor AnomaliesResponses to avoid duplicate code (#6406) add 19e3d51 [TE] endpoint - harley

[GitHub] [incubator-pinot] jihaozh merged pull request #6432: [TE] endpoint - harleyjj/rca - add forecast, upper, lower, and yoXy t…

2021-01-13 Thread GitBox
jihaozh merged pull request #6432: URL: https://github.com/apache/incubator-pinot/pull/6432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #6432: [TE] endpoint - harleyjj/rca - add forecast, upper, lower, and yoXy t…

2021-01-13 Thread GitBox
jihaozh commented on a change in pull request #6432: URL: https://github.com/apache/incubator-pinot/pull/6432#discussion_r556764581 ## File path: thirdeye/thirdeye-dashboard/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/RootCauseMetricResource.java ## @@ -284,

[GitHub] [incubator-pinot] alexandervivas edited a comment on issue #6433: Consumption from external kafka instances in third party services

2021-01-13 Thread GitBox
alexandervivas edited a comment on issue #6433: URL: https://github.com/apache/incubator-pinot/issues/6433#issuecomment-759484544 Hey @fx19880617 and @npawar, thanks for commenting. By the time we started to test pinot for our analytics modules in pinot docs there wasn't any way to

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
codecov-io edited a comment on pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#issuecomment-759105793 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6403?src=pr&el=h1) Report > Merging [#6403](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
mcvsubbu commented on pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#issuecomment-759640818 > Question: Do we need to modify type handling in `ConstantValueLongDictionary`, `ConstantValueIntDictionary`, `ConstantValueFloatDictionary`, and `ConstantValueDoubleD

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
harleyjj commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556743481 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js ## @@ -189,10 +251,10 @@ export default Component.ex

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
harleyjj commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556732923 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js ## @@ -189,10 +251,10 @@ export default Component.ex

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
harleyjj commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556732414 ## File path: thirdeye/thirdeye-frontend/app/pods/services/rootcause-aggregates-cache/service.js ## @@ -28,7 +23,7 @@ export default Service.ext

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
harleyjj commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556732113 ## File path: thirdeye/thirdeye-frontend/app/pods/services/rootcause-aggregates-cache/service.js ## @@ -68,34 +67,34 @@ export default Service.e

[GitHub] [incubator-pinot] amrishlal edited a comment on pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal edited a comment on pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#issuecomment-759619753 Question: Do we need to modify type handling in `ConstantValueLongDictionary`, `ConstantValueIntDictionary`, `ConstantValueFloatDictionary`, and `ConstantValueD

[GitHub] [incubator-pinot] amrishlal commented on pull request #6403: Fix upcasting/downcasting of numerical values used in SQL predicates.

2021-01-13 Thread GitBox
amrishlal commented on pull request #6403: URL: https://github.com/apache/incubator-pinot/pull/6403#issuecomment-759619753 Question: Do we need to modify type handling in ConstantValueLongDictionary, ConstantValueIntDictionary, ConstantValueFloatDictionary, and ConstantValueDoubleDictionar

[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
zhangloo333 commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556705320 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js ## @@ -189,10 +251,10 @@ export default Component

[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
zhangloo333 commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556706898 ## File path: thirdeye/thirdeye-frontend/app/pods/services/rootcause-aggregates-cache/service.js ## @@ -68,34 +67,34 @@ export default Servic

[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
zhangloo333 commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556705593 ## File path: thirdeye/thirdeye-frontend/app/pods/services/rootcause-aggregates-cache/service.js ## @@ -28,7 +23,7 @@ export default Service.

[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
zhangloo333 commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556705320 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js ## @@ -189,10 +251,10 @@ export default Component

[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

2021-01-13 Thread GitBox
zhangloo333 commented on a change in pull request #6333: URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556701271 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js ## @@ -65,10 +56,29 @@ export default Component.e

[GitHub] [incubator-pinot] alexandervivas edited a comment on issue #6433: Consumption from external kafka instances in third party services

2021-01-13 Thread GitBox
alexandervivas edited a comment on issue #6433: URL: https://github.com/apache/incubator-pinot/issues/6433#issuecomment-759484544 Hey @fx19880617 and @npawar, thanks for commenting. By the time we started to test pinot for our analytics modules in pinot docs there wasn't any way to

[GitHub] [incubator-pinot] alexandervivas edited a comment on issue #6433: Consumption from external kafka instances in third party services

2021-01-13 Thread GitBox
alexandervivas edited a comment on issue #6433: URL: https://github.com/apache/incubator-pinot/issues/6433#issuecomment-759484544 Hey @fx19880617 and @npawar, thanks for commenting. By the time we started to test pinot for our analytics modules in pinot docs there wasn't any way to

[GitHub] [incubator-pinot] alexandervivas edited a comment on issue #6433: Consumption from external kafka instances in third party services

2021-01-13 Thread GitBox
alexandervivas edited a comment on issue #6433: URL: https://github.com/apache/incubator-pinot/issues/6433#issuecomment-759484544 Hey @fx19880617 and @npawar, thanks for commenting. By the time we started to test pinot for our analytics modules in pinot docs there wasn't any way to

[GitHub] [incubator-pinot] alexandervivas commented on issue #6433: Consumption from external kafka instances in third party services

2021-01-13 Thread GitBox
alexandervivas commented on issue #6433: URL: https://github.com/apache/incubator-pinot/issues/6433#issuecomment-759484544 Hey @fx19880617 and @npawar, thanks for commenting. By the time we started to test pinot for our analytics modules in pinot docs there wasn't any way to configu

[GitHub] [incubator-pinot] fx19880617 commented on issue #6201: add table realtime error 500 org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory

2021-01-13 Thread GitBox
fx19880617 commented on issue #6201: URL: https://github.com/apache/incubator-pinot/issues/6201#issuecomment-759347099 > > Hi there I have the exact same problem. How did you fix it? > > I start pinot with docker following guides in quickstart, ingesting data from kafka in another serve

[GitHub] [incubator-pinot] fx19880617 commented on issue #6201: add table realtime error 500 org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory

2021-01-13 Thread GitBox
fx19880617 commented on issue #6201: URL: https://github.com/apache/incubator-pinot/issues/6201#issuecomment-759345040 > Hi there I have the exact same problem. How did you fix it? > I start pinot with docker following guides in quickstart, ingesting data from kafka in another server.

[GitHub] [incubator-pinot] fx19880617 commented on issue #6298: Support Describe Pinot table and schema

2021-01-13 Thread GitBox
fx19880617 commented on issue #6298: URL: https://github.com/apache/incubator-pinot/issues/6298#issuecomment-759335011 > Thanks for the clarification! > > Yes, parsing `SHOW ` should be straight forward implementation. > Here is the list of SHOW SQL Statements in the scope (Please

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556375473 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/StreamOp.java ## @@ -85,4 +116,118 @@ boolean runOp() { publi

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556360715 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/StreamOp.java ## @@ -85,4 +116,118 @@ boolean runOp() { publi

[GitHub] [incubator-pinot] rec7y33 commented on issue #6201: add table realtime error 500 org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory

2021-01-13 Thread GitBox
rec7y33 commented on issue #6201: URL: https://github.com/apache/incubator-pinot/issues/6201#issuecomment-759306714 Hi there I have the exact same problem. How did you fix it? I start pinot with docker following guides in quickstart, ingesting data from kafka in another server. I did

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556348330 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/AvroSchemaKafkaAvroMessageDecoder.java ## @@ -0,0 +1,69 @@ +/**

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556352861 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/AvroSchemaKafkaAvroMessageDecoder.java ## @@ -0,0 +1,69 @@ +/**

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556348330 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/AvroSchemaKafkaAvroMessageDecoder.java ## @@ -0,0 +1,69 @@ +/**

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556348330 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/AvroSchemaKafkaAvroMessageDecoder.java ## @@ -0,0 +1,69 @@ +/**

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556348330 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/AvroSchemaKafkaAvroMessageDecoder.java ## @@ -0,0 +1,69 @@ +/**

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556340684 ## File path: compatibility-verifier/compCheck.sh ## @@ -72,29 +72,31 @@ function checkoutAndBuild() { popd || exit 1 } -# Given a component

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6419: Compatibility test: streamOp

2021-01-13 Thread GitBox
jtao15 commented on a change in pull request #6419: URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556339464 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/AvroRowExtractor.java ## @@ -0,0 +1,145 @@ +/** + * Licensed to