mayankshriv commented on a change in pull request #6403:
URL: https://github.com/apache/incubator-pinot/pull/6403#discussion_r557026613
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/FloatDictionary.java
##########
@@ -30,7 +31,24 @@ public FloatDictionary(PinotDataBuffer dataBuffer, int
length) {
@Override
public int insertionIndexOf(String stringValue) {
- return binarySearch(Float.parseFloat(stringValue));
+ // First convert string to BigDecimal and then downcast to int. This
allows type conversion from any compatible
+ // numerical value represented as string to an int value.
+ BigDecimal bigDecimal = new BigDecimal(stringValue);
Review comment:
What is the expected behavior from other SQL engines if the value does
not match the column data type: `intColumn < 3000000000.453`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
