zhangloo333 commented on a change in pull request #6333:
URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556701271
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js
##########
@@ -65,10 +56,29 @@ export default Component.extend({
*/
onSelection: null, // function (Set, state)
+ context: null,
+
+ compareMode: null, // ""
Review comment:
We can keep null or undefined because of the warning. I suggest adding
the comment for those variables to state the variable expected type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
