jtao15 commented on a change in pull request #6419:
URL: https://github.com/apache/incubator-pinot/pull/6419#discussion_r556340684
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -72,29 +72,31 @@ function checkoutAndBuild() {
popd || exit 1
}
-# Given a component and directory, start that version of the specific
component
+# Given a component and directory, start that version of the specific component
function startService() {
serviceName=$1
dirName=$2
# Upon start, save the pid of the process for a component into a file in
/tmp/{component}.pid, which is then used to stop it
pushd "$dirName"/pinot-tools/target/pinot-tools-pkg/bin || exit 1
if [ "$serviceName" = "zookeeper" ]; then
sh -c 'echo $$ > $0/zookeeper.pid; exec ./pinot-admin.sh StartZookeeper'
"${dirName}" &
- elif [ "$serviceName" = "controller" ]; then
+ elif [ "$serviceName" = "controller" ]; then
sh -c 'echo $$ > $0/controller.pid; exec ./pinot-admin.sh StartController'
"${dirName}" &
elif [ "$serviceName" = "broker" ]; then
sh -c 'echo $$ > $0/broker.pid; exec ./pinot-admin.sh StartBroker'
"${dirName}" &
elif [ "$serviceName" = "server" ]; then
sh -c 'echo $$ > $0/server.pid; exec ./pinot-admin.sh StartServer'
"${dirName}" &
- fi
+ elif [ "$serviceName" = "kafka" ]; then
+ sh -c 'echo $$ > $0/kafka.pid; exec ./pinot-admin.sh StartKafka -zkAddress
localhost:2181/kafka' "${dirName}" &
Review comment:
Kafka service will connect to `localhost:2191` by default, but the
zookeeper runs on 2181 by default, so I add this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
