harleyjj commented on a change in pull request #6333:
URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556743481
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js
##########
@@ -189,10 +251,10 @@ export default Component.extend({
* @type {Array}
*/
preselectedItems: computed({
- get () {
+ get() {
return [];
},
- set () {
+ set() {
// ignore
}
}),
Review comment:
The property gets passed down, so I believe it is being used. It seems
it was done to address a bug. I'd better leave it.
https://github.com/apache/incubator-pinot/commit/fb3c74dfd6f4c5dafdf42a11ba7977426b0dcf2a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
