Jackie-Jiang commented on a change in pull request #6409:
URL: https://github.com/apache/incubator-pinot/pull/6409#discussion_r557020178
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java
##########
@@ -50,94 +46,164 @@
public class H3IndexFilterOperator extends BaseFilterOperator {
private static final String OPERATOR_NAME = "H3IndexFilterOperator";
+ private final IndexSegment _segment;
private final Predicate _predicate;
- private final DataSource _dataSource;
private final int _numDocs;
- private final H3Core _h3Core;
- private final IndexSegment _segment;
private final H3IndexReader _h3IndexReader;
- private final H3IndexResolution _resolution;
- final private Geometry _geometry;
- final private double _distance;
+ private final long _h3Id;
+ private final double _edgeLength;
+ private final double _lowerBound;
+ private final double _upperBound;
- public H3IndexFilterOperator(Predicate predicate, IndexSegment indexSegment,
int numDocs) {
+ public H3IndexFilterOperator(IndexSegment segment, Predicate predicate, int
numDocs) {
+ _segment = segment;
_predicate = predicate;
- _segment = indexSegment;
- FunctionContext function = predicate.getLhs().getFunction();
- String columnName;
-
- // TODO: handle composite function that contains ST_DISTANCE
Review comment:
Added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
