[GitHub] [doris] github-actions[bot] commented on pull request #22934: [improvement](regression) remove sf1DataPath item of config to make …

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22934: URL: https://github.com/apache/doris/pull/22934#issuecomment-1676781743 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #22934: [improvement](regression) remove sf1DataPath item of config to make …

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22934: URL: https://github.com/apache/doris/pull/22934#issuecomment-1676781696 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[doris] branch branch-1.2-lts updated (b7f163e4d6 -> b51838b8a9)

2023-08-13 Thread zykkk
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a change to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git from b7f163e4d6 [fix](agg) fix coredump caused by push down count aggregation (#22699) add b51838b8a9 [chore](b

[GitHub] [doris] zy-kkk merged pull request #22937: [chore](broker) fix broker compile error

2023-08-13 Thread via GitHub
zy-kkk merged PR #22937: URL: https://github.com/apache/doris/pull/22937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

[GitHub] [doris] zy-kkk opened a new pull request, #22937: [chore](broker) fix broker compile error

2023-08-13 Thread via GitHub
zy-kkk opened a new pull request, #22937: URL: https://github.com/apache/doris/pull/22937 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d

[GitHub] [doris] hello-stephen opened a new pull request, #22936: [fix](case) edit to same as branch master

2023-08-13 Thread via GitHub
hello-stephen opened a new pull request, #22936: URL: https://github.com/apache/doris/pull/22936 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

[GitHub] [doris] hello-stephen commented on pull request #22923: [Improvement] Optimize count operation for iceberg

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22923: URL: https://github.com/apache/doris/pull/22923#issuecomment-1676779138 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.44 seconds stream load tsv: 515 seconds loaded 74807831229 Bytes

[GitHub] [doris] gwxog closed pull request #21667: Fixed the upgrade.md in the admin-manual

2023-08-13 Thread via GitHub
gwxog closed pull request #21667: Fixed the upgrade.md in the admin-manual URL: https://github.com/apache/doris/pull/21667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris-spark-connector] lxwcodemonkey opened a new pull request, #126: [improvement] set streamLoad prop num_as_string default true to avoid…

2023-08-13 Thread via GitHub
lxwcodemonkey opened a new pull request, #126: URL: https://github.com/apache/doris-spark-connector/pull/126 … loss of floating point precision # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Req

[GitHub] [doris] morningman opened a new pull request, #22935: [branch-2.0](nereids)(catalog) fix hive partition prune bug

2023-08-13 Thread via GitHub
morningman opened a new pull request, #22935: URL: https://github.com/apache/doris/pull/22935 ## Proposed changes Some code is missing when cherry pick #21998 This will cause partition prune failure in hive scan node ## Further comments If this is a relatively large o

[GitHub] [doris] zgxme opened a new pull request, #22934: [improvement](regression) remove sf1DataPath item of config to make …

2023-08-13 Thread via GitHub
zgxme opened a new pull request, #22934: URL: https://github.com/apache/doris/pull/22934 …data sources uniform ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d..

[GitHub] [doris-spark-connector] lxwcodemonkey closed pull request #91: improve the sink format handle logic by factory pattern

2023-08-13 Thread via GitHub
lxwcodemonkey closed pull request #91: improve the sink format handle logic by factory pattern URL: https://github.com/apache/doris-spark-connector/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] yiguolei commented on a diff in pull request #22442: [enhancement](delete-predicate) enhance delete sub predicate

2023-08-13 Thread via GitHub
yiguolei commented on code in PR #22442: URL: https://github.com/apache/doris/pull/22442#discussion_r1293032407 ## be/src/olap/delete_handler.cpp: ## @@ -259,21 +303,14 @@ Status DeleteHandler::init(TabletSchemaSPtr tablet_schema, auto& delete_condition = delete_pred->d

[GitHub] [doris] yiguolei commented on a diff in pull request #22442: [enhancement](delete-predicate) enhance delete sub predicate

2023-08-13 Thread via GitHub
yiguolei commented on code in PR #22442: URL: https://github.com/apache/doris/pull/22442#discussion_r1293031566 ## gensrc/proto/olap_file.proto: ## @@ -142,6 +142,13 @@ message DeletePredicatePB { required int32 version = 1; // This field is useless, but could not removed,

[GitHub] [doris] mrhhsg commented on pull request #22932: [Bug](aggregation)fix for map_agg when columns[1] is nullable

2023-08-13 Thread via GitHub
mrhhsg commented on PR #22932: URL: https://github.com/apache/doris/pull/22932#issuecomment-1676763611 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #22932: [Bug](aggregation)fix for map_agg when columns[1] is nullable

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22932: URL: https://github.com/apache/doris/pull/22932#issuecomment-1676762625 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] amorynan commented on pull request #22927: [Improve](complex-type) update for array/map element_at with nested complex type with local tvf

2023-08-13 Thread via GitHub
amorynan commented on PR #22927: URL: https://github.com/apache/doris/pull/22927#issuecomment-1676760874 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] hello-stephen commented on pull request #22823: [bug](if) fix if function not handle const nullable value

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22823: URL: https://github.com/apache/doris/pull/22823#issuecomment-1676760590 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.11 seconds stream load tsv: 512 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #22442: [enhancement](delete-predicate) enhance delete sub predicate

2023-08-13 Thread via GitHub
yiguolei commented on code in PR #22442: URL: https://github.com/apache/doris/pull/22442#discussion_r1293028024 ## be/src/olap/delete_handler.cpp: ## @@ -203,7 +205,20 @@ Status DeleteHandler::check_condition_valid(const TabletSchema& schema, const TC return Status::OK();

[doris] branch master updated (fa6110accd -> 8f471a3a1f)

2023-08-13 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from fa6110accd [fix](catalog)paimon support more data type (#22899) add 8f471a3a1f [fix](Nereids) push agg to meta

[GitHub] [doris] morrySnow merged pull request #22811: [fix](Nereids) push agg to meta scan is not work well

2023-08-13 Thread via GitHub
morrySnow merged PR #22811: URL: https://github.com/apache/doris/pull/22811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #22933: [feature](geometry) Support geometry type and more Geo functions

2023-08-13 Thread via GitHub
github-actions[bot] commented on code in PR #22933: URL: https://github.com/apache/doris/pull/22933#discussion_r1293026907 ## be/src/geo/util/GeoCircle.h: ## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

[GitHub] [doris] hello-stephen commented on pull request #22606: [stats](nereids)support partition stats

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22606: URL: https://github.com/apache/doris/pull/22606#issuecomment-167678 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.78 seconds stream load tsv: 507 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #22932: [Bug](aggregation)fix for map_agg when columns[1] is nullable

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22932: URL: https://github.com/apache/doris/pull/22932#issuecomment-1676753420 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21933: [feature](delete) support delete on value column for unique table

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #21933: URL: https://github.com/apache/doris/pull/21933#issuecomment-1676750898 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #22923: [Improvement] Optimize count operation for iceberg

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22923: URL: https://github.com/apache/doris/pull/22923#issuecomment-1676749408 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21933: [feature](delete) support delete on value column for unique table

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #21933: URL: https://github.com/apache/doris/pull/21933#issuecomment-1676749347 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] LemonLiTree opened a new pull request, #22933: [feature](geometry) Support geometry type and more Geo functions

2023-08-13 Thread via GitHub
LemonLiTree opened a new pull request, #22933: URL: https://github.com/apache/doris/pull/22933 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mai

[GitHub] [doris] LemonLiTree closed pull request #18999: [feature](geometry) Support geometry type

2023-08-13 Thread via GitHub
LemonLiTree closed pull request #18999: [feature](geometry) Support geometry type URL: https://github.com/apache/doris/pull/18999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] github-actions[bot] commented on pull request #22927: [Improve](complex-type) update for array/map element_at with nested complex type with local tvf

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22927: URL: https://github.com/apache/doris/pull/22927#issuecomment-1676747916 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #22442: [enhancement](delete-predicate) enhance delete sub predicate

2023-08-13 Thread via GitHub
TangSiyang2001 commented on code in PR #22442: URL: https://github.com/apache/doris/pull/22442#discussion_r129301 ## be/src/olap/delete_handler.cpp: ## @@ -81,35 +82,36 @@ Status DeleteHandler::generate_delete_predicate(const TabletSchema& schema, LOG(INFO) <<

[GitHub] [doris] xingyingone opened a new pull request, #22932: [Bug](aggregation)fix for map_agg when columns[1] is nullable

2023-08-13 Thread via GitHub
xingyingone opened a new pull request, #22932: URL: https://github.com/apache/doris/pull/22932 ## Proposed changes Issue Number: close https://github.com/apache/doris/issues/22518 In the map_agg handler function, added the judgment on columns[1]->is_nullable() ## Further

[GitHub] [doris] bobhan1 commented on pull request #21933: [feature](delete) support delete on value column for unique table

2023-08-13 Thread via GitHub
bobhan1 commented on PR #21933: URL: https://github.com/apache/doris/pull/21933#issuecomment-1676744258 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] wuwenchi commented on pull request #22923: [Improvement] Optimize count operation for iceberg

2023-08-13 Thread via GitHub
wuwenchi commented on PR #22923: URL: https://github.com/apache/doris/pull/22923#issuecomment-1676744019 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] yiguolei commented on a diff in pull request #22442: [enhancement](delete-predicate) enhance delete sub predicate

2023-08-13 Thread via GitHub
yiguolei commented on code in PR #22442: URL: https://github.com/apache/doris/pull/22442#discussion_r1293015284 ## be/src/olap/delete_handler.cpp: ## @@ -81,35 +82,36 @@ Status DeleteHandler::generate_delete_predicate(const TabletSchema& schema, LOG(INFO) << "store

[GitHub] [doris] zhangguoqiang666 commented on pull request #22839: [test]test external pipeline 0810

2023-08-13 Thread via GitHub
zhangguoqiang666 commented on PR #22839: URL: https://github.com/apache/doris/pull/22839#issuecomment-1676743284 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] ynzzxc opened a new issue, #22931: [Bug] 升级到 doris-2.0.0-rc04 后,jdbc sqlserver catalog 无法访问

2023-08-13 Thread via GitHub
ynzzxc opened a new issue, #22931: URL: https://github.com/apache/doris/issues/22931 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-2.0.0-rc04

[GitHub] [doris] englefly commented on pull request #22606: [stats](nereids)support partition stats

2023-08-13 Thread via GitHub
englefly commented on PR #22606: URL: https://github.com/apache/doris/pull/22606#issuecomment-1676730651 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] hello-stephen commented on pull request #22924: [bug](shuffle) set local exchange for serializer

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22924: URL: https://github.com/apache/doris/pull/22924#issuecomment-1676728528 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.85 seconds stream load tsv: 522 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #22855: [performance](executor) optimize time_round function only one arg

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22855: URL: https://github.com/apache/doris/pull/22855#issuecomment-1676727765 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.15 seconds stream load tsv: 517 seconds loaded 74807831229 Bytes

[doris] branch master updated (d371101bfd -> fa6110accd)

2023-08-13 Thread zykkk
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d371101bfd [Improvement](aggregation) make fixed hashmap's bitmap_size flexable (#22573) add fa6110accd [fix](cata

[GitHub] [doris] zy-kkk merged pull request #22899: [fix](catalog)paimon support more data type

2023-08-13 Thread via GitHub
zy-kkk merged PR #22899: URL: https://github.com/apache/doris/pull/22899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

[GitHub] [doris] hello-stephen commented on pull request #22930: [improve](jdbc catalog) Add more detailed exception logging to the jdbc catalog

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22930: URL: https://github.com/apache/doris/pull/22930#issuecomment-1676715802 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.61 seconds stream load tsv: 512 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #22770: [Fix](planner)fix incorrect nullable in ctas.

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22770: URL: https://github.com/apache/doris/pull/22770#issuecomment-1676715598 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.57 seconds stream load tsv: 511 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #22924: [bug](shuffle) set local exchange for serializer

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22924: URL: https://github.com/apache/doris/pull/22924#issuecomment-1676708215 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Gabriel39 commented on pull request #22924: [bug](shuffle) set local exchange for serializer

2023-08-13 Thread via GitHub
Gabriel39 commented on PR #22924: URL: https://github.com/apache/doris/pull/22924#issuecomment-1676701465 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #22823: [bug](if) fix if function not handle const nullable value

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22823: URL: https://github.com/apache/doris/pull/22823#issuecomment-1676696115 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #21773: [feature](insert)support `insert ignore into ...` statement

2023-08-13 Thread via GitHub
hello-stephen commented on PR #21773: URL: https://github.com/apache/doris/pull/21773#issuecomment-1676690351 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.25 seconds stream load tsv: 515 seconds loaded 74807831229 Bytes

[GitHub] [doris] zhangstar333 commented on pull request #22823: [bug](if) fix if function not handle const nullable value

2023-08-13 Thread via GitHub
zhangstar333 commented on PR #22823: URL: https://github.com/apache/doris/pull/22823#issuecomment-1676690263 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #22855: [performance](executor) optimize time_round function only one arg

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22855: URL: https://github.com/apache/doris/pull/22855#issuecomment-1676681984 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zy-kkk commented on pull request #22930: [improve](jdbc catalog) Add more detailed exception logging to the jdbc catalog

2023-08-13 Thread via GitHub
zy-kkk commented on PR #22930: URL: https://github.com/apache/doris/pull/22930#issuecomment-1676665006 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] zy-kkk opened a new pull request, #22930: [improve](jdbc catalog) Add more detailed exception logging to the jdbc catalog

2023-08-13 Thread via GitHub
zy-kkk opened a new pull request, #22930: URL: https://github.com/apache/doris/pull/22930 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d

[GitHub] [doris] sohardforaname commented on pull request #22770: [Fix](planner)fix incorrect nullable in ctas.

2023-08-13 Thread via GitHub
sohardforaname commented on PR #22770: URL: https://github.com/apache/doris/pull/22770#issuecomment-1676663182 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] hello-stephen commented on pull request #22928: [refactor](load) change segcompaction worker interface

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22928: URL: https://github.com/apache/doris/pull/22928#issuecomment-1676659525 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.26 seconds stream load tsv: 517 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #22885: [optimize](Nereids): optimize Nereids performance

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22885: URL: https://github.com/apache/doris/pull/22885#issuecomment-1676651262 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #22885: [optimize](Nereids): optimize Nereids performance

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22885: URL: https://github.com/apache/doris/pull/22885#issuecomment-1676651243 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] hello-stephen commented on pull request #22929: [enhancement](Nereids): use enforcer to choose the n-th plan

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22929: URL: https://github.com/apache/doris/pull/22929#issuecomment-1676649653 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.01 seconds stream load tsv: 515 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22782: URL: https://github.com/apache/doris/pull/22782#issuecomment-1676648021 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee commented on a diff in pull request #22855: [performance](executor) optimize time_round function only one arg

2023-08-13 Thread via GitHub
HappenLee commented on code in PR #22855: URL: https://github.com/apache/doris/pull/22855#discussion_r1292955761 ## be/src/vec/functions/function_datetime_floor_ceil.cpp: ## @@ -474,6 +485,83 @@ struct TimeRound { is_null = !ts1.template date_add_interval(interval);

[GitHub] [doris] hello-stephen commented on pull request #22927: [Improve](complex-type) update for array/map element_at with nested complex type with local tvf

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22927: URL: https://github.com/apache/doris/pull/22927#issuecomment-1676639773 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.2 seconds stream load tsv: 514 seconds loaded 74807831229 Bytes,

[GitHub] [doris] LiBinfeng-01 commented on pull request #22840: [Fix](Planner) fix multi phase analysis failed in multi instance environment

2023-08-13 Thread via GitHub
LiBinfeng-01 commented on PR #22840: URL: https://github.com/apache/doris/pull/22840#issuecomment-1676637878 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] bobhan1 commented on pull request #21773: [feature](insert)support `insert ignore into ...` statement

2023-08-13 Thread via GitHub
bobhan1 commented on PR #21773: URL: https://github.com/apache/doris/pull/21773#issuecomment-1676634837 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22782: URL: https://github.com/apache/doris/pull/22782#issuecomment-1676632795 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22782: URL: https://github.com/apache/doris/pull/22782#issuecomment-1676630578 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #22798: [Feature](CCR) Support MoW for CCR

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22798: URL: https://github.com/apache/doris/pull/22798#issuecomment-1676630223 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21773: [feature](insert)support `insert ignore into ...` statement

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #21773: URL: https://github.com/apache/doris/pull/21773#issuecomment-1676628110 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] XieJiann commented on pull request #22929: [enhancement](Nereids): use enforcer to choose the n-th plan

2023-08-13 Thread via GitHub
XieJiann commented on PR #22929: URL: https://github.com/apache/doris/pull/22929#issuecomment-1676627299 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] XieJiann opened a new pull request, #22929: [enhancement](Nereids): use enforcer to choose the n-th plan

2023-08-13 Thread via GitHub
XieJiann opened a new pull request, #22929: URL: https://github.com/apache/doris/pull/22929 ## Proposed changes use enforcer to choose the n-th plan ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

[GitHub] [doris] zhannngchen commented on a diff in pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
zhannngchen commented on code in PR #22782: URL: https://github.com/apache/doris/pull/22782#discussion_r1292942633 ## be/src/olap/rowset/segment_v2/segment_writer.cpp: ## @@ -421,6 +431,7 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*

[GitHub] [doris] github-actions[bot] commented on pull request #22928: [refactor](load) change segcompaction worker interface

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22928: URL: https://github.com/apache/doris/pull/22928#issuecomment-1676624145 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] zhannngchen commented on a diff in pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
zhannngchen commented on code in PR #22782: URL: https://github.com/apache/doris/pull/22782#discussion_r1292940250 ## be/src/olap/rowset/segment_v2/segment_writer.cpp: ## @@ -431,23 +442,25 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*

[GitHub] [doris] eldenmoon commented on a diff in pull request #22917: [fix](json) fix json int128 overflow

2023-08-13 Thread via GitHub
eldenmoon commented on code in PR #22917: URL: https://github.com/apache/doris/pull/22917#discussion_r1292939904 ## be/src/util/jsonb_stream.h: ## @@ -126,9 +130,40 @@ class JsonbOutStream : public std::ostream { size_ += len; } -void write(__int128 l) { -

[GitHub] [doris] hello-stephen commented on pull request #22923: [Improvement] Optimize count operation for iceberg

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22923: URL: https://github.com/apache/doris/pull/22923#issuecomment-1676622178 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.16 seconds stream load tsv: 513 seconds loaded 74807831229 Bytes

[GitHub] [doris] zhannngchen commented on a diff in pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
zhannngchen commented on code in PR #22782: URL: https://github.com/apache/doris/pull/22782#discussion_r1292939180 ## be/src/olap/rowset/segment_v2/segment_writer.cpp: ## @@ -388,10 +391,17 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*

[GitHub] [doris] eldenmoon commented on a diff in pull request #22917: [fix](json) fix json int128 overflow

2023-08-13 Thread via GitHub
eldenmoon commented on code in PR #22917: URL: https://github.com/apache/doris/pull/22917#discussion_r1292937874 ## be/src/util/jsonb_stream.h: ## @@ -126,9 +130,40 @@ class JsonbOutStream : public std::ostream { size_ += len; } -void write(__int128 l) { -

[GitHub] [doris] github-actions[bot] commented on pull request #21773: [feature](insert)support `insert ignore into ...` statement

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #21773: URL: https://github.com/apache/doris/pull/21773#issuecomment-1676621339 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zhannngchen commented on a diff in pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
zhannngchen commented on code in PR #22782: URL: https://github.com/apache/doris/pull/22782#discussion_r1292938973 ## be/src/olap/rowset/segment_v2/segment_writer.cpp: ## @@ -495,9 +508,9 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*

[GitHub] [doris] amorynan commented on pull request #22927: [Improve](complex-type) update for array/map element_at with nested complex type with local tvf

2023-08-13 Thread via GitHub
amorynan commented on PR #22927: URL: https://github.com/apache/doris/pull/22927#issuecomment-1676620969 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #22928: [refactor](load) change segcompaction worker interface

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22928: URL: https://github.com/apache/doris/pull/22928#issuecomment-1676619618 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #22927: [Improve](complex-type) update for array/map element_at with nested complex type with local tvf

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22927: URL: https://github.com/apache/doris/pull/22927#issuecomment-1676617369 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #22798: [Feature](CCR) Support MoW for CCR

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22798: URL: https://github.com/apache/doris/pull/22798#issuecomment-1676616881 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] kaijchen commented on pull request #22928: [refactor](load) change segcompaction worker interface

2023-08-13 Thread via GitHub
kaijchen commented on PR #22928: URL: https://github.com/apache/doris/pull/22928#issuecomment-1676616132 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] kaijchen opened a new pull request, #22928: [refactor](load) change segcompaction worker interface

2023-08-13 Thread via GitHub
kaijchen opened a new pull request, #22928: URL: https://github.com/apache/doris/pull/22928 ## Proposed changes Segment ID should be `uint32_t`. Use initialization instead of assignment in the constructor. ## Further comments If this is a relatively large or complex ch

[GitHub] [doris] amorynan opened a new pull request, #22927: [Improve](complex-type) update for array/map element_at with nested complex type with local tvf

2023-08-13 Thread via GitHub
amorynan opened a new pull request, #22927: URL: https://github.com/apache/doris/pull/22927 ## Proposed changes Issue Number: close #xxx improve array/map element_at with nested complex type with local tvf ## Further comments If this is a relatively large or comple

[GitHub] [doris] zy-kkk opened a new pull request, #22926: [typo](docs) Optimize the upgrade documentation

2023-08-13 Thread via GitHub
zy-kkk opened a new pull request, #22926: URL: https://github.com/apache/doris/pull/22926 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d

[GitHub] [doris] hello-stephen commented on pull request #22557: [bugfix](schema_change) Fix the coredump when doubly write during schema change

2023-08-13 Thread via GitHub
hello-stephen commented on PR #22557: URL: https://github.com/apache/doris/pull/22557#issuecomment-1676613235 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.92 seconds stream load tsv: 511 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #22925: [feature](load) move memtable to sink node

2023-08-13 Thread via GitHub
github-actions[bot] commented on code in PR #22925: URL: https://github.com/apache/doris/pull/22925#discussion_r1292933252 ## be/test/runtime/load_stream_test.cpp: ## @@ -0,0 +1,1131 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

[GitHub] [doris] zhaojintaozhao commented on issue #22912: [Feature] Can Doris support ETL in big data warehouse and replace spark?

2023-08-13 Thread via GitHub
zhaojintaozhao commented on issue #22912: URL: https://github.com/apache/doris/issues/22912#issuecomment-1676606174 > Yes,In Progress When Apache Doris can support ETL to replace Spark in BigData WareHouse? Which version? -- This is an automated message from the Apache Git Serv

[GitHub] [doris] kaijchen opened a new pull request, #22925: [feature](load) move memtable to sink node

2023-08-13 Thread via GitHub
kaijchen opened a new pull request, #22925: URL: https://github.com/apache/doris/pull/22925 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

[GitHub] [doris] wanghuan2054 commented on pull request #22294: [typo](docs) fix docs,characters error

2023-08-13 Thread via GitHub
wanghuan2054 commented on PR #22294: URL: https://github.com/apache/doris/pull/22294#issuecomment-1676604747 > run buildall Can you help solve this problem ? ”Run failed: Code Quality Analysis“ -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [doris] AshinGau commented on a diff in pull request #22919: [enhancement](file-cache) limit the file cache handle num and init the file cache concurrently

2023-08-13 Thread via GitHub
AshinGau commented on code in PR #22919: URL: https://github.com/apache/doris/pull/22919#discussion_r1292927338 ## be/src/io/cache/block/block_file_cache.cpp: ## @@ -205,5 +207,21 @@ size_t IFileCache::file_reader_cache_size() { return s_file_name_to_reader.size(); } +vo

[GitHub] [doris] github-actions[bot] commented on pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22782: URL: https://github.com/apache/doris/pull/22782#issuecomment-1676593914 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [Improvement](aggregation) make fixed hashmap's bitmap_size flexable (#22573)

2023-08-13 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d371101bfd [Improvement](aggregation) make fi

[GitHub] [doris] BiteTheDDDDt merged pull request #22573: [Improvement](aggregation) make fixed hashmap's bitmap_size flexable

2023-08-13 Thread via GitHub
BiteThet merged PR #22573: URL: https://github.com/apache/doris/pull/22573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

[GitHub] [doris] Yukang-Lian commented on pull request #22782: [Fix](Partial update) Fix wrong position using in segment writer

2023-08-13 Thread via GitHub
Yukang-Lian commented on PR #22782: URL: https://github.com/apache/doris/pull/22782#issuecomment-1676592095 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] AshinGau commented on a diff in pull request #22923: [Improvement] Optimize count operation for iceberg

2023-08-13 Thread via GitHub
AshinGau commented on code in PR #22923: URL: https://github.com/apache/doris/pull/22923#discussion_r1292922797 ## be/src/vec/exec/format/table/iceberg_reader.cpp: ## @@ -132,10 +134,29 @@ Status IcebergTableReader::init_reader( _all_required_col_names, _not_in_file

[GitHub] [doris] github-actions[bot] commented on pull request #22924: [bug](shuffle) set local exchange for serializer

2023-08-13 Thread via GitHub
github-actions[bot] commented on PR #22924: URL: https://github.com/apache/doris/pull/22924#issuecomment-1676588761 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] AshinGau commented on issue #21960: [Bug] Hive catalog query result not right

2023-08-13 Thread via GitHub
AshinGau commented on issue #21960: URL: https://github.com/apache/doris/issues/21960#issuecomment-1676586127 We can `set enable_profile=true`(https://doris.apache.org/docs/1.2/admin-manual/query-profile/#specific-operation) in query session, and get the detail running profile in FE website

[doris] branch master updated: [refactor](load) split rowset builder out of delta writer (#22805)

2023-08-13 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 29fbe749cd [refactor](load) split rowset bui

[GitHub] [doris] dataroaring merged pull request #22805: [refactor](load) split rowset builder out of delta writer

2023-08-13 Thread via GitHub
dataroaring merged PR #22805: URL: https://github.com/apache/doris/pull/22805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

  1   2   >