eldenmoon commented on code in PR #22917:
URL: https://github.com/apache/doris/pull/22917#discussion_r1292937874
##########
be/src/util/jsonb_stream.h:
##########
@@ -126,9 +130,40 @@ class JsonbOutStream : public std::ostream {
size_ += len;
}
- void write(__int128 l) {
- // TODO
- assert(false);
+ // TODO: use more efficient impl for int128
+ void write(int128_t l) {
Review Comment:
maybe we could use
```
fmt::memory_buffer buffer;
fmt::format_to(buffer, "{}", l);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
