zhannngchen commented on code in PR #22782:
URL: https://github.com/apache/doris/pull/22782#discussion_r1292940250
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -431,23 +442,25 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
// if the delete sign is marked, it means that the value columns of
the row
// will not be read. So we don't need to read the missing values from
the previous rows.
// But we still need to mark the previous row on delete bitmap
- if (delete_sign_column_data != nullptr && delete_sign_column_data[pos
- row_pos] != 0) {
+ if (delete_sign_column_data != nullptr &&
delete_sign_column_data[delta_pos] != 0) {
has_default_or_nullable = true;
use_default_or_null_flag.emplace_back(true);
} else {
// partial update should not contain invisible columns
use_default_or_null_flag.emplace_back(false);
_rsid_to_rowset.emplace(rowset->rowset_id(), rowset);
- _tablet->prepare_to_read(loc, pos, &_rssid_to_rid);
+ _tablet->prepare_to_read(loc, block_pos, &_rssid_to_rid);
Review Comment:
should be `segment_pos`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
