TangSiyang2001 commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1293017777
##########
be/src/olap/delete_handler.cpp:
##########
@@ -81,35 +82,36 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
LOG(INFO) << "store one sub-delete condition. condition name=" <<
in_pred->column_name()
<< "condition size=" << in_pred->values().size();
} else {
- string condition_str = construct_sub_predicates(condition);
- del_pred->add_sub_predicates(condition_str);
- LOG(INFO) << "store one sub-delete condition. condition=" <<
condition_str;
+ DeleteSubPredicatePB* sub_predicate =
del_pred->add_sub_predicates_v2();
Review Comment:
诶但是现在不开lsc没问题，开完以后可能会core
##########
be/src/olap/delete_handler.cpp:
##########
@@ -81,35 +82,36 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
LOG(INFO) << "store one sub-delete condition. condition name=" <<
in_pred->column_name()
<< "condition size=" << in_pred->values().size();
} else {
- string condition_str = construct_sub_predicates(condition);
- del_pred->add_sub_predicates(condition_str);
- LOG(INFO) << "store one sub-delete condition. condition=" <<
condition_str;
+ DeleteSubPredicatePB* sub_predicate =
del_pred->add_sub_predicates_v2();
Review Comment:
诶但是现在不开lsc没问题，开完以后可能会core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
