yiguolei commented on code in PR #22442: URL: https://github.com/apache/doris/pull/22442#discussion_r1293028024
########## be/src/olap/delete_handler.cpp: ########## @@ -203,7 +205,20 @@ Status DeleteHandler::check_condition_valid(const TabletSchema& schema, const TC return Status::OK(); } -bool DeleteHandler::_parse_condition(const std::string& condition_str, TCondition* condition) { +Status DeleteHandler::_parse_condition(const DeleteSubPredicatePB& sub_cond, Review Comment: 1. compaction ---> read delete predicates --> v1 2. read query ---> read delete predicates ---> v2 3. read old delete predicates ---> convert v1 to v2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org