zhannngchen commented on code in PR #22782:
URL: https://github.com/apache/doris/pull/22782#discussion_r1292938973
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -495,9 +508,9 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
"index builder num rows: {}",
_num_rows_written, row_pos,
_primary_key_index_builder->num_rows());
}
- for (size_t pos = row_pos; pos < row_pos + num_rows; pos++) {
- std::string key = _full_encode_keys(key_columns, pos);
- _encode_seq_column(seq_column, pos, &key);
+ for (size_t block_pos = row_pos; block_pos < row_pos + num_rows;
block_pos++) {
+ std::string key = _full_encode_keys(key_columns, block_pos);
Review Comment:
should be `block_pos - row_pos`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
