[GitHub] [incubator-doris] morningman commented on a change in pull request #3753: [FIX] fix binaryPredicte's equals function ignore op

2020-06-02 Thread GitBox
morningman commented on a change in pull request #3753: URL: https://github.com/apache/incubator-doris/pull/3753#discussion_r434328016 ## File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java ## @@ -225,7 +226,7 @@ public boolean equals(Object obj) {

[GitHub] [incubator-doris] wuyunfeng commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-06-02 Thread GitBox
wuyunfeng commented on issue #3306: URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-637973779 https://github.com/apache/incubator-doris/issues/3759 This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] morningman commented on a change in pull request #3755: [Plugin] Add timeout of connection when downloading the plugins from URL

2020-06-02 Thread GitBox
morningman commented on a change in pull request #3755: URL: https://github.com/apache/incubator-doris/pull/3755#discussion_r434325324 ## File path: fe/src/main/java/org/apache/doris/plugin/PluginZip.java ## @@ -113,13 +113,13 @@ Path downloadRemoteZip(Path targetPath) throws

[GitHub] [incubator-doris] wuyunfeng opened a new issue #3759: [Doris On ES] Add Debug mode for ES table

2020-06-02 Thread GitBox
wuyunfeng opened a new issue #3759: URL: https://github.com/apache/incubator-doris/issues/3759 **Is your feature request related to a problem? Please describe.** Currently, user can not see the `query DSL` from the `explain` API directly, users are annoyed in most cases. **De

[GitHub] [incubator-doris] spaces-X commented on pull request #3741: Ignore broken disks when BE starts up

2020-06-02 Thread GitBox
spaces-X commented on pull request #3741: URL: https://github.com/apache/incubator-doris/pull/3741#issuecomment-637970984 > > Could I merge this pr to master? > > Or what should I do next? > > Hi, you don't need to do anything. This pr will be merged after being approved for a per

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3758: Add more detailed error message when fail to create es table

2020-06-02 Thread GitBox
wuyunfeng opened a new pull request #3758: URL: https://github.com/apache/incubator-doris/pull/3758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] wuyunfeng opened a new issue #3757: [Doris On ES] Provide more detailed error message when failure to create ES table

2020-06-02 Thread GitBox
wuyunfeng opened a new issue #3757: URL: https://github.com/apache/incubator-doris/issues/3757 **Is your feature request related to a problem? Please describe.** When create external Elasticsearch table failure, the detailed error message just too simple, Community users should check th

[GitHub] [incubator-doris] kangkaisen commented on pull request #3703: [Load] Add more metric to trace the time cost in stream load and make brpc_num_threads configurable

2020-06-02 Thread GitBox
kangkaisen commented on pull request #3703: URL: https://github.com/apache/incubator-doris/pull/3703#issuecomment-637954337 > > @caiconghui Hi, If you only change the webserver_num_workers from 5 to 48, how many times stream load performance will improve? > > @kangkaisen > > if every

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3753: [FIX] fix binaryPredicte's equals function ignore op

2020-06-02 Thread GitBox
kangkaisen commented on a change in pull request #3753: URL: https://github.com/apache/incubator-doris/pull/3753#discussion_r434307639 ## File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java ## @@ -225,7 +226,7 @@ public boolean equals(Object obj) {

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3755: [Plugin] Add timeout of connection when downloading the plugins from URL

2020-06-02 Thread GitBox
kangkaisen commented on a change in pull request #3755: URL: https://github.com/apache/incubator-doris/pull/3755#discussion_r434305139 ## File path: fe/src/main/java/org/apache/doris/plugin/PluginZip.java ## @@ -113,13 +113,13 @@ Path downloadRemoteZip(Path targetPath) throws

[GitHub] [incubator-doris] HangyuanLiu commented on issue #3748: [Bug] BITMAP internal _type error when the bitmap is being union or add

2020-06-02 Thread GitBox
HangyuanLiu commented on issue #3748: URL: https://github.com/apache/incubator-doris/issues/3748#issuecomment-637947539 > hi @HangyuanLiu , next time, you can link the issue to the PR by add `Fix #3748` in your PR's comment. So that the issue will be automatically closed after PR being me

[GitHub] [incubator-doris] yangzhg opened a new issue #3756: BinaryPredict's equals function compares ignore the op

2020-06-02 Thread GitBox
yangzhg opened a new issue #3756: URL: https://github.com/apache/incubator-doris/issues/3756 **Describe the bug** BinaryPredict's equals function compares ignore the op, the opcode is not init in this class, it will always be INVALID_OPCODE, so if a BinaryPredict has same child it wil

[GitHub] [incubator-doris] morningman opened a new pull request #3755: [Plugin] Add timeout of connection when downloading the plugins from URL

2020-06-02 Thread GitBox
morningman opened a new pull request #3755: URL: https://github.com/apache/incubator-doris/pull/3755 Fix #3754 If no timeout is set, the download process may be blocked forever. This is an automated message from the Ap

[GitHub] [incubator-doris] morningman opened a new issue #3754: [Plugin] install plugin block when downloading from URL

2020-06-02 Thread GitBox
morningman opened a new issue #3754: URL: https://github.com/apache/incubator-doris/issues/3754 **Describe the bug** Install plugin process blocks when downloading from URL. **To Reproduce** install a plugin from an invalid URL which has some network problem. **Expected b

[GitHub] [incubator-doris] morningman closed issue #3748: [Bug] BITMAP internal _type error when the bitmap is being union or add

2020-06-02 Thread GitBox
morningman closed issue #3748: URL: https://github.com/apache/incubator-doris/issues/3748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman commented on issue #3748: [Bug] BITMAP internal _type error when the bitmap is being union or add

2020-06-02 Thread GitBox
morningman commented on issue #3748: URL: https://github.com/apache/incubator-doris/issues/3748#issuecomment-637941738 hi @HangyuanLiu , next time, you can link the issue to the PR by add `Fix #3748` in your PR's comment. So that the issue will be automatically closed after PR being merge

[GitHub] [incubator-doris] yangzhg opened a new pull request #3753: [FIX] fix binaryPredicte's equals function ignore op

2020-06-02 Thread GitBox
yangzhg opened a new pull request #3753: URL: https://github.com/apache/incubator-doris/pull/3753 BinaryPredicte's equals funtion compare by opccode , but the opcode is never inited, so it will return true if this child is same, for example `a>1` and `a<1` are equal --

[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
WingsGo commented on pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637937165 > > The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to

[GitHub] [incubator-doris] morningman commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
morningman commented on pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637932239 > The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it t

[GitHub] [incubator-doris] morningman edited a comment on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
morningman edited a comment on pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637932239 > The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can lea

[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
WingsGo commented on pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637931102 The status mainly reflect BE's status, if some error happends, it should be FE's problem?Our mainly purpose is to monitoring BE's status, so maybe we can leave it to mak

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
WingsGo commented on a change in pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433871498 ## File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java ## @@ -247,6 +249,13 @@ private static void tabletReport(long backendId,

[GitHub] [incubator-doris] blackfox1983 commented on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
blackfox1983 commented on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637929516 lgtm This is an automated message from the Apache Git Service. To respond to the message, please lo

[incubator-doris] branch master updated (3194aa1 -> ad7270b)

2020-06-02 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 3194aa1 Add a link to Tablet Meta URL (#3745) add ad7270b [Spark load][Fe 1/5] Add spark etl job confi

[GitHub] [incubator-doris] imay merged pull request #3712: [Spark load][Fe 1/5] Add spark etl job config

2020-06-02 Thread GitBox
imay merged pull request #3712: URL: https://github.com/apache/incubator-doris/pull/3712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] morningman commented on pull request #3741: Ignore broken disks when BE starts up

2020-06-02 Thread GitBox
morningman commented on pull request #3741: URL: https://github.com/apache/incubator-doris/pull/3741#issuecomment-637919801 > Could I merge this pr to master? > Or what should I do next? Hi, you don't need to do anything. This pr will be merged after being approved for a period of

[GitHub] [incubator-doris] spaces-X commented on pull request #3741: Ignore broken disks when BE starts up

2020-06-02 Thread GitBox
spaces-X commented on pull request #3741: URL: https://github.com/apache/incubator-doris/pull/3741#issuecomment-637918458 Could I merge this pr to master? Or what should I do next? This is an automated message from the Apa

[GitHub] [incubator-doris] wuyunfeng removed a comment on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng removed a comment on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543519 https://github.com/apache/incubator-doris/pull/3513 (https://github.com/apache/incubator-doris/issues/3479) try to resolved the `inner hits node is not an arra

[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng edited a comment on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543519 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng edited a comment on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543519 This PR try to resolved the `inner hits node is not an array` because when a query( batch-size) run against new segment without this field, as-well the filter_

[GitHub] [incubator-doris] wuyunfeng removed a comment on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng removed a comment on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543910 https://github.com/apache/incubator-doris/pull/3513 This is an automated message from the Apac

[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng edited a comment on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543519 This PR https://github.com/apache/incubator-doris/pull/3513 https://github.com/apache/incubator-doris/issues/3479 ---

[GitHub] [incubator-doris] kangkaisen merged pull request #3745: Add a link to Tablet Meta URL

2020-06-02 Thread GitBox
kangkaisen merged pull request #3745: URL: https://github.com/apache/incubator-doris/pull/3745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated: Add a link to Tablet Meta URL (#3745)

2020-06-02 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3194aa1 Add a link to Tablet Meta

[incubator-doris] branch master updated: Fix bitmap type (#3749)

2020-06-02 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 60f93b2 Fix bitmap type (#3749) 60

[GitHub] [incubator-doris] kangkaisen merged pull request #3749: Fix bitmap internal _type misuse

2020-06-02 Thread GitBox
kangkaisen merged pull request #3749: URL: https://github.com/apache/incubator-doris/pull/3749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] wyb commented on a change in pull request #3717: [Spark load][Fe 5/5] Fe process etl and loading state job

2020-06-02 Thread GitBox
wyb commented on a change in pull request #3717: URL: https://github.com/apache/incubator-doris/pull/3717#discussion_r433986019 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java ## @@ -0,0 +1,700 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3750: [Bug] Fix a bug that tablet may be modified to BETA_ROWSET after cloned

2020-06-02 Thread GitBox
acelyc111 commented on a change in pull request #3750: URL: https://github.com/apache/incubator-doris/pull/3750#discussion_r433912838 ## File path: be/src/olap/tablet_schema.cpp ## @@ -337,14 +337,12 @@ void TabletColumn::to_schema_pb(ColumnPB* column) { } } -TabletSche

[GitHub] [incubator-doris] wangbo commented on pull request #3604: (#3464) fix Query failed when fact table has no data in join case

2020-06-02 Thread GitBox
wangbo commented on pull request #3604: URL: https://github.com/apache/incubator-doris/pull/3604#issuecomment-637556514 set partition join as default when partition join cost equals broadcast join This is an automated message

[GitHub] [incubator-doris] wuyunfeng commented on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng commented on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543519 https://github.com/apache/incubator-doris/issues/3479 This is an automated message from the Apache Git

[GitHub] [incubator-doris] wuyunfeng commented on pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue scan mode

2020-06-02 Thread GitBox
wuyunfeng commented on pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543910 https://github.com/apache/incubator-doris/pull/3513 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] wuyunfeng opened a new issue #3752: [Doris On ES] incorrect result when `enable_docvalue_scan`

2020-06-02 Thread GitBox
wuyunfeng opened a new issue #3752: URL: https://github.com/apache/incubator-doris/issues/3752 when use `enable_docvalue_scan`, such as : ``` CREATE EXTERNAL TABLE `doe` ( `id` bigint(20) NULL COMMENT "", `city` varchar(20) NULL COMMENT "", `opin_type` varchar(20) NU

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
WingsGo commented on a change in pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433871498 ## File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java ## @@ -247,6 +249,13 @@ private static void tabletReport(long backendId,

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3751: [Doirs On ES] bug-fix for incorrect result for docvalue context

2020-06-02 Thread GitBox
wuyunfeng opened a new pull request #3751: URL: https://github.com/apache/incubator-doris/pull/3751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
morningman commented on a change in pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433857519 ## File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java ## @@ -247,6 +249,13 @@ private static void tabletReport(long backend

[GitHub] [incubator-doris] marising commented on a change in pull request #3738: [Bug]fix the crash of checksum task #3735

2020-06-02 Thread GitBox
marising commented on a change in pull request #3738: URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r433856840 ## File path: be/src/olap/row.h ## @@ -59,6 +59,10 @@ bool equal_row(const std::vector& ids, template int compare_row(const LhsRowType& lhs, co

[GitHub] [incubator-doris] morningman commented on a change in pull request #3750: [Bug] Fix a bug that tablet may be modified to BETA_ROWSET after cloned

2020-06-02 Thread GitBox
morningman commented on a change in pull request #3750: URL: https://github.com/apache/incubator-doris/pull/3750#discussion_r433856036 ## File path: be/src/olap/tablet_schema.cpp ## @@ -337,14 +337,12 @@ void TabletColumn::to_schema_pb(ColumnPB* column) { } } -TabletSch

[GitHub] [incubator-doris] WingsGo commented on pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-02 Thread GitBox
WingsGo commented on pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713#issuecomment-637454903 > Please update the doc `SHOW BACKENDS.md`, both in English and Chinese. Done This is an automate

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3741: Ignore broken disks when BE starts up

2020-06-02 Thread GitBox
kangkaisen commented on a change in pull request #3741: URL: https://github.com/apache/incubator-doris/pull/3741#discussion_r433782750 ## File path: be/src/service/doris_main.cpp ## @@ -136,6 +136,25 @@ int main(int argc, char** argv) { LOG(FATAL) << "parse config stor

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3750: [Bug] Fix a bug that tablet may be modified to BETA_ROWSET after cloned

2020-06-02 Thread GitBox
acelyc111 opened a new pull request #3750: URL: https://github.com/apache/incubator-doris/pull/3750 TabletMeta's _preferred_rowset_type is not initialized after object constructing and may be a random value, and this field is not updated when create ALPHA_ROWSET tablet, and it will n

[GitHub] [incubator-doris] spaces-X commented on a change in pull request #3741: Ignore broken disks when BE starts up

2020-06-02 Thread GitBox
spaces-X commented on a change in pull request #3741: URL: https://github.com/apache/incubator-doris/pull/3741#discussion_r433355972 ## File path: be/src/service/doris_main.cpp ## @@ -136,6 +136,25 @@ int main(int argc, char** argv) { LOG(FATAL) << "parse config storag

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #3749: Fix bitmap internal _type misuse

2020-06-02 Thread GitBox
HangyuanLiu opened a new pull request #3749: URL: https://github.com/apache/incubator-doris/pull/3749 For #3748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] HangyuanLiu opened a new issue #3748: [Bug] BITMAP internal _type error when the bitmap is being union or add

2020-06-02 Thread GitBox
HangyuanLiu opened a new issue #3748: URL: https://github.com/apache/incubator-doris/issues/3748 bitmap internal _type error when the bitmap is being union or add. When multiple bitmap are union, the type of the bitmap should not be modified if the result is still single. -

[GitHub] [incubator-doris] hxianshun opened a new issue #3747: [Proposal]Rollup Usage Metrics

2020-06-02 Thread GitBox
hxianshun opened a new issue #3747: URL: https://github.com/apache/incubator-doris/issues/3747 I expect to know the usage of every rollup in every table. Such as I‘d like to know how many querys in one table every day, and how many querys hit the rollup and how many querys not hit the roll

[GitHub] [incubator-doris] decster commented on a change in pull request #3734: [Memory Engine] Add MemTabletScan

2020-06-02 Thread GitBox
decster commented on a change in pull request #3734: URL: https://github.com/apache/incubator-doris/pull/3734#discussion_r433674671 ## File path: be/src/olap/memory/mem_tablet.h ## @@ -79,6 +81,8 @@ class MemTablet : public BaseTablet { std::mutex _write_lock; +std