spaces-X commented on a change in pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741#discussion_r433355972
##########
File path: be/src/service/doris_main.cpp
##########
@@ -136,6 +136,25 @@ int main(int argc, char** argv) {
LOG(FATAL) << "parse config storage path failed, path=" <<
doris::config::storage_root_path;
exit(-1);
}
+ auto it = paths.begin();
Review comment:
Yeah, but i think it just checked whether the data path is existed. It
didn't attempt to read or write test files in data path.
The current version didn't cover the following situation:
- Data path is existed but the disk is broken.
- We can use command 'cd path' into the data path directory, but we can not
create or write files for lots of reasons, for instance, no write permission.
So i try to add the read_write_check step before BE starts up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
