marising commented on a change in pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r433856840
##########
File path: be/src/olap/row.h
##########
@@ -59,6 +59,10 @@ bool equal_row(const std::vector<uint32_t>& ids,
template<typename LhsRowType, typename RhsRowType>
int compare_row(const LhsRowType& lhs, const RhsRowType& rhs) {
for (uint32_t cid = 0; cid < lhs.schema()->num_key_columns(); ++cid) {
+ //because the num_column_ids include the column of double/float type
Review comment:
1. remove the code of ignore the column of float/double type's in
engine_checksum.cpp
2. ignore the cell of float/double type when compute row's hash code
3. the value of checksum is independent of the sorting of data rows
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
