morningman commented on a change in pull request #3753:
URL: https://github.com/apache/incubator-doris/pull/3753#discussion_r434328016
##########
File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##########
@@ -225,7 +226,7 @@ public boolean equals(Object obj) {
if (!super.equals(obj)) {
return false;
}
- return ((BinaryPredicate) obj).opcode == this.opcode;
+ return ((BinaryPredicate) obj).opcode == this.opcode &&
op.equals(((BinaryPredicate) obj).getOp());
Review comment:
It only for safe, don't know what the `opcode` for.
If it is useless, we can remove it in next PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
