morningman commented on a change in pull request #3750:
URL: https://github.com/apache/incubator-doris/pull/3750#discussion_r433856036
##########
File path: be/src/olap/tablet_schema.cpp
##########
@@ -337,14 +337,12 @@ void TabletColumn::to_schema_pb(ColumnPB* column) {
}
}
-TabletSchema::TabletSchema()
- : _num_columns(0),
- _num_key_columns(0),
- _num_null_columns(0),
- _num_short_key_columns(0) { }
-
void TabletSchema::init_from_pb(const TabletSchemaPB& schema) {
_keys_type = schema.keys_type();
+ _num_columns = 0;
+ _num_key_columns = 0;
+ _num_null_columns = 0;
Review comment:
I am not sure, but did you miss the `_num_short_key_columns` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
