wuyunfeng edited a comment on pull request #3751:
URL: https://github.com/apache/incubator-doris/pull/3751#issuecomment-637543519


   This PR try to resolved the `inner hits node is not an array` because when a 
 query( batch-size) run against new segment without this field, as-well the 
filter_path just only take `hits.hits.fields` 、`hits.hits._source` into 
account, this would appear an null inner hits node:
   ```
   {
      "_scroll_id": "DXF1ZXJ5QW5kRmV0Y2gBAAAAAAAAHaUWY1ExUVd0ZWlRY2",
      "hits": {
         "total": 1
      }
   }
   ```
   https://github.com/apache/incubator-doris/pull/3513
   https://github.com/apache/incubator-doris/issues/3479
   
   Unfortunately this PR introduce another serious inconsistent result with 
different batch_size because of misusing the `total`.
   
   To avoid this two problem,  we just add `hits.hits._score` to filter_path 
when `docvalue_mode` is true,   `_score`  would always `null` ,  and populate 
the inner hits node:
   
   ```
   {
      "_scroll_id": "DXF1ZXJ5QW5kRmV0Y2gBAAAAAAAAHaUWY1ExUVd0ZWlRY2",
      "hits": {
         "total": 1,
         "hits": [
            {
               "_score": null
            }
         ]
      }
   }
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to