[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

benshi001 created this revision. benshi001 added reviewers: haowei, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I think I have fixed in another patch https://reviews.llvm.org/D127814, could you please have a look? @haowei I have not your environment, my patch works on my ubuntu system, could you please try it on your build machine ? Repository: rG LLVM Github Monorepo CHA

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 436992. benshi001 added a reviewer: haowei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Dr

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583795 , @haowei wrote: > I already reverted the change in > https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad > . It is likely the breakage is caused by the fact that Fuchsia's C

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

benshi001 added a comment. In D127814#3583854 , @haowei wrote: > I tested this patch on top of > https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 > (reverted in > https://github.com/llvm/llvm-project/commit/7fae15f92

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583886 , @haowei wrote: > Emmm, I applied your latest patch on top of > main(6e02e27536b9de25a651cfc9c2966ce471169355 > ) but I > still get a te

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. It seems the file `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` is missing on your machine, which I have newly created in current patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583924 , @haowei wrote: > In D126192#3583915 , @benshi001 > wrote: > >> It seems the file >> `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: StephenFan, Jim, dberris, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:83 +// RUN: %clang %s -### --target=avr -mmcu=atmega328 --sysroot=%S/Inputs/basic_avr_tree/ -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir -fuse-ld=%S/Inputs/basic_avr_tree/usr/bin/ld.l

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438181. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438195. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChain

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438238. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. A gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:441 +if (!llvm::sys::fs::can_execute(FullPath)) + D.Diag(diag::err_drv_invalid_linker_name) << Linker; +else We report an error if the linker specified via `-fuse-ld` is

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:395 + +unsigned GetMCUEEPROMSize(StringRef MCUName) { + for (const auto &MCU : MCUInfo) Add three helper functions for the newly added fields. CHANGES SINCE LAST ACTION https://

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432457. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:435 - std::string Linker = getToolChain().GetProgramPath(getShortName()); + // Compute the linker program path, and use GNU "avr-ld" as default. + con

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/lib/ldscripts/avr5.xn clang/test/Driver/avr-tool

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. benshi001 wrote: > This check is no longer needed,

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432460. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/a

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:528 + CmdArgs.push_back(Args.MakeArgString("-T")); + CmdArgs.push_back(Args.MakeArgString(Prefix + *FamilyName + ".x")); +} Though I can seperate my AVR pro

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432468. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/a

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 433299. benshi001 retitled this revision from "[Driver] Support linking with lld for target AVR" to "[Driver] Improve linking options for target AVR". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 433300. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/t

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3549238 , @MaskRay wrote: > I am still uncomfortable with such a change. Trying to be smart sometimes may > get in the way. I have removed the guess of default linker script. Currently my patch only does 1. Support

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I have a bit confused, why `clang --target=x86_64 -fuse-ld=lld` needs not to be explicitly specified with a linker script and produces a runnable x86_64 ELF? How does lld arrange code/data addresses for x86_64 by default ? My original will is `clang --target=avr -fuse

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. It seems that the expected path should be `$resource_dir/lib/avr5/libclang_rt.builtins.a`, other than `libclang_rt.builtins-avr5.a`. I will fix that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, benshi001 wrote: >

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. ping I have simplified my patch. Only support `-T` and `-fuse-ld=lld` according to user specification. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commit

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 434684. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/t

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:507 +// Add user specified linker script. +const Arg *LDS = Args.getLastArg(options::OPT_T); +if (LDS) { MaskRay wrote: > Just

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. Repository:

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 434706. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 434709. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 435036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:428 +} + void AVR::Linker::ConstructJob(Compilation &C, const JobAction &JA, 1. Though I expect each device family has its own optimized build of compiler-rt binary, I found most t

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545152. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545158. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen/CSKY/intrinsic.ll Index: llvm/test/C

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:67 + return __builtin_bswap64(x); +} zixuan-wu wrote: > Those are target-independent intrinsics/builtins. I think it's no more need

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:36 +define i16 @bswap16(i16 %x) { +; CHECK-LABEL: bswap16: +; CHECK: # %bb.0: # %entry zixuan-wu wrote: > Again. It's related to cttz? I have made another patch for these addit

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545952. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 closed this revision. benshi001 added a comment. Closed by https://reviews.llvm.org/rG80cd505914dfc2f38f57341f9bef9d208fdc238e https://github.com/llvm/llvm-project/commit/80cd505914dfc2f38f57341f9bef9d208fdc238e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

benshi001 created this revision. benshi001 added reviewers: jacquesguan, aykevl, Patryk27. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes bug https://g

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

benshi001 added a comment. A better fix is https://reviews.llvm.org/D157584 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157586/new/ https://reviews.llvm.org/D157586 ___ cfe-commits mailing list cfe-com

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 538356. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + This file is pure test, has nothing to do with `llvm.cttz`, just to avoid another patch. Repository: r

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added a comment. In D153197#4483230 , @Patryk27 wrote: > ping ping, @benshi001 👀 Could you please upload your final version of this patch ? I see you have made some changes, but only mentioned in your comment. Repository: rG LLVM Github Mo

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96cc2d07e15a: [clang] Add AVR specific inline assembly escaped characters (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d37efdbc599: [clang][driver] Enable '-flto' on AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D145646?vs=503607&i

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 added a comment. In D144533#4160297 , @MaskRay wrote: > This change is an improvement but why is `__DATA_REGION_ORIGIN__` defined? Because, 1. Different AVR devices have different SRAM address range (start & length), and `__DATA_REGION_ORIGIN

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c112897b202: [clang][driver] Do not emit default '-Tdata' for AVR devices (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144533?vs=499360&id=501386#toc Repository: rG LL

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, inglorion, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes http

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 updated this revision to Diff 503607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/avr-ld.c

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 created this revision. benshi001 added reviewers: jacquesguan, aykevl. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 updated this revision to Diff 504631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145659/new/ https://reviews.llvm.org/D145659 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/test/CodeGen/avr/avr-inline-asm-constraints.c Index: clang/test/Co

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:433 +AVRTargetInfo::handleAsmEscapedChar(char EscChar) const { + char C; + switch (EscChar) { jacquesguan wrote: > redundant variable? Remov

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Patryk27 wrote: > Alright, this is wrong, after all - I've just tested it on a more e

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Different AVR devices

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 added a comment. Different AVR device families have different default linker scripts in avr-ld, but they have 95% similarity and look like as following, we can use `--defsym=__DATA_REGION_ORIGIN__` to decide the default data region range instead of current `-Tdata`. /* Script for l

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 updated this revision to Diff 499757. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144620/new/ https://reviews.llvm.org/D144620 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-ld.c clang/test/Driver/avr-toolchain.c

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rG91610433907e: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144620?vs=

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:548 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) MaskRay wrote: > The comment just repea

[PATCH] D148908: [Driver][NFC] Simplify code.

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148908/new/ https://reviews.llvm.org/D148908 _

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: luismarques, s.egerton, Jim, PkmX, simoncook, kristof.beyls, arichardson. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, pcwan

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 added inline comments. Comment at: clang/test/Driver/avr-mmcu.c:48 -// RUN: %clang -### --target=avr -mmcu=atmega16a -save-temps %s 2>&1 | FileCheck -check-prefix=CHECKb %s -// CHECKb: "-cc1" {{.*}} "-target-cpu" "atmega16a" -// CHECKb: "-cc1as" {{.*}} "-target-cpu" "a

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

benshi001 updated this revision to Diff 480040. benshi001 retitled this revision from "[clang][driver] Support option '-mcpu' on target AVR" to "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'". Herald added a subscriber: jeroen.dobbelaere. CHANGES SINCE LAST ACTION https://r

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:387 return A->getValue(); +if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) + return A->getValue(); aricha

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480748. benshi001 retitled this revision from "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'" to "[clang][driver] Support option '-mcpu' on target AVR.". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https:/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139305/new/ https://reviews.llvm.org/D139305 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/avr-mmcu.c Index: clang/test/Driver/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#3974946 , @MaskRay wrote: > This makes `-mmcu=` available for non-AVR targets, which is not right. > Even for AVR, if this is a plain alias, is this really necessary? Usually > having more than one aliases for one fu

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 added a comment. This patch fixes https://github.com/llvm/llvm-project/issues/58877 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https://reviews.llvm.org/D139908 ___ cfe-commits

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:27 const char *DefineName; + const int MaxFlashBank; // -1 means the device does not support LPM/ELPM. }; aykevl wrote: > This works and

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/test/Sema/avr-flash.c:10 + static __flash5 const int a5[] = {4, 6}; // expected-error {{unknown type name '__flash5'}} + // TODO: It would be better to report "'__flash5' is not supp

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f488c6a5ce: [clang][AVR] Implement '__flashN' for variables on different flash banks (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D115982?vs=398846&id=401159#toc Reposit

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG0be3da1fab5a: [RISCV] Add intrinsic for Zbt extension (authored by Chenbing.Zheng, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 401982. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/lib/Dri

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. Thanks for your suggestion ! I have changed to check avr-1 in `Clang::ConstructJob`, which is much more clear than my previous solution ! Really appreicate. A bit pity is that I have to make big changes to the constructor `AVRToolChain::AVRToolChain`, otherwise the ex

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. The previous logic of the constructor `AVRToolChain::AVRToolChain` 1. if `-c` or `-nostdlib` is specified, no error will rise (even if no MCU is specified). 2. if no MCU is specified, two warnings will rise warning: no target microcontroller specified on command li

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 402338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/lib/Dri

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.h:22 class LLVM_LIBRARY_VISIBILITY AVRToolChain : public Generic_ELF { + std::string AVRMcu; + aykevl wrote: > I think I would have called t

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 402379. benshi001 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://re

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5149 + // Devices in the avr-1 family only support assembly programming. + if (TC.getArch() == llvm::Triple::avr) { +auto const &AVRTC = static_cas

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. There is an old solution in https://reviews.llvm.org/D117423. The concern over there is that AVR specific checks should be implemented in AVR toolchain specific files. And this patch obeys that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 403116. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 403135. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 403867. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:393 + if (FamilyName.hasValue() && + (FamilyName->equals("avr1") || FamilyName->equals("avrtiny"))) { +// Only '-x assembler-with-cpp' or '-x assembler' is allowed for avr1. ---

[PATCH] D118445: [clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://re

[PATCH] D118445: [clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace

benshi001 added a comment. clang crashes when compling some c++ for for AVR targets with `clang++ test.cc --target=avr -mmcu=atmega328 -S`, and the test.cc is volatile char *p = (volatile char *) 0x4000; class test { int v; public: test(int q): v(q) {} int get

<    1   2   3   4   >