benshi001 added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461
<< CPU;
- } else if (TC.getGCCInstallPath().empty()) {
- // We can not link since there is no avr-ld.
----------------
benshi001 wrote:
> This check is no longer needed, since we will check `if
> (!llvm::sys::fs::can_execute(FullPath))` at above lines.
This check is still unnecessary, since the driver will complaint `invalid
linker ...` if `avr-ld` is invalid.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126192/new/
https://reviews.llvm.org/D126192
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
