benshi001 added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, ---------------- benshi001 wrote: > This method decides the file name of compiler-rt, it is expected to be > > libclang_rt.builtins-avrfamily.a, such as > > libclang_rt.builtins-avr51.a > libclang_rt.builtins-avrtiny.a > libclang_rt.builtins-avrxmega3.a This override method is unnecessary, the basic `ToolChain::buildCompilerRTBasename` has covered all cases for AVR, since 1. `.lib` suffix can never be generated for avr 2. `libclang_rt.builtins-avr5.a` is unexpected, which should be ` $resource_dir/lib/avr5/libclang_rt.builtins.a`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
