benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:507
+    // Add user specified linker script.
+    const Arg *LDS = Args.getLastArg(options::OPT_T);
+    if (LDS) {
----------------
MaskRay wrote:
> Just do  Args.AddAllArgs. Please check how Gnu.cpp passes `-T`
Thanks. `Args.AddAllArgs` does make code more clear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126192/new/

https://reviews.llvm.org/D126192

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to