[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

phosek added inline comments. Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX) + set(CMAKE_INCLUDE_CURRENT_DIR ON) +

[clang] c6b4433 - [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

Author: Nikolas Klauser Date: 2023-07-10T11:09:38-07:00 New Revision: c6b4433a0f20c5ebbd72cee8fd0dcfdb429e619c URL: https://github.com/llvm/llvm-project/commit/c6b4433a0f20c5ebbd72cee8fd0dcfdb429e619c DIFF: https://github.com/llvm/llvm-project/commit/c6b4433a0f20c5ebbd72cee8fd0dcfdb429e619c.dif

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. philnik marked an inline comment as done. Closed by commit rGc6b4433a0f20: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays… (authored by

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

clementval added inline comments. Comment at: flang/test/Driver/pic-flags.f90:3 -! RUN: %flang -### %s --target=aarch64-linux-gnu 2>&1 | FileCheck %s --check-prefix=CHECK-NOPIE -! RUN: %flang -### %s --target=aarch64-linux-gnu -fno-pie 2>&1 | FileCheck %s --check-prefix=CHECK

[PATCH] D154628: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4813 case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_ta: + case RISCVVector::BI__builtin_rvv_vfsub_vv_rm_ta: + case RISCVVector::BI__builtin_rvv_vfsub_vf_rm_ta: This needs to rebas

[PATCH] D154628: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154628/new/ https://reviews.llvm.org/D154628 ___

[PATCH] D154871: [clang] Satisfy clang v12

ashay-github created this revision. ashay-github added reviewers: steakhal, xazax.hun, Szelethus. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 538748. eopXD added a comment. Fix bug, should be checking MI.readsRegister(RISCV::FRM) under AdjustInstrPostInstrSelection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D15

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 538749. pscoro added a comment. Comment out some code that irrelevant to current object library approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 Files: clang

[PATCH] D154871: [clang] Satisfy clang v12

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks reasonable. Unfortunate that it regresses readability by a pair of parents. Anyway LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 9c96cc9 - Clang 17 isn't not yet released; NFC

Author: Aaron Ballman Date: 2023-07-10T14:28:22-04:00 New Revision: 9c96cc96e3c2cafebdb314f19c50bdb9f63348a6 URL: https://github.com/llvm/llvm-project/commit/9c96cc96e3c2cafebdb314f19c50bdb9f63348a6 DIFF: https://github.com/llvm/llvm-project/commit/9c96cc96e3c2cafebdb314f19c50bdb9f63348a6.diff

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added a comment. I think this conflicts with https://reviews.llvm.org/D154245 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 ___ cfe-commits maili

[clang] fd857f7 - [NFC] Initialize pointer fields and remove needless null check.

Author: Sindhu Chittireddy Date: 2023-07-10T11:32:13-07:00 New Revision: fd857f786f61620c370d132fe9ba1b5608bb4f50 URL: https://github.com/llvm/llvm-project/commit/fd857f786f61620c370d132fe9ba1b5608bb4f50 DIFF: https://github.com/llvm/llvm-project/commit/fd857f786f61620c370d132fe9ba1b5608bb4f50.

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari updated this revision to Diff 538751. nuriamari added a comment. - Create entry in release notes - Move test to appropriate location - Expand test to include `const` warning controlled in the same warning group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added a comment. Thank you all for reviewing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:373 (`#13920: `_) +- A new diagnostic warning group ``deprecated-redundant-constexpr-static-def`` is + added. This is to be used to control warnings ab

[clang] 5942ae8 - [NFC] Initialize class member pointers to nullptr.

Author: Sindhu Chittireddy Date: 2023-07-10T11:38:55-07:00 New Revision: 5942ae8681db20822ac3e0b94cf8089d30647a39 URL: https://github.com/llvm/llvm-project/commit/5942ae8681db20822ac3e0b94cf8089d30647a39 DIFF: https://github.com/llvm/llvm-project/commit/5942ae8681db20822ac3e0b94cf8089d30647a39.

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir added a comment. Thank you for reviewing. This patch is now landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153926/new/ https://reviews.llvm.org/D153926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:912 +const TargetLibraryInfo &TLI = FAM.getResult(F); +readMemprof(M, F, MemProfReader.get(), TLI); + } tejohnson wrote: > snehasish wrote: > > I think we ca

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet updated this revision to Diff 538754. hazohelet marked 3 inline comments as done. hazohelet added a comment. Address comments from aaron.ballman - Added more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153969/new/ https://reviews.llvm.org/D153969 Files: clang/docs/

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; aaron.ballman wrote: > hazohelet wrote: >

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy added a comment. In D154423#4485009 , @balazske wrote: > It would be more simple to handle the standard streams in `StreamChecker` > only. [...] That's a reasonable plan, especially if we can bring that checker out of alpha in the foreseeabl

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a reviewer: MaskRay. aaron.ballman added a comment. Aside from the failing precommit CI test case in C, I think this LGTM. I've added @MaskRay as the code owner for the command line option changes in case he's got concerns regarding the deprecation/removal plans. Repository

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] a1b7db3 - [RISCV] Split __builtin_riscv_xperm4/8 into separate _32 and _64 builtins.

Author: Craig Topper Date: 2023-07-10T12:18:20-07:00 New Revision: a1b7db3e4ccc30b32fb918f7c6c3ff49233ac03d URL: https://github.com/llvm/llvm-project/commit/a1b7db3e4ccc30b32fb918f7c6c3ff49233ac03d DIFF: https://github.com/llvm/llvm-project/commit/a1b7db3e4ccc30b32fb918f7c6c3ff49233ac03d.diff

[PATCH] D154681: [RISCV] Split __builtin_riscv_xperm4/8 into separate _32 and _64 builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1b7db3e4ccc: [RISCV] Split __builtin_riscv_xperm4/8 into separate _32 and _64 builtins. (authored by craig.topper). Repository: rG LLVM Github Mo

[PATCH] D148216: [UTC] Add fallback support for specific metadata, and check their defs

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I might pull this later today until a fix is available. It makes updates of files with globals super cumbersome (you need to manually remove the duplicates). Repository: rG

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM but the CI has to pass! Also don't forget to undo the changes to `buildkite-pipeline.yml` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:2515 +return nullptr; case CASE_WIDEOP_OPCODE_LMULS_MF4(FWADD_WV): + case CASE_WIDEOP_OPCODE_LMU

[PATCH] D154631: [3/8][RISCV] Add rounding mode control variant for vfmul, vfdiv, vfrdiv, vfwmul

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaChecking.cpp:4824 case RISCVVector::BI__builtin_rvv_vfwsub_wf_rm_ta: + case RISCVVector::BI__builtin_rvv_vfmul_vv_rm_ta: +

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D154484#4483659 , @sstwcw wrote: > Did you forget about GNU statement expressions? > > if (({ > foo(); > bar(); > })) { > } I wouldn't haven forgo

[PATCH] D154632: [4/8][RISCV] Add rounding mode control variant for vfmacc, vfnmacc, vfmsac, vfnmsac, vfmadd, vfnmadd, vfmsub, vfnmsub

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154632/new/ https://reviews.llvm.org/D154632 ___

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

justincady added subscribers: njames93, LegalizeAdulthood, justincady. justincady added a comment. This feature appears to have strong user support throughout this review, and a lot of people (including myself) seem interested in having it landed. cc'ing some clang-tidy owners

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

NoQ created this revision. NoQ added reviewers: jkorous, t-rasmud, ziqingluo-90, malavikasamak. Herald added subscribers: steakhal, martong. Herald added a project: All. NoQ requested review of this revision. Herald added a subscriber: wangpc. This patch adds extra notes to `-Wunsafe-buffer-usage`

[clang] 939f818 - [RISCV] Split __builtin_riscv_brev8 into _32 and _64 builtin.

Author: Craig Topper Date: 2023-07-10T13:01:07-07:00 New Revision: 939f818a662a56a3b118e7e4b0656b6f7038adae URL: https://github.com/llvm/llvm-project/commit/939f818a662a56a3b118e7e4b0656b6f7038adae DIFF: https://github.com/llvm/llvm-project/commit/939f818a662a56a3b118e7e4b0656b6f7038adae.diff

[PATCH] D154683: [RISCV] Split __builtin_riscv_brev8 into _32 and _64 builtin.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG939f818a662a: [RISCV] Split __builtin_riscv_brev8 into _32 and _64 builtin. (authored by craig.topper). Changed prior to commit: https://reviews.l

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:578 - virtual const Stmt *getBaseStmt() const override { return nullptr; } + virtual const Stmt *getBaseStmt() const override { return PtrInitRHS; } I changed this to make `F->g

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan created this revision. scchan added a reviewer: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When compiling in device only mode (e.g. --offload-device-only), the host linker phas

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7221-7223 +bool UseApproxTranscendentals = false; +if (Args.hasFlag(options::OPT_ffast_math, options::OPT_fno_fast_math, + false))

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

sbc100 accepted this revision. sbc100 added a comment. lgtm. Can you update the change description now that we decided to not support values? (Ironically I think have a use for values in pipeline now) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl updated this revision to Diff 538787. yaxunl marked 3 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, asavonic, sstefan1. revised by comments CHANGES SINCE LAST ACTION http

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4150 + (C.getInputArgs().hasArg(options::OPT_emit_llvm))) && +!C.getInputArgs().hasArg(options::OPT_offload_device_only)) LinkerInputs.push_back(Current); The

[PATCH] D154884: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp:46 +void UseStdFormatCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(argumentCountAtLeast(1), hasArgument(0, stringLiteral()), -

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

craig.topper added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3879 + + Out << "9__RVV_VLSI" << 'u' << TypeNameStr.size() << TypeNameStr << "Lj" << VecSizeInBits << "EE"; aaron.ballman wrote: > CC @rjmccall for ABI review -- naïve, possib

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1294 +if (!LangOpts.HIP) + Builder.defineMacro("__CLANG_CUDA_APPROX_TRANSCENDENTALS__"); +Builder.defineMacro("

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7228 + } else { +Args.ClaimAllArgs(options::OPT_fgpu_approx_transcendentals); +Args.ClaimAllArgs(options::OPT_fno_gpu_approx_transcendentals); You can use `Args.claimAllArgs

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

MaskRay accepted this revision. MaskRay added a comment. Some nits about testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154797/new/ https://reviews.llvm.org/D154797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 538798. philnik added a comment. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-bui

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

rjmccall added a comment. We had that discussion in the bug report. Let's just increase the widths unconditionally; this is not such a common expression class that we need to worry about using an extra word. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

owenpan added a comment. In D151047#4449996 , @Sedeniono wrote: > As suggested by @owenpan, I split the commits differently. The first commit > now contains only the fix + corresponding tests. The second commit contains > refactorings/asserts. How do I

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson updated this revision to Diff 538805. tejohnson added a comment. Rebase on D154872 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/new/ https://reviews.llvm.org/D154856 Files: clang/include/clang

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe updated this revision to Diff 538806. mikecrowe added a comment. Use isOrdinary in stringLiteral() match on first argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154287/new/ https://reviews.llvm.org/D154287 Files: clang-tools-ex

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

michaelplatings accepted this revision. michaelplatings added a comment. Hi @MaskRay, thanks for the add. Yes, we've been deleting a lot of `eabi` recently, but that's specific to AArch64. I have no particular insight into PowerPC but from @jroelofs' link, I agree `eabi` seems correct here. I'v

[PATCH] D154633: [5/8][RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154633/new/ https://reviews.llvm.org/D154633 ___

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

MaskRay added a comment. In D154357#4485881 , @jroelofs wrote: > gcc docs seem to indicate that these are valid triples: > > https://gcc.gnu.org/install/specific.html#powerpc-x-eabi Thanks, good to know. `powerpc-*-eabi` indicates that the eabi environme

[PATCH] D154884: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

PiotrZSL added a comment. Remove example from commit message, it's already included in patch. Simply commit message should be properly formatted without unnecessary information. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:115 default: -return Regex

[PATCH] D154634: [6/8][RISCV] Add rounding mode control variant for vfsqrt, vfrec7

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154634/new/ https://reviews.llvm.org/D154634 ___

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/ceil-vp.ll:24 ; CHECK-NEXT:vfsgnj.vv v8, v9, v8, v0.t +; CHECK-NEXT:fsrm a0 ; CHECK-NEXT:ret This is concerning. This means the `vfcvt.f.x.v` is getting the modified roundi

[PATCH] D154871: [clang] Satisfy clang v12

ashay-github updated this revision to Diff 538816. ashay-github added a comment. Rebased with main to trigger rebuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154871/new/ https://reviews.llvm.org/D154871 Files: clang/lib/StaticAnalyzer/Chec

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:66 .y = 1, // override-note {{previous}} - .y = 1, // override-error {{overrides prior initialization}} + .y = 1, // override-error {{overrides prior initialization}} // reorder-not

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

MaskRay added a comment. In D151683#4486321 , @aaron.ballman wrote: > Aside from the failing precommit CI test case in C, I think this LGTM. I've > added @MaskRay as the code owner for the command line option changes in case > he's got concerns regardi

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson created this revision. royjacobson added a reviewer: shafik. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #63352 and one other similar issue by slightly adjusting the computation

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. > 95% of the %>t are around clang modulemap files, because that code resolves > real paths in C++ by design, so I can't avoid it. Can you link to evidence that this behavior is by design? It isn't obvious to me why modulemap files would demand different behavior; es

[PATCH] D154861: [clang][AST] Propagate the contains-errors bit to DeclRefExpr from VarDecl's initializer.

shafik added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:461 /// based on the declaration being referenced. ExprDependence clang::computeDependence(DeclRefExpr *E, const ASTContext &Ctx) { auto Deps = ExprDependence::None; `computeDepen

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 538851. schittir marked an inline comment as done. schittir added a comment. Fix format per comments - indent class members and avoid indenting the class definition line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.ll

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

NoQ updated this revision to Diff 538852. NoQ added a comment. `private:` => `public:` (for some reason it didn't complain until I did a full rebuild) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154880/new/ https://reviews.llvm.org/D154880 Files: clang/include/clang/Analysis/Analy

[PATCH] D154902: [Clang] Default ToolChain::IsIntegratedAssemblerDefault to true

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: pmatos, asb, abrachet, mstorsjo, jgravelle-google, sbc100, dschuff. Herald added a project: All. brad requested review of this revision. Herald added subscribers: wangpc, aheejin. Ha

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. madscientist published this revision for review. madscientist added a comment. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Re

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

NoQ updated this revision to Diff 538862. NoQ added a comment. Add the other missing base statement. Debugger was acting weirdly so I thought we had bigger problems, but it's just the other thing missing. It's likely that we ultimately want a better interface for that anyway. CHANGES SINCE LAS

[clang] 7c7b191 - [-Wunsafe-buffer-usage] Unbreak clang-format on UnsafeBufferUsage.cpp. NFC.

Author: Artem Dergachev Date: 2023-07-10T15:57:10-07:00 New Revision: 7c7b19143429dfa6095564d6bb9103410506c183 URL: https://github.com/llvm/llvm-project/commit/7c7b19143429dfa6095564d6bb9103410506c183 DIFF: https://github.com/llvm/llvm-project/commit/7c7b19143429dfa6095564d6bb9103410506c183.dif

[PATCH] D154902: [Clang] Default ToolChain::IsIntegratedAssemblerDefault to true

MaskRay added a comment. `[Driver]` seems more specific than `[Clang]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154902/new/ https://reviews.llvm.org/D154902 ___ cfe-commits mailing list cfe-commits@

[PATCH] D154902: [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true

brad added a comment. In D154902#4487195 , @MaskRay wrote: > `[Driver]` seems more specific than `[Clang]` You're right. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154902/new/ https://reviews.ll

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements `llvm::Poin

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm, thanks for testing the various combinations of profiles passed to each option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

jansvoboda11 added a comment. Note that this enables usage of `{File,Directory}EntryRef` in other containers using `PointerLikeTraits` such as `SmallPtrSet`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154905/new/ https://reviews.llvm.org/D15490

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

benlangmuir added inline comments. Comment at: clang/include/clang/Basic/DirectoryEntry.h:211 + + static constexpr int NumLowBitsAvailable = 3; +}; I suggest not hard-coding it if you can get away with it; maybe `PointerLikeTypeTraits::NumLowBitsAvailable`? I t

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris updated this revision to Diff 538867. ormris added a comment. Attempt to fix pre-merge checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 Files: clang/include/clang/CodeGen/CodeGenAction.h clang/lib/CodeGen/CodeGenAction.cpp

[clang] b4a82b6 - [MemProf] Use new option/pass for profile feedback and matching

Author: Teresa Johnson Date: 2023-07-10T16:42:56-07:00 New Revision: b4a82b62258c5f650a1cccf5b179933e6bae4867 URL: https://github.com/llvm/llvm-project/commit/b4a82b62258c5f650a1cccf5b179933e6bae4867 DIFF: https://github.com/llvm/llvm-project/commit/b4a82b62258c5f650a1cccf5b179933e6bae4867.diff

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a82b62258c: [MemProf] Use new option/pass for profile feedback and matching (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

jdenny added a comment. If the `%>` feature is going to remain (depending on, for example, the answer to @tahonermann's question about modulemap), please: 1. Add it to the lit documentation at https://llvm.org/docs/TestingGuide.html#substitutions and

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

jdenny added a comment. 3. Extend lit's own test suite to cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D154910: [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned long/uint64_t.

craig.topper created this revision. craig.topper added reviewers: dmgreen, tmatheson, compnerd, SjoerdMeijer, kongyi. Herald added a subscriber: kristof.beyls. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. Use unsigned long in place of

[PATCH] D154910: [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned long/uint64_t.

craig.topper updated this revision to Diff 538880. craig.topper added a comment. Update __clzl test case to pass an unsigned long instead of signed long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154910/new/ https://reviews.llvm.org/D154910 Fi

[PATCH] D154911: Enabling fstack_clash_protection for arm32 bit, thumb and thumb2 mode

varunkumare99 created this revision. varunkumare99 added reviewers: tnfchris, efriedma, kristof.beyls, serge-sans-paille. Herald added a subscriber: hiraditya. Herald added a project: All. varunkumare99 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay

[clang] 46333f7 - [clang] Satisfy clang v12

Author: Ashay Rane Date: 2023-07-10T20:07:43-05:00 New Revision: 46333f71f8e0d6444a9b2c9e063aedb83ebb9735 URL: https://github.com/llvm/llvm-project/commit/46333f71f8e0d6444a9b2c9e063aedb83ebb9735 DIFF: https://github.com/llvm/llvm-project/commit/46333f71f8e0d6444a9b2c9e063aedb83ebb9735.diff LO

[PATCH] D154871: [clang] Satisfy clang v12

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46333f71f8e0: [clang] Satisfy clang v12 (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

MaskRay added inline comments. Comment at: clang/test/Frontend/split-lto-ir-support.cpp:1 +// RUN: %clang -c -flto=thin %s -o %t0.bc +// RUN: mkdir %t1.d Without -fsanitize=cfi or -fwhole-program-vtables, -fsplit-lto-unit is not the default. You need to specify

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

qiucf added a comment. Is there any blocker for this to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 4a1f8fd - [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true

Author: Brad Smith Date: 2023-07-10T22:26:12-04:00 New Revision: 4a1f8fd548f12a52f91b2856cb6880691f70190b URL: https://github.com/llvm/llvm-project/commit/4a1f8fd548f12a52f91b2856cb6880691f70190b DIFF: https://github.com/llvm/llvm-project/commit/4a1f8fd548f12a52f91b2856cb6880691f70190b.diff LO

[PATCH] D154902: [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1f8fd548f1: [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:786-788 +uint32_t DeclID = ~0U; +unsigned ODRHash = ~0U; +bool IsPartial = false; Maybe this can save some space. Comment at: clang/lib/AST/DeclTemp

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added a comment. I tested this with our internal use cases with modules and it looks good. Things get compiled correctly and we saved 10% compilation time. (May be due to different code bases). But some local in tree tests got failed. I took some time to investigate them but I didn't

[PATCH] D154822: Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang updated this revision to Diff 538894. boxu-zhang added a comment. Append 'CUDA_API_PER_THREAD_DEFAULT_STREAM' as a defined macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154822/new/ https://reviews.llvm.org/D154822 Files: clang/l

[PATCH] D154822: Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang added a comment. In D154822#4485700 , @tra wrote: > Looking at CUDA headers, it appears that changing only > compiler-generated-glue may be insufficient. A lot of other CUDA API calls > need to be changed to `_ptsz` variant and for that we ne

[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

craig.topper created this revision. craig.topper added reviewers: dmgreen, efriedma, SjoerdMeijer, tmatheson, kongyi. Herald added a subscriber: kristof.beyls. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. D152023

[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

craig.topper added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:351 // long test_clzl(long t) { return __clzl(t); __builtin_clzl returned a signed int, but the new builtin returns an unsigned int so the cast changed. Repository: rG LLVM Gi

[PATCH] D154822: Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang added a comment. Another point that I don't get is why the libcxx CI failed. Anyone know the reason this message? " Running global pre-checkout hook Preparing working directory Running global post-checkout hook Running commands $ trap 'kill -- $$' INT TERM QUIT; libcxx/utils/ci/generat

[PATCH] D154822: [clang] Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang updated this revision to Diff 538904. boxu-zhang retitled this revision from "Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA" to "[clang] Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA". boxu-zhang added a comment. Add component 'clang' in commit message Reposi

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

MaskRay added a comment. LGTM. CC1 -mlink-bitcode-file is an interesting option from 2011: f1d76db466b2a50781c0754b86ac994dd07b5041 I wonder what the original use case is... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews

<    1   2   3   >