tahonermann added a comment. > 95% of the %>t are around clang modulemap files, because that code resolves > real paths in C++ by design, so I can't avoid it.
Can you link to evidence that this behavior is by design? It isn't obvious to me why modulemap files would demand different behavior; especially since that would exacerbate `MAX_PATH` problems. I'm not fond of the `safe_abs_path` name; "safe" doesn't communicate anything and the implementation is no more safe than `os.path.abspath` or `os.path.realpath`. Suggested alternatives: - `short_abs_path` - `shortest_abs_path` - `abs_path_no_subst_drive` - `abs_path_preserve_drive` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
