jdenny added a comment.

If the `%>` feature is going to remain (depending on, for example, the answer 
to @tahonermann's question <https://reviews.llvm.org/D154130#4486898> about 
modulemap), please:

1. Add it to the lit documentation at 
https://llvm.org/docs/TestingGuide.html#substitutions and 
https://llvm.org/docs/CommandGuide/lit.html#substitutions.  (Aside: I wish 
someone would reconcile those lists.)
2. Consider whether there's a clearer syntax.  For example, we already have 
`%{/t:regex_replacement}`.  What about `%{t:real}` and `%{/t:real}`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154130/new/

https://reviews.llvm.org/D154130

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to