Author: Sindhu Chittireddy Date: 2023-07-10T11:32:13-07:00 New Revision: fd857f786f61620c370d132fe9ba1b5608bb4f50
URL: https://github.com/llvm/llvm-project/commit/fd857f786f61620c370d132fe9ba1b5608bb4f50 DIFF: https://github.com/llvm/llvm-project/commit/fd857f786f61620c370d132fe9ba1b5608bb4f50.diff LOG: [NFC] Initialize pointer fields and remove needless null check. Reviewed here: https://reviews.llvm.org/D153589 Added: Modified: clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGObjCGNU.cpp clang/lib/Format/UnwrappedLineParser.h clang/lib/Lex/PPExpressions.cpp clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/CFG.cpp b/clang/lib/Analysis/CFG.cpp index b0f44ec0edcbbb..3f2367fafc88f7 100644 --- a/clang/lib/Analysis/CFG.cpp +++ b/clang/lib/Analysis/CFG.cpp @@ -4152,7 +4152,7 @@ CFGBlock *CFGBuilder::VisitCXXTypeidExpr(CXXTypeidExpr *S, AddStmtChoice asc) { // operand. [...] // We add only potentially evaluated statements to the block to avoid // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S); // Return block without CFG for unevaluated operands. diff --git a/clang/lib/CodeGen/CGObjCGNU.cpp b/clang/lib/CodeGen/CGObjCGNU.cpp index c7b193e34ea0a3..09b6c3ac6adf41 100644 --- a/clang/lib/CodeGen/CGObjCGNU.cpp +++ b/clang/lib/CodeGen/CGObjCGNU.cpp @@ -46,17 +46,13 @@ namespace { /// types and the function declaration into a module if they're not used, and /// avoids constructing the type more than once if it's used more than once. class LazyRuntimeFunction { - CodeGenModule *CGM; - llvm::FunctionType *FTy; - const char *FunctionName; - llvm::FunctionCallee Function; + CodeGenModule *CGM = nullptr; + llvm::FunctionType *FTy = nullptr; + const char *FunctionName = nullptr; + llvm::FunctionCallee Function = nullptr; public: - /// Constructor leaves this class uninitialized, because it is intended to - /// be used as a field in another class and not all of the types that are - /// used as arguments will necessarily be available at construction time. - LazyRuntimeFunction() - : CGM(nullptr), FunctionName(nullptr), Function(nullptr) {} + LazyRuntimeFunction() = default; /// Initialises the lazy function with the name, return type, and the types /// of the arguments. diff --git a/clang/lib/Format/UnwrappedLineParser.h b/clang/lib/Format/UnwrappedLineParser.h index 9650ce1a9c1583..311d879b0a0881 100644 --- a/clang/lib/Format/UnwrappedLineParser.h +++ b/clang/lib/Format/UnwrappedLineParser.h @@ -306,7 +306,7 @@ class UnwrappedLineParser { // Since the next token might already be in a new unwrapped line, we need to // store the comments belonging to that token. SmallVector<FormatToken *, 1> CommentsBeforeNextToken; - FormatToken *FormatTok; + FormatToken *FormatTok = nullptr; bool MustBreakBeforeNextToken; // The parsed lines. Only added to through \c CurrentLines. diff --git a/clang/lib/Lex/PPExpressions.cpp b/clang/lib/Lex/PPExpressions.cpp index 6c935148f40726..7c41dd510d2dba 100644 --- a/clang/lib/Lex/PPExpressions.cpp +++ b/clang/lib/Lex/PPExpressions.cpp @@ -44,7 +44,7 @@ namespace { /// conditional and the source range covered by it. class PPValue { SourceRange Range; - IdentifierInfo *II; + IdentifierInfo *II = nullptr; public: llvm::APSInt Val; diff --git a/clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp index 1bf6592ee6d8e0..51ae0506466a7d 100644 --- a/clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp @@ -84,7 +84,7 @@ class CStringChecker : public Checker< eval::Call, mutable std::unique_ptr<BugType> BT_Null, BT_Bounds, BT_Overlap, BT_NotCString, BT_AdditionOverflow, BT_UninitRead; - mutable const char *CurrentFunctionDescription; + mutable const char *CurrentFunctionDescription = nullptr; public: /// The filter is used to filter out the diagnostics which are not enabled by _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
