[PATCH] D149904: Generic selection expressions that accept a type operand

cor3ntin added a comment. I observe there is no documentation or release notes yet :) Comment at: clang/include/clang/AST/Expr.h:5930 + /// argument. + bool isExprPredicate() const { return IsExprPredicate; } + /// Whether this generic selection uses a type as its controllin

[PATCH] D149899: [clang-tidy] Support SystemHeaders in .clang-tidy

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. From functionally point of view, LGTM. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11 +// RUN: clang-tidy -checks='-*,google-explicit

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( alexander-shaposhnikov wrote: > alexander-shaposhnikov wrote: > > alexander-shaposhnikov wrote: > > > HandlePar

cfe-commits@lists.llvm.org

ilya-biryukov added a comment. In D148924#4320694 , @shafik wrote: > The paper also uses the term constexpr compatible which has been replaced > with constexpr suitable and not sure if that has any practical effect here. They seem to be different term,

[clang] e8fb478 - [clang][Interp] Don't call getSource() on functions without a body

Author: Timm Bäder Date: 2023-05-05T11:59:42+02:00 New Revision: e8fb478f2df863c744b4eed5a5aa07a36fba737d URL: https://github.com/llvm/llvm-project/commit/e8fb478f2df863c744b4eed5a5aa07a36fba737d DIFF: https://github.com/llvm/llvm-project/commit/e8fb478f2df863c744b4eed5a5aa07a36fba737d.diff LO

[PATCH] D149824: [clang][Interp] Don't call getSource() on functions without a body

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8fb478f2df8: [clang][Interp] Don't call getSource() on functions without a body (authored by tbaeder). Changed prior to commit: https://reviews.l

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin, benshi001, wangleiat. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subs

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. TODO: update llvm/clang release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149946 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

rengolin added a reviewer: peter.smith. rengolin added a comment. Rationale and implementation make sense to me. I'll let this one sit so that other folks, including Arm, can have a look, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/ne

[PATCH] D149948: [include-cleaner] Treat references to nested types implicit

kadircet created this revision. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149948 Files: clang-tools-extra/include-cl

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added inline comments. Comment at: clang/test/FixIt/fixit-function-call.cpp:1 -// RUN: not %clang_cc1 -fdiagnostics-parseable-fixits -x c++ %s 2> %t +// RUN: not %clang_cc1 -fdiagnostics-parseable-fixits -fno-diagnostics-show-line-numbers -fcaret-diagnostics-max-lines 1

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. > However, I'm not keen on us playing whack-a-mole with the kinds of checks > from this review. For starters, that's going to have a long-tail that makes > it hard to know if we've ever gotten to the bottom of the issue. But also, > each one of these checks is basicall

[PATCH] D149899: [clang-tidy] Support SystemHeaders in .clang-tidy

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11 +// RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='.*' -config='SystemHeaders: false' %s -- -isystem %S/Inputs/system-headers 2>&1

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder updated this revision to Diff 519799. tbaeder added a comment. Add docs and a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp

[PATCH] D149899: [clang-tidy] Support SystemHeaders in .clang-tidy

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11 +// RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='.*' -config='SystemHeaders: false' %s -- -isystem %S/Inputs/system-headers 2>&1 | Fil

[PATCH] D149904: Generic selection expressions that accept a type operand

Fznamznon added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7033-7036 + if (E->isExprPredicate()) +ToControllingExpr = importChecked(Err, E->getControllingExpr()); + else +ToControllingType = importChecked(Err, E->getControllingType()); J

[PATCH] D149904: Generic selection expressions that accept a type operand

aaron.ballman marked 9 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:5686 /// if and only if the generic selection expression is result-dependent. - unsigned NumAssocs, ResultIndex; + unsigned NumAssocs, ResultIndex,

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 519822. TIFitis added a comment. Changed std::function to llvm::function_ref for the callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/Cod

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11141-11145 if (!Chunk.Fun.hasTrailingReturnType()) { + IsValid = false; Diag(D.getName().getBeginLoc(), diag::err_deduction_guide_no_trailing_return_type); break;

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519824. ldionne added a comment. Use tarball Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149752/new/ https://reviews.llvm.org/D149752 Files: clang/foo libcxx/utils/ci/buildkite-pipeline-clang.yml libcx

[clang] c7cd7a0 - [clang][test][RISCV] Pre-commit test for HasLegalHalfType patch

Author: Alex Bradbury Date: 2023-05-05T13:55:20+01:00 New Revision: c7cd7a050acb98b9d1df895c4b009c7c7078d917 URL: https://github.com/llvm/llvm-project/commit/c7cd7a050acb98b9d1df895c4b009c7c7078d917 DIFF: https://github.com/llvm/llvm-project/commit/c7cd7a050acb98b9d1df895c4b009c7c7078d917.diff

[clang] 560065b - [clang][RISCV] Set HasLegalHalfType to true if zfh is enabled

Author: Alex Bradbury Date: 2023-05-05T13:55:43+01:00 New Revision: 560065b6ecd539862fbc61401b02a1d5faea1ad1 URL: https://github.com/llvm/llvm-project/commit/560065b6ecd539862fbc61401b02a1d5faea1ad1 DIFF: https://github.com/llvm/llvm-project/commit/560065b6ecd539862fbc61401b02a1d5faea1ad1.diff

[PATCH] D145071: [clang][RISCV] Set HasLegalHalfType to true if zfh is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG560065b6ecd5: [clang][RISCV] Set HasLegalHalfType to true if zfh is enabled (authored by asb). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[PATCH] D149904: Generic selection expressions that accept a type operand

erichkeane added inline comments. Comment at: clang/include/clang/AST/Expr.h:5712 +// predicate expression. +return (int)isExprPredicate(); + } aaron.ballman wrote: > erichkeane wrote: > > Should these have asserts also? Wouldn't saying this is index '0

[PATCH] D149904: Generic selection expressions that accept a type operand

aaron.ballman marked 10 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:5712 +// predicate expression. +return (int)isExprPredicate(); + } erichkeane wrote: > aaron.ballman wrote: > > erichkeane wr

[PATCH] D146987: [Assignment Tracking] Enable by default

kito-cheng added a comment. Got crash for RISC-V on top of trunk: [kitoc@hsinchu02 build]$ cat x.c typedef __rvv_uint32m4_t a; void b() { a c; } [kitoc@hsinchu02 build]$ bin/clang -target riscv64-elf x.c -O -g clang-14: /home/kitoc/llvm-workspace/llvm-project/llvm/lib/IR/DebugInfo.cpp:

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder updated this revision to Diff 519834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148689/new/ https://reviews.llvm.org/D148689 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp Index: clang/test/AST

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

tbaeder updated this revision to Diff 519835. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148689/new/ https://reviews.llvm.org/D148689 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp Index: clang/test/AST

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

erichkeane added a comment. Looks like both ABIs that use this assume the parameter passed to `getMemberPointerInfo` is non-null. While we DO check the type (in reality, we probably should be doing a `if (const auto *MPT = Ty->getAs())` instead, I think this is a problem that at least SHOULD

[PATCH] D149612: [Sema] avoid merge error type

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2582 } else if (ArraySize->isTypeDependent() || ArraySize->isValueDependent()) { -T = Context.getDependentSizedArrayType(T, ArraySize, ASM, Quals, Brackets); +if (getLangOpts().CPlusPlus) { +

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. Hey @jdoerfert sorry to bother you, would it be possible to have this signed off on if there is no further issues with the current patch? Thank you for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133 } +Response HandlePartialClassTemplateSpec( alexander-shaposhnikov wrote: > alexander-shaposhnikov wrote: > > alexander-shaposhnikov wrote: > > > alexander-shaposhniko

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thanks for the reproducer and report! I'll have a patch up for this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-co

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. I see this is closed... but I accept if you wish to re-commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___ cfe-commits

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Mostly looks good, just a few small nits Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:47 -std::hash SecondHash; -return DenseMapInfo

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 519847. HerrCai0907 added a comment. return Diag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/S

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > > paperchalic

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. That should be fixed with D149959 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits ma

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519849. oontvoo added a comment. Herald added a subscriber: MaskRay. updated more clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/cl

[PATCH] D149904: Generic selection expressions that accept a type operand

aaron.ballman updated this revision to Diff 519850. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149904/new/ https://reviews.llvm.org/D149904 Files: clang/include/clang/A

[PATCH] D149904: Generic selection expressions that accept a type operand

aaron.ballman added a comment. In D149904#4321144 , @cor3ntin wrote: > I observe there is no documentation or release notes yet :) Those are coming up, I wanted to see if the RFC made any substantive changes to the design before doing the documentation

[clang] 30af2fb - [NFC][Clang] Remove release note since the patch was backported in time

Author: Roy Jacobson Date: 2023-05-05T17:54:40+03:00 New Revision: 30af2fb33ed2f610abfa50e53df9712887b2bd25 URL: https://github.com/llvm/llvm-project/commit/30af2fb33ed2f610abfa50e53df9712887b2bd25 DIFF: https://github.com/llvm/llvm-project/commit/30af2fb33ed2f610abfa50e53df9712887b2bd25.diff

[clang] 55e196e - [RISCV] Add sifive-x280 processor with all of its extensions

Author: Michael Maitland Date: 2023-05-05T07:55:07-07:00 New Revision: 55e196e7718c543b4492f2949c13de003a4ba443 URL: https://github.com/llvm/llvm-project/commit/55e196e7718c543b4492f2949c13de003a4ba443 DIFF: https://github.com/llvm/llvm-project/commit/55e196e7718c543b4492f2949c13de003a4ba443.di

[PATCH] D149960: [clang][Interp] Fix ignoring String- and CharacterLiterals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D149710: [RISCV] Add sifive-x280 processor with all of its extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55e196e7718c: [RISCV] Add sifive-x280 processor with all of its extensions (authored by michaelmaitland). Changed prior to commit: https://reviews

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd02b69e75dd: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td (authored by michaelmaitland). Changed prior to commit: https://reviews.llvm.org/D149497?vs=518924&id=519854#toc

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

This revision was automatically updated to reflect the committed changes. Closed by commit rGb77d6f51ba4e: [RISCV] Add Scheduling information for Zfh to SiFive7 model (authored by michaelmaitland). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149498

[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

royjacobson created this revision. royjacobson added reviewers: shafik, erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I checked if the member function declaration was a copy constructor

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna added a comment. In D149922#4321972 , @erichkeane wrote: > Looks like both ABIs that use this assume the parameter passed to > `getMemberPointerInfo` is non-null. While we DO check the type (in reality, > we probably should be doing a `if (const

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna updated this revision to Diff 519859. Manna added a comment. I have updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149922/new/ https://reviews.llvm.org/D149922 Files: clang/lib/AST/ASTContext.cpp Index: clang/lib/AST/ASTContext.cpp ===

[PATCH] D149904: Generic selection expressions that accept a type operand

aaron.ballman updated this revision to Diff 519861. aaron.ballman added a comment. Added a feature test macro, documentation, and a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149904/new/ https://reviews.llvm.org/D149904 Files: clang/docs/LanguageExtensions.rst clan

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2862 - if (Ty->isMemberPointerType()) { -const auto *MPT = Ty->getAs(); + if (const auto *MPT = Ty->getAs()) { return !ABI->getMemberPointerInfo(MPT).HasPadding; Remove the cu

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We didn't call the function explicitly in a stati

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna updated this revision to Diff 519868. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149922/new/ https://reviews.llvm.org/D149922 Files: clang/lib/AST/ASTContext.cpp Index: clang/lib/AST/ASTContext.cpp =

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2862 - if (Ty->isMemberPointerType()) { -const auto *MPT = Ty->getAs(); + if (const auto *MPT = Ty->getAs()) { return !ABI->getMemberPointerInfo(MPT).HasPadding; erichkeane wrote:

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

alvinhochun updated this revision to Diff 519869. alvinhochun edited the summary of this revision. alvinhochun added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase and add test cases with `offset` operator, and some TODOs/FIXMEs for comment Repository:

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

alvinhochun marked an inline comment as not done. alvinhochun added a comment. In D149579#4320765 , @MaskRay wrote: > OK. I think after D149695 (landed), > D149920 , and this patch D14

[PATCH] D149710: [RISCV] Add sifive-x280 processor with all of its extensions

michaelmaitland added a comment. I had to revert this commit because it failed tests that did not fail during build through phabricator nor local check-all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149710/new/ https://reviews.llvm.org/D149710

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna added a comment. Thanks @erichkeane for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149922/new/ https://reviews.llvm.org/D149922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] d6bd4ea - Revert "[RISCV] Add sifive-x280 processor with all of its extensions"

Author: Michael Maitland Date: 2023-05-05T08:20:18-07:00 New Revision: d6bd4ea35437b1d39933e9526779e8c6e03125e0 URL: https://github.com/llvm/llvm-project/commit/d6bd4ea35437b1d39933e9526779e8c6e03125e0 DIFF: https://github.com/llvm/llvm-project/commit/d6bd4ea35437b1d39933e9526779e8c6e03125e0.di

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a caution about testing the mangled signature (you can fix that up when landing though). Comment at: clang/test/AST/Interp/literals.cpp:848 + void f

[PATCH] D149776: Re-land "[AMDGPU] Define data layout entries for buffers""

foad added a comment. Hi, with the new datalayout we're hitting this crash: ; RUN: opt -passes=indvars -S < %s target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-p7:160:256:256:32-p8:128:128-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v51

[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

shafik added a comment. Thank you for fixing this so quickly! Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:2750 + if (auto *Constructor = dyn_cast(Method)) { +if (Constructor->isDefaultConstructor() || I have look at this function a few tim

[clang] a11dfd0 - [RISCV] Add sifive-x280 processor with all of its extensions

Author: Michael Maitland Date: 2023-05-05T08:47:57-07:00 New Revision: a11dfd0fe6b1c38495f7de9858a2d1839d2902b9 URL: https://github.com/llvm/llvm-project/commit/a11dfd0fe6b1c38495f7de9858a2d1839d2902b9 DIFF: https://github.com/llvm/llvm-project/commit/a11dfd0fe6b1c38495f7de9858a2d1839d2902b9.di

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

dschuff added a comment. Do we want to make this any more general? In the future we might want to preserve other sections, e.g. passing optimization or profiling info from LLVM to Binaryen. Or maybe JSPI info? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 6e7ca68 - Revert "[RISCV] Add sifive-x280 processor with all of its extensions"

Author: Michael Maitland Date: 2023-05-05T09:03:06-07:00 New Revision: 6e7ca6839def260e57334040a586934011f0098d URL: https://github.com/llvm/llvm-project/commit/6e7ca6839def260e57334040a586934011f0098d DIFF: https://github.com/llvm/llvm-project/commit/6e7ca6839def260e57334040a586934011f0098d.di

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; jrtc27 wrote: > kwk wr

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Presuming that the issues found by precommit CI were resolved (current failures are unrelated to your changes), this LGTM but still needs a release note. Repository: rG LLVM G

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148689/new/ https://reviews.llvm.org/D148689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/CodeGen/mrtd.c:9 +// X86: define{{.*}} x86_stdcallcc void @foo(i32 noundef %arg) [[NUW:#[0-9]+]] +// M68k: define{{.*}} cc104 void @foo(i32 noundef %arg) void foo(int arg) { 0x59616e wrote: > 0x59616e wrote: >

[clang] 8394694 - [RISCV] Add sifive-x280 processor with all of its extensions

Author: Michael Maitland Date: 2023-05-05T10:02:28-07:00 New Revision: 839469436afcbdf5bb6dc9b081b1bcf3a1b22fea URL: https://github.com/llvm/llvm-project/commit/839469436afcbdf5bb6dc9b081b1bcf3a1b22fea DIFF: https://github.com/llvm/llvm-project/commit/839469436afcbdf5bb6dc9b081b1bcf3a1b22fea.di

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? CHANGES SINCE LAST ACTION https://

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali added a comment. Name : Rishabh Bali Github Username : Ris-Bali email-id : rishabhsb...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149596/new/ https://reviews.llvm.org/D149596

[clang] 0b3d737 - Check if First argument in _builtin_assume_aligned_ is of pointer type

Author: Rishabh Bali Date: 2023-05-05T13:11:16-04:00 New Revision: 0b3d737877040a4eae03e47223f9a9ddfd7bd182 URL: https://github.com/llvm/llvm-project/commit/0b3d737877040a4eae03e47223f9a9ddfd7bd182 DIFF: https://github.com/llvm/llvm-project/commit/0b3d737877040a4eae03e47223f9a9ddfd7bd182.diff

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b3d73787704: Check if First argument in _builtin_assume_aligned_ is of pointer type (authored by Ris-Bali, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland added a comment. This revision needs to be reopened because it was committed with changes that are not relevant to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149497/new/ https://reviews.llvm.org/D149497

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland updated this revision to Diff 519921. michaelmaitland added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149497/new/ https://reviews.llvm.org/D149497 Files: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td Index:

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9fa8a599704: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td (authored by michaelmaitland). Repository: rG LLVM Github

[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oh wow, I'm surprised that calculating the distance has that much compile time impact. Great catch! Please add `NFC` to the commit summary so folks know why there are no tests.

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

PiotrZSL marked 3 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:47 -std::hash SecondHash; -return DenseMapInfo::getHashValue(Val.first) + - SecondHash(Val.second); +return

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

PiotrZSL updated this revision to Diff 519924. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Use operator + instead of hash_combine. Use TraverseAST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149723/new/ https://reviews.

[PATCH] D149846: [clang][Interp] Check inc/dec family of ops for initialization

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149846/new/ https://reviews.llvm.org/D149846

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo marked an inline comment as done. oontvoo added a comment. In D144999#4319964 , @jyknight wrote: > I wonder if we actually need to define a clang frontend flag for this; I > suspect nobody will ever want to specify it, since the only non-canonica

[PATCH] D149976: adding bf16 support to NVPTX

kushanam created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, hiraditya. Herald added a project: All. kushanam requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jholewinski. Herald added projects: clang, LLVM. Currently, b

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } Nit: nothing actually tests that this object is destroyed

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

MaskRay added inline comments. Comment at: llvm/test/MC/X86/intel-syntax-branch.s:61-67 + // FIXME: MASM does not accept this syntax and GAS assembles this as a direct + //call/jump instead of indirect. Consider making this syntax an error? + call [offset fn_ref] + j

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

gribozavr2 added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:58 + (Lexer::getIndentationForLine(Loc, Loc.getManager()) + "/* " + + NoLintPrefix + "NOLINTNEXTLINE(" + Error.DiagnosticName

[PATCH] D149976: adding bf16 support to NVPTX

tra added a comment. This patch appears to *include* the changes in D144911 (e.g. llvm/test/CodeGen/NVPTX/bf16-instructions.ll is added by both patches). Can you update it as an incremental patch that actually excludes it? Repository: rG LLVM Github Monore

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:56-57 + const Record *R = P.getOrCreateRecord(MD->getParent()); + llvm::DenseMap _LambdaCaptures; + FieldDecl *_LambdaThisCapture; + UB alert -- `_L` is reser

[clang] 6e0c441 - [NFC][CLANG] Fix nullptr dereference found by Coverity static analysis tool

Author: Manna, Soumi Date: 2023-05-05T11:57:33-07:00 New Revision: 6e0c44174823260fd74d14d036eaf1c64fa5eded URL: https://github.com/llvm/llvm-project/commit/6e0c44174823260fd74d14d036eaf1c64fa5eded DIFF: https://github.com/llvm/llvm-project/commit/6e0c44174823260fd74d14d036eaf1c64fa5eded.diff

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e0c44174823: [NFC][CLANG] Fix nullptr dereference found by Coverity static analysis tool (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519939. oontvoo added a comment. addressed review comments: - added explanation on why we left out _gcc personality - updated more clang tests hopefully should be all green now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, MaskRay. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:594 - // Add paths specified in LIBRARY_PATH environment variable as -L options. - addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH"); - Is removal of this line intentional? =

[PATCH] D149980: Remove unused basic_android_tree/mipsel-linux-android

hiraditya created this revision. hiraditya added reviewers: danalbert, enh, pirama, srhines. Herald added subscribers: danielkiss, atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. hiraditya requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

davidstone created this revision. Herald added a subscriber: martong. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have four places that we try to decide which name to use for the test for stru

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

peter.smith added a comment. No objections for moving out m_arm_Features_Group or adding the alias. It looks like that is currently unused i.e. no driver filters out the m_arm_Features_Group. I can't comment on the LoongArch specific parts of the patch. I think you may want to note in the help

[PATCH] D149982: AMDGPU: Add basic gfx941 target

kzhuravl created this revision. kzhuravl added reviewers: arsenm, msearles, rampitec, t-tye. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. H

[PATCH] D149983: AMDGPU: Add basic gfx942 target

kzhuravl created this revision. kzhuravl added reviewers: arsenm, msearles, rampitec, t-tye. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. H

  1   2   >