shafik added a comment.
Thank you for fixing this so quickly!
================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:2750
+ if (auto *Constructor = dyn_cast<CXXConstructorDecl>(Method)) {
+ if (Constructor->isDefaultConstructor() ||
----------------
I have look at this function a few times and it is not obvious to me why this
is the right thing to do once we get to this point, Can you add some
explanatory comments and maybe a standard reference. This is a large function
and probably could use a lot more explanatory comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149961/new/
https://reviews.llvm.org/D149961
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
