aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a caution about testing the mangled signature (you can fix that up
when landing though).
================
Comment at: clang/test/AST/Interp/literals.cpp:848
+ void foo() {
+ static_assert(strings_match(__FUNCDNAME__, "_ZN15PredefinedExprs3fooEv"),
"");
+ static_assert(strings_match(__FUNCSIG__, "void __cdecl
PredefinedExprs::foo(void)"), "");
----------------
I suspect this will pass for you on one ABI but fail on another due to mangling
differences. You might need to specify an ABI on the RUN lines to account for
that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
