PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land.
From functionally point of view, LGTM. ================ Comment at: clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11 +// RUN: clang-tidy -checks='-*,google-explicit-constructor' -header-filter='.*' -config='SystemHeaders: false' %s -- -isystem %S/Inputs/system-headers 2>&1 | FileCheck -check-prefix=CHECK-NO-SYSTEM-HEADERS %s + +#include <system_header.h> ---------------- I missing 2 types of tests here: - config value override, `-config='SystemHeaders: true' -system-headers=false` - config file override, when one file has `false`, other `true`, but InheritConfig is used. Both should work, but would be good to test them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149899/new/ https://reviews.llvm.org/D149899 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
