[clang] f2d878b - Revert "[clang] Tweak test to tolerate clang being called "clang" instead of "clang-15""

Author: Nico Weber Date: 2022-12-06T10:22:35-05:00 New Revision: f2d878ba688adf134fd0c4ad971ada57c1898e62 URL: https://github.com/llvm/llvm-project/commit/f2d878ba688adf134fd0c4ad971ada57c1898e62 DIFF: https://github.com/llvm/llvm-project/commit/f2d878ba688adf134fd0c4ad971ada57c1898e62.diff LO

[clang] 8e7994b - Revert "[Driver][test] Fix test by creating empty archive instead of empty file"

Author: Nico Weber Date: 2022-12-06T10:22:47-05:00 New Revision: 8e7994b9b513497589d4bf911f061378f517fb16 URL: https://github.com/llvm/llvm-project/commit/8e7994b9b513497589d4bf911f061378f517fb16 DIFF: https://github.com/llvm/llvm-project/commit/8e7994b9b513497589d4bf911f061378f517fb16.diff LO

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. Reverted this in 8e7994b9b513497589d4bf911f061378f517fb16 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D13

[PATCH] D138141: [amdgpu] Reimplement LDS lowering

JonChesterfield updated this revision to Diff 480484. JonChesterfield added a comment. Herald added subscribers: cfe-commits, libc-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1,

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:4819-4831 +// When we don't have 16 bit instructions, bf16 is illegal and gets +// softened to i16 for storage, with float being used for arithmetic. +// +// After softening, some

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. The direction of the changes looks right. I noted a couple of minor considerations. Comment at: clang/lib/AST/ASTContext.cpp:7109 + case BuiltinType::Ch

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:4819-4831 +// When we don't have 16 bit instructions, bf16 is illegal and gets +// softened to i16 for storage, with float being used for arithmetic. +// +// After softening, so

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added a comment. It looks like we have an existing message for the regular function case e.g.: void g() { int x; void f(int y = x); auto lambda1 = [] {}; } see godbolt: https://godbolt.org/z/1vneM5b35 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added a comment. It looks like the existing diagnostic is issued by `CheckDefaultArgumentVisitor`. I think you can reuse it here but not 100% on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D1394

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:827 +{{"zvkb"}, {ImpliedExtsZve64x}}, +{{"zvkg"}, {ImpliedExtsZve32x}}, +{{"zvknha"}, {ImpliedExtsZve32x}}, ego wrote: > What is the reasoning between 32 vs 64 for those

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

yaxunl added inline comments. Comment at: clang/test/Driver/hip-link-bc-to-bc.hip:22 // Check that clang unbundles the bitcode and archive and links via llvm-link -// RUN: touch %t/libhipbundle.a +// RUN: ar rc %t/libhipbundle.a // RUN: touch %t/bundle.bc proba

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:77 +TEST_F(HeaderIncludesTest, DeleteImportAndSameInclude) { + std::string Code = "#include \"abc.h\"\

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

Szelethus added a comment. Sorry abour my previous reply, I messed up the thread I was replying to. I better see what is going on. Do you have a better handle on @martong's previous comment (D135247#3867603 )? Do we know why this strange behaviour occu

[PATCH] D139378: Add noundef metadata to load instructions (preliminary 4 or 4)

jmciver created this revision. jmciver added reviewers: vitalybuka, jdoerfert, rjmccall, aqjune, efriedma, nikic. Herald added a project: All. jmciver retitled this revision from "[clang][CodeGen] Add noundef metadata to load instructions (item 4)" to "Add noundef metadata to load instructions (

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito added a comment. Thanks for the review arsenm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138755/new/ https://reviews.llvm.org/D138755 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. I think the relevant change from p1787 is to dcl.fct.default p4 , specifically: > ... Declarations that inhabit different scopes have completely distinct se

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3974491 , @cor3ntin wrote: > I'm not sure how I feel about this. > Clang does not, implement correctly that paragraph at all, so I think the > best course here is to create an issue on the llvm github and mark the dr >

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:4819-4831 +// When we don't have 16 bit instructions, bf16 is illegal and gets +// softened to i16 for storage, with float being used for arithmetic. +// +// After softening, some

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. > I think the relevant change from p1787 is to dcl.fct.default p4, specifically: > >> ... Declarations that inhabit different scopes have completely distinct sets >> of default arguments ... It previously said "Declarations __in__ different scopes". To me it's no more th

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, efriedma, jyknight, hubert.reinterpretcast. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This implements WG14 N2975 relaxing requirements for va_s

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta added a comment. I think this is ready to land @Mordante or is there anything else missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commi

[PATCH] D138254: [llvm] Fix the build on OpenBSD by removing LLVM_VERSION_SUFFIX from created shared library names

thieta added a comment. If this fixes OpenBSD it looks fine I think. But I wonder if we shouldn't just do this if we are on OpenBSD, changing the SOVERSION has been fraught with problems before since people have scripts that expect certain layouts. Without having more tests and more investigati

[PATCH] D139436: [C2x] Relaxing requirements for va_start

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:7356 +// in C before C2x. Complain and provide the fix. We do not support +// this as an extension in earlier C language modes. +if (getLangOpts().C2x) Is this rig

[PATCH] D139436: [C2x] Relaxing requirements for va_start

cor3ntin added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else Yeah, i really think there should be some king of diagnostic here.

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 480513. dgoldman marked 2 inline comments as done. dgoldman added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/c

[PATCH] D139395: Add support for integer types normalization

rcvalle added a comment. FYI, I'll still add (hopefully today) documentation for the new `-fsanitize-cfi-icall-normalize-integers` option and compression for these types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.l

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman marked 4 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else cor3ntin wrot

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480518. massberg added a comment. Instead of lokking if there is a pack expansion pass the already computed information whether we have a by ref or a by copy type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

MaskRay added a comment. In GCC, a `*-linux*` triple (this applies to musl as well) gets `c_target_objs="${c_target_objs} glibc-c.o"` from `gcc/config.gcc`. `"stdc-predef.h"` is defined in `glibc-c.cc`. There is no `musl-c.cc`. Even if musl does provide `stdc-predef.h` and GCC configured on `*-li

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman updated this revision to Diff 480522. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. - Rolled back parsing changes as they were not needed - Moved the diagnostic from common kinds to sema kinds because it's now solel

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd updated this revision to Diff 480523. compnerd added a comment. Add a test case for member data. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138514/new/ https://reviews.llvm.org/D138514 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaStmtAsm.cp

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This makes `-mmcu=` available for non-AVR targets, which is not right. Even for AVR, if this is a plain alias, is this really necessary? Usually having more than one aliases for one

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 480524. dgoldman marked 2 inline comments as done. dgoldman added a comment. Use raw string literal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-to

[PATCH] D139436: [C2x] Relaxing requirements for va_start

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7230 + Val && LangOpts.C2x && *Val == 0) +return false; I see below that we still set the return type of hte call to Void. Do we wnat to keep that line, or at least, move i

[PATCH] D139436: [C2x] Relaxing requirements for va_start

erichkeane added a comment. Give others an extra chance to look at this, but other than the 1 concern, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139436/new/ https://reviews.llvm.org/D139436 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D139436: [C2x] Relaxing requirements for va_start

erichkeane added inline comments. Comment at: clang/test/C/C2x/n2975.c:49 + +void foo(int a...); // expected-error {{C requires a comma prior to the ellipsis in a variadic function type}} erichkeane wrote: > . Was going to complain about the error message here

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480528. VitaNuo added a comment. Add handling of nested types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added inline comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Mordante wrote: > Is `__cplusplus-0` inten

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480530. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139436: [C2x] Relaxing requirements for va_start

cor3ntin added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else aaron.ballman wrote: > cor3ntin wrote: > > Yeah, i really think th

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3974745 , @Endill wrote: >> I think the relevant change from p1787 is to dcl.fct.default p4, >> specifically: >> >>> ... Declarations that inhabit different scopes have completely distinct >>> sets of default arguments

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. In D138511#3971913 , @rjmccall wrote: > Please don't ping every day. We haven't lost track of your patch, we're just > busy reviewing other things. > > This seems reasonable to me. Thanks very much for your review @rjmccall !

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd updated this revision to Diff 480531. compnerd added a comment. Update to avoid use of the `-0` trick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 Files: clang/lib/Headers/stdatomic.h Index: clang/lib/Headers/stdatomic.h =

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman marked 4 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else cor3ntin wrot

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. I opened #59363 on bug tracker. What should I do about this patch then? I believe availability `no` should come with a failing test. Should I include example from [over.match.best]/4 as another example in the test? Re

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman updated this revision to Diff 480533. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Update based on review feedback. - Removed code setting the return type for the builtin (it's already set elsewhere) - Added test coverage verifying the return type

[clang-tools-extra] 3c255f6 - Process: convert Optional to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-06T09:56:14-08:00 New Revision: 3c255f679c90e332fe0b38b09d5811a64db3f0f6 URL: https://github.com/llvm/llvm-project/commit/3c255f679c90e332fe0b38b09d5811a64db3f0f6 DIFF: https://github.com/llvm/llvm-project/commit/3c255f679c90e332fe0b38b09d5811a64db3f0f6

[PATCH] D139436: [C2x] Relaxing requirements for va_start

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaChecking.cpp:7230 + Val && LangOpts.C2x && *Val == 0) +return false; aaron.ballman wrote: > erichkeane

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480536. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-

[PATCH] D139154: [clang-doc] Add template support

brettw marked an inline comment as done. brettw added a comment. New patch up. Comment at: clang-tools-extra/test/clang-doc/single-file.cpp:19 // CHECK-NEXT:DefLocation: -// CHECK-NEXT: LineNumber: [[@LINE-8]] +// CHECK-NEXT: LineNumber: 11 // CHECK-NE

[PATCH] D139429: [clang] Add test for CWG418

shafik added a subscriber: aaron.ballman. shafik added a comment. In D139429#3975028 , @Endill wrote: > I opened #59363 on bug > tracker. > What should I do about this patch then? I believe availability

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for working on this! The changes LGTM. I've been trying to figure out if there's a way we can add test coverage for this change, but I'm really not coming up with much. Ho

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480539. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante accepted this revision. Mordante added a comment. LGTM after addressing @aaron.ballman's comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

hans updated this revision to Diff 480538. hans marked 2 inline comments as done. hans added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139428/new/ https://reviews.llvm.org/D139428 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/vector.cpp I

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

hans added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:7109 + case BuiltinType::Char8: +return getIntegerRank(CharTy.getTypePtr()); + case BuiltinType::Char16: tahonermann wrote: > This should technically be `UnsignedCharTy` though it probably

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change: - Modifies the ACLE code to allow the new

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson created this revision. probinson added reviewers: uweigand, Kai. Herald added a project: All. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Part of the project to eliminate special handling for triple

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 2 inline comments as done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1624 + if (LHS.isEmpty() || RHS.isEmpty()) +return RangeFactory.getEmptySet(); + steakhal wrote: > This branch is uncove

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added a reviewer: sdesmalen. lenary added a subscriber: sdesmalen. lenary added a comment. @sdesmalen adding you as I've moved around the custom lowering of `INTRINSIC_VOID` to be its own function, and as we need to handle it for `@llvm.arm.prefetch` all the time, it's no longer condition

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 480542. manas marked an inline comment as done. manas added a comment. Add more tests for complete coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: cla

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have). If there are suffixes, I'll happily

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

tschuett added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + I believe you

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + tschuett wrote:

[clang] 51f1ae5 - [clangd] Add new IncludeDirective to IncludeHeaderWithReferences

Author: David Goldman Date: 2022-12-06T13:47:07-05:00 New Revision: 51f1ae52b0c92a9783e7df328d05b1f95dca74d1 URL: https://github.com/llvm/llvm-project/commit/51f1ae52b0c92a9783e7df328d05b1f95dca74d1 DIFF: https://github.com/llvm/llvm-project/commit/51f1ae52b0c92a9783e7df328d05b1f95dca74d1.diff

[clang] fc46d6e - [clang][Tooling] Add support for generating #import edits

Author: David Goldman Date: 2022-12-06T13:47:07-05:00 New Revision: fc46d6e67fab06d54c8948ebf959d62984116bc3 URL: https://github.com/llvm/llvm-project/commit/fc46d6e67fab06d54c8948ebf959d62984116bc3 DIFF: https://github.com/llvm/llvm-project/commit/fc46d6e67fab06d54c8948ebf959d62984116bc3.diff

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51f1ae52b0c9: [clangd] Add new IncludeDirective to IncludeHeaderWithReferences (authored by dgoldman). Changed prior to commit: https://reviews.ll

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc46d6e67fab: [clang][Tooling] Add support for generating #import edits (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. @shafik does this imply that example from [over.match.best]/4 should be included in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 ___

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

tschuett added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + lenary wrote:

[clang] 481bb44 - [SystemZ] Emit a .gnu_attribute for an externally visible vector abi.

Author: Jonas Paulsson Date: 2022-12-06T12:53:40-06:00 New Revision: 481bb44baab5ce7a005b7d7eee6cafbde672695c URL: https://github.com/llvm/llvm-project/commit/481bb44baab5ce7a005b7d7eee6cafbde672695c DIFF: https://github.com/llvm/llvm-project/commit/481bb44baab5ce7a005b7d7eee6cafbde672695c.diff

[PATCH] D105067: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jonpa marked an inline comment as done. Closed by commit rG481bb44baab5: [SystemZ] Emit a .gnu_attribute for an externally visible vector abi. (authored by jonpa). Hera

[PATCH] D139154: [clang-doc] Add template support

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is basically LGTM. There are a few comments I think could be phrased a bit more clearly, but otherwise are more or less fine. Comment at: clang-tools-extra/clang-

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:17-19 +// Because the analysis revolves around variables and their types, we'll need to +// track uses of variables (aka DeclRefExprs). +using DeclUseList = SmallVector; No

[libunwind] 8482e95 - [libunwind] Use .irp directives. NFC

Author: Fangrui Song Date: 2022-12-06T19:05:04Z New Revision: 8482e95f75d02227fbf51527680c0b5424bacb69 URL: https://github.com/llvm/llvm-project/commit/8482e95f75d02227fbf51527680c0b5424bacb69 DIFF: https://github.com/llvm/llvm-project/commit/8482e95f75d02227fbf51527680c0b5424bacb69.diff LOG:

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBlock.h:97 void invokeCtor() { -std::memset(data(), 0, getSize()); +std::memset(rawData(), 0, Desc->getAllocSize()); if (Desc->CtorFn) tbaeder wrote: > aaron.ballman wrote

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3975223 , @Endill wrote: > @shafik does this imply that example from [over.match.best]/4 should be > included in this patch? Yes, I believe we should. We are only conforming if we get all of the cases correct. Repos

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

aaron.ballman added a comment. Generally LGTM but I'd appreciate a second pass by @rnk in case I've missed something. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8845-8846 let CategoryName = "Inline Assembly Issue" in { + def err_asm_pmf_in_input +: Erro

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will be

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480560. brettw marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-

[PATCH] D139154: [clang-doc] Add template support

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:119-123 + // This variant (that takes no qualified name parameter) uses the Name as the + // QualName (very useful in unit tests to reduce verbosity). This can't use + // the empty string as

[PATCH] D139154: [clang-doc] Add template support

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:205 + + // The literal contents of the code for that specifies this template parameter + // for this declaration. Typical values will be "class T" and

[clang] f926826 - [SystemZ] Add "REQUIRES: systemz-registered-target" on test.

Author: Jonas Paulsson Date: 2022-12-06T13:38:48-06:00 New Revision: f926826c2e836b09cd2517775758f373bbc330bf URL: https://github.com/llvm/llvm-project/commit/f926826c2e836b09cd2517775758f373bbc330bf DIFF: https://github.com/llvm/llvm-project/commit/f926826c2e836b09cd2517775758f373bbc330bf.diff

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

aaron.ballman added a comment. Generally looks correct to me. Comment at: clang/lib/AST/Interp/PrimType.h:65 +constexpr bool aligned(size_t Size) { return Size == align(Size); } +static_assert(aligned(sizeof(void *))); I think `Size` should be something more

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom created this revision. tuliom added projects: clang, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. tuliom requested review of this revision. Herald added a subscriber: MaskRay. When -mabi=ieeelongdouble is enabled by default, libc++ does not support -mabi=ibmlong

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:161 + case HIF_Textual: { +assert(!DepOpts.HeaderIncludeFiltering && + "header filtering is currently always disabled when output format is" jansvoboda11 wrote: >

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139416/new/ https://reviews.llvm.org/D139416 __

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 480574. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a subscriber: eli.friedman. zahiraam added a comment. @eli.friedman Thanks. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This minimal patch LGTM. Comment at: llvm/lib/IR/DIBuilder.cpp:159 - assert(((Lang <= dwarf::DW_LANG_Fortran08 && Lang >= dwarf::DW_LANG_C89) || + assert(((Lang <= dwar

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

dblaikie added a comment. In D137059#3973096 , @iains wrote: > In D137059#3973016 , @ben.boeckel > wrote: > >> In D137059#3934448 , @dblaikie >> wrote: >> >>> I'm still

[clang] cd95d79 - [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

Author: Félix Cloutier Date: 2022-12-06T13:08:18-08:00 New Revision: cd95d7998c1dd30c6353aeca2686697287cb0443 URL: https://github.com/llvm/llvm-project/commit/cd95d7998c1dd30c6353aeca2686697287cb0443 DIFF: https://github.com/llvm/llvm-project/commit/cd95d7998c1dd30c6353aeca2686697287cb0443.diff

[PATCH] D137603: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd95d7998c1d: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions (authored by fcloutier). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1376

[clang] 3c312e4 - DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

Author: David Blaikie Date: 2022-12-06T21:11:08Z New Revision: 3c312e48f325c1b1ee11404ee6cfa08ee00037b0 URL: https://github.com/llvm/llvm-project/commit/3c312e48f325c1b1ee11404ee6cfa08ee00037b0 DIFF: https://github.com/llvm/llvm-project/commit/3c312e48f325c1b1ee11404ee6cfa08ee00037b0.diff LOG:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c312e48f325: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions (authored by dblaikie). Changed prior to commit: https://revi

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. LGTM. I agree with the commentary in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list cfe-comm

[clang] fe21126 - [Windows] Convert tests to check 'target=...'

Author: Paul Robinson Date: 2022-12-06T13:15:48-08:00 New Revision: fe2112611258f9a16f101d642f3dfe7a47a161d7 URL: https://github.com/llvm/llvm-project/commit/fe2112611258f9a16f101d642f3dfe7a47a161d7 DIFF: https://github.com/llvm/llvm-project/commit/fe2112611258f9a16f101d642f3dfe7a47a161d7.diff

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480596. ayzhao marked 3 inline comments as done. ayzhao added a comment. restore original diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/do

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/test/CXX/class/class.compare/class.spaceship/p1.cpp:106 Cmp() <=> Cmp(), // expected-note-re {{in defaulted three-way comparison operator for '{{.*}}Cmp<{{.*}}G2>' first required here}}j - // expected-error@#cmp {{no ma

<    1   2   3   >