tschuett added inline comments.
================ Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + ---------------- lenary wrote: > tschuett wrote: > > I believe you also have to turn on GISL: `-global-isel`. > > > > See test in https://reviews.llvm.org/D109827. > I'm not sure this is necessary, global isel is enabled at O0 on AArch64, and > e.g. RegBankSelect appears in the output of `llc -mtriple=aarch64 > -mattr=+v8.9a -O0 < llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll > -debug-pass=Structure -o arm64-prefetch-new.ll` > > Would you find it clearer as: > ``` > ; RUN: llc -mtriple=aarch64 -mattr=+v8.9a --global-isel=0 < %s | FileCheck %s > ; RUN: llc -mtriple=aarch64 -mattr=+v8.9a --global-isel=1 > --global-isel-abort=1 < %s | FileCheck %s > ``` > ? I didn't know or forgot. I believe `--global-isel=1` makes the intent clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
