tahonermann requested changes to this revision.
tahonermann added a comment.
This revision now requires changes to proceed.
The direction of the changes looks right. I noted a couple of minor
considerations.
================
Comment at: clang/lib/AST/ASTContext.cpp:7109
+ case BuiltinType::Char8:
+ return getIntegerRank(CharTy.getTypePtr());
+ case BuiltinType::Char16:
----------------
This should technically be `UnsignedCharTy` though it probably doesn't matter.
================
Comment at: clang/test/SemaCXX/vector-bool.cpp:93-104
+
+// Don't crash due to missing integer ranks.
+char8_t v1 __attribute__((vector_size(16)));
+char16_t v2 __attribute__((vector_size(16)));
+char32_t v3 __attribute__((vector_size(16)));
+wchar_t v4 __attribute__((vector_size(16)));
+void triggerIntegerRankCheck() {
----------------
This source file purports to be specific to vectors with bool element type.
These additions look like they would be more at home in
`clang/test/SemaCXX/vector.cpp`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139428/new/
https://reviews.llvm.org/D139428
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
