[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added subscribers: craig.topper, andrew.w.kaylor. erichkeane added a comment. In D108643#3000193 , @rjmccall wrote: > In D108643#2999776 , @erichkeane > wrote: > >>> ! In D108643#2965852

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372531. cchen added a comment. Remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClaus

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372528. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - set `GlobalOpt` parameter to false by default to disallow alias elimination when the options EarlyInlineAll and EnableFunctionCalls are true and false, respectively. R

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5069 // where aliases aren't supported. - if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); gandh

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > So, SmalVector has a pop_back_val which we could use to verify the properties > are the ones we expect. However, we would need to first put

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#2999688 , @uweigand wrote: > Looking at the common code parts, it seems the behavior of MM_GOFF is > actually identical to MM_ELF. Is this correct? If so, do we really need a > different format type here? At a f

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins. Range checking is done in SemaCheck

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372541. quinnp added a comment. Removing an extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/SemaChec

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:1 +#include "clang/Basic/Sarif.h" +#include "clang/Basic/LangOptions.h" lattner wrote: > THis nees the standard header boilerplate per the coding standards doc Ack, didn't grok the "all source

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372542. vaibhav.y added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h clang/includ

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372543. vaibhav.y added a comment. Fixup name of class defined in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/S

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372548. vaibhav.y added a comment. Format clang/lib/Basic/Sarif.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h cla

[PATCH] D109128: [VFS] Use original path when falling back to external FS

vsapsai added a comment. In D109128#2999846 , @dexonsmith wrote: > In D109128#2997588 , @JDevlieghere > wrote: > >> Keith and I discussed this offline. My suggestion was to do the following: >> >> 1. Check the o

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + sfertile wrote: > The code-gen for int and float

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + ZarkoCA wrote: > sfertile wrote: > > The code-ge

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 372563. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. I'm a little bit confused here. Where is the speed-up coming from? Is it because ObjCMethodList for `init` not being serialized? I'm asking because right now I don't see how `seen` helps with that. My current understanding is that `Sema::addMethodToGlobalList` is too ex

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#3000374 , @vsapsai wrote: > In D109128#2999846 , @dexonsmith > wrote: > >> In D109128#2997588 , @JDevlieghere >> wrote: >> >>> Kei

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INC

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372566. daltenty added a comment. - Update check patttern to allow windows directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Dr

[PATCH] D106876: Remove non-affecting module maps from PCM files.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please apply the lint suggestions; otherwise, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 _

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3000223 , @erichkeane wrote: > In D108643#3000193 , @rjmccall > wrote: > >> In D108643#2999776 , @erichkeane >> wrote: >> ! In

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372570. daltenty added a comment. - Fix additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/li

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. In D108643#3000540 , @rjmccall wrote: > The question is whether you can rely on extension at places that receive an > arbitrary ABI-compatible value, like function parameters or loads. If nobody > who receives such a value c

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372584. cchen added a comment. Fix based on suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > jdoerfert wrote: > > So, SmalVector has a pop_back_val which we could use to verify the > > properties are the ones we expect. However, we woul

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

wenlei added a comment. > It isn't common when the program is built with the frame pointer omission > disabled, but can still happen with third-party static libs built with frame > pointer omitted. Did you mean disabled -> enabled? > This could happen to frame-pointer-based unwinding and the c

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added a comment. Great! This should work. Though we need actual tests ;) I also provided you with two minor edits below to make it easier to read, no functional change though. Comment at: clang/lib/Sema/SemaOpenMP.cpp:737-738 +if (ScopeEntry) + std::copy(Tr

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3000469 , @vsapsai wrote: > I'm a little bit confused here. Where is the speed-up coming from? Is it > because ObjCMethodList for `init` not being serialized? I'm asking because > right now I don't see how `seen` helps w

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei accepted this revision. wenlei added a comment. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw updated this revision to Diff 372595. woodruffw added a comment. Increase the context for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 Files: clang/lib/Frontend/ASTConsumers.cpp

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz updated this revision to Diff 372597. rmaz added a comment. Updated to use a GlobalMethods struct which contains the global method lists as well as the sets used to de-duplicate added methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10963

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz updated this revision to Diff 372598. rmaz added a comment. update to fix lint warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaC

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added a comment. In D109638#3000682 , @wenlei wrote: >> It isn't common when the program is built with the frame pointer omission >> disabled, but can still happen with third-party static libs built with frame >> pointer omitted. > > Did you mean di

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372604. hoy added a comment. Addressing Wenlei's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/ https://reviews.llvm.org/D109638 Files: llvm/test/tools/llvm-profgen/Inputs/cs-invalid-ret-addr

[clang] 299b5d4 - [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

Author: Hongtao Yu Date: 2021-09-14T18:13:29-07:00 New Revision: 299b5d420df15fafc9936bc24995f6cd6ad325be URL: https://github.com/llvm/llvm-project/commit/299b5d420df15fafc9936bc24995f6cd6ad325be DIFF: https://github.com/llvm/llvm-project/commit/299b5d420df15fafc9936bc24995f6cd6ad325be.diff LO

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299b5d420df1: [CSSPGO] Enable pseudo probe instrumentation in O0 mode. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109799: [RISCV] add Half-precision test for load/store

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, r

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm except two nits. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address : InvalidReturnAddresses

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372615. hoy added a comment. Updating D109638 : [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added inline comments. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address : InvalidReturnAddresses) { wenlei wrote: > nit: emitAccumulatedWarnings -> warnTruncatedStack Makes sense.

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. The test is still failing on Windows, see e.g. http://45.33.8.238/win/45205/step_8.txt or https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8836086236638553313/+/u/package_clang/stdout?format=raw or https://lab.llvm.org/buildbot/#/builders/123/builds/607

[clang-tools-extra] 626586f - Re-Revert "clang-tidy: introduce readability-containter-data-pointer check"

Author: Nico Weber Date: 2021-09-14T22:27:59-04:00 New Revision: 626586fc253c6f032aedb325dba6b1ff3f11875e URL: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e DIFF: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e.diff LO

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3000556 , @erichkeane wrote: > In D108643#3000540 , @rjmccall > wrote: > >> > > I don't work on the microcode, it is just what I was told when we asked about > this. SO un

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

rjmccall added a comment. Hmm. I think "v-tables are in the address space of the object pointer" is not a good assumption. Probably this ought to be determined by the C++ ABI for the target. In principle it could even be class-specific, but I think we can start by assuming it's universal.

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

NoQ added a comment. In D105756#2990495 , @mizvekov wrote: > Hello! Thanks for reporting this. Thanks for fixing! In D105756#2990495 , @mizvekov wrote: > The double implicit lvalue-to-rvalue cast is an unfortun

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999677 , @Szelethus wrote: > rGfb4d590a622f4031900516360c07ee6ace01c5e6 > should > sort this out! Yes now it works. Thank you! Repository: rG

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. 1. modf works now. 2. if I modify the complile.sh clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp rm -f libmylib.a ar qc libmylib.a classA.o ranlib libmylib.a clang++ -fopenmp -fopenmp-targets=nvptx64 main.cpp -L. -lmylib ./a.out doesn't work. I think

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0057c7185d1c: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. (authored by hoy). Repository: rG LLVM Github Monorepo C

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan added a comment. Yes, the said invalid code may get reformatted. However, the main purpose of this patch is to fix the efficiency issue as nested function declarators would no longer be checked for possible K&R C function definitions. Repository: rG LLVM Github Monorepo CHANGES SINC

<    1   2