[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

[Hongtao Yu via Phabricator via cfe-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772
 
+void PerfReaderBase::emitAccumulatedWarnings() {
+  for (auto Address : InvalidReturnAddresses) {
----------------
wenlei wrote:
> nit: emitAccumulatedWarnings -> warnTruncatedStack
Makes sense. I was making this cover all warnings for future use. But sounds 
good to stick with truncated stack for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109638/new/

https://reviews.llvm.org/D109638

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits