jdoerfert added a comment.
Great! This should work. Though we need actual tests ;)
I also provided you with two minor edits below to make it easier to read, no
functional change though.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:737-738
+ if (ScopeEntry)
+ std::copy(Traits.begin(), Traits.end(),
+ std::back_inserter(ConstructTraits));
+ else
----------------
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:740
+ else
+ for (auto RI = Traits.rbegin(), RE = Traits.rend(); RI != RE; ++RI) {
+ llvm::omp::TraitProperty Top = ConstructTraits.pop_back_val();
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109635/new/
https://reviews.llvm.org/D109635
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
