wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.
lgtm except two nits.
================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772
+void PerfReaderBase::emitAccumulatedWarnings() {
+ for (auto Address : InvalidReturnAddresses) {
----------------
nit: emitAccumulatedWarnings -> warnTruncatedStack
================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:774
+ for (auto Address : InvalidReturnAddresses) {
+ WithColor::warning() << "Invalid return address "
+ << format("%" PRIx64, Address) << "\n";
----------------
Nit: make the message more meaningful. `Truncated stack sample due to invalid
return address at 0xabcd, likely caused by frame pointer omission.`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109638/new/
https://reviews.llvm.org/D109638
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
