[PATCH] D21058: [Clang][AVX512][BUILTIN]Adding missing intrinsics srl and sll

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21058 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512bwintrin.h test/CodeGen/avx512bw-builtins.c Index: test/CodeGe

Re: [PATCH] D20467: [include-fixer] Mention more details in the document.

hokein updated this revision to Diff 59838. hokein added a comment. Fix typo. http://reviews.llvm.org/D20467 Files: docs/ReleaseNotes.rst docs/include-fixer.rst Index: docs/include-fixer.rst === --- docs/include-fixer.rst +++

[clang-tools-extra] r271989 - [include-fixer] Mention more details in the document.

Author: hokein Date: Tue Jun 7 02:50:48 2016 New Revision: 271989 URL: http://llvm.org/viewvc/llvm-project?rev=271989&view=rev Log: [include-fixer] Mention more details in the document. Reviewers: bkramer Subscribers: Eugene.Zelenko, cfe-commits, ioeric Differential Revision: http://reviews.ll

Re: [PATCH] D20467: [include-fixer] Mention more details in the document.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271989: [include-fixer] Mention more details in the document. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20467?vs=59838&id=59839#toc Repository: rL LLVM http://reviews.l

[PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D21059 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp test/clang-tidy/misc-definitions-in-headers-cxx11.hpp Index: test/clang-tidy/misc-definitions-in-headers-

[PATCH] D21060: [AVX512] Emit select instruction instead of using x86 specific instrinsics.

igorb created this revision. igorb added reviewers: craig.topper, delena. igorb added a subscriber: cfe-commits. igorb set the repository for this revision to rL LLVM. [AVX512] Emit select instruction instead of using x86 specific instrinsics. This will allow us to remove the x86 instrinics from

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

bkramer added a comment. IMO a 20% release binary size increase is not acceptable. Is there a way to compile in support only if it's actually used? Maybe some constexpr or template magic? http://reviews.llvm.org/D20382 ___ cfe-commits mailing list

Re: [PATCH] D21058: [Clang][AVX512][BUILTIN]Adding missing intrinsics srl and sll

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

bkramer added a comment. Nice! Can we somehow make the user not press enter after putting in the number? getchar() maybe? http://reviews.llvm.org/D21019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one comment. Comment at: test/clang-tidy/misc-definitions-in-headers-cxx11.hpp:6 @@ +5,3 @@ + +int f() = delete; +// CHECK-NOT: [misc-definitions-in-headers] -

Re: [PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

hokein updated this revision to Diff 59843. hokein marked an inline comment as done. hokein added a comment. Use the existing test file. http://reviews.llvm.org/D21059 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp test/clang-tidy/misc-definitions-in-headers.hpp Index: test/clang-tid

Re: [PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271991: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21059?vs=59843&id=59845#toc Repository: rL LLV

[clang-tools-extra] r271991 - [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

Author: hokein Date: Tue Jun 7 03:55:38 2016 New Revision: 271991 URL: http://llvm.org/viewvc/llvm-project?rev=271991&view=rev Log: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for fixing the copy-paste failures! Do you need me to commit the patch for you? Comment at: clang-tidy/tool/clang-tidy-diff.py:42 @@ -41,3 +41,3 @@

Re: [PATCH] D21021: [Clang][AVX512][BuiltIn]Adding intrinsics move_{sd|ss} to clang

delena added inline comments. Comment at: lib/Headers/avx512fintrin.h:9124 @@ +9123,3 @@ +{ + return (__m128) __builtin_ia32_movss_mask ((__v4sf) __A, (__v4sf) __B, + (__v4sf) __W, please try the following: if (__U) return __builtin_shuffle(A, B,

[clang-tools-extra] r271992 - [clang-tidy] readability-identifier-naming - Support for Type Aliases

Author: alexfh Date: Tue Jun 7 04:11:19 2016 New Revision: 271992 URL: http://llvm.org/viewvc/llvm-project?rev=271992&view=rev Log: [clang-tidy] readability-identifier-naming - Support for Type Aliases Summary: Added support for Type Alias declarations. Reviewers: alexfh Subscribers: cfe-commi

Re: [PATCH] D20856: [clang-tidy] readability-identifier-naming - Support for Type Aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL271992: [clang-tidy] readability-identifier-naming - Support for Type Aliases (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D20856?vs=59189&id=59847#toc Repository: rL LLVM

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

hokein added inline comments. Comment at: test/clang-tidy/misc-misplaced-const.c:17 @@ +16,3 @@ + const ip i3 = 0; + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified typedef type; results in the type being 'int *const' instead of 'const int *'

Re: [PATCH] D20966: [include-fixer] Add the missing header to the file where the unidentified symbol comes from.

hokein added inline comments. Comment at: include-fixer/IncludeFixer.cpp:104 @@ -103,3 @@ -// class Bar; -// Foo foo; -// bkramer wrote: > Does this patch do the right thing for the test case in the comment? > Otherwise we'll try add includes to s

r271995 - Reapply [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

Author: ikudrin Date: Tue Jun 7 05:07:51 2016 New Revision: 271995 URL: http://llvm.org/viewvc/llvm-project?rev=271995&view=rev Log: Reapply [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. We have an assertion failure if, for example, the defini

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

ioeric updated this revision to Diff 59858. ioeric added a comment. - fixed a bug with index. http://reviews.llvm.org/D21019 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-fixer.py === -

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

ioeric added a comment. As per our offline discussion, `getchar()` does not work with options with more than 2 digits (e.g. index number > 9). I'll keep it as it is now until we come up with a better solution. http://reviews.llvm.org/D21019 ___ cf

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 59857. JamesReynolds added a comment. Thanks Eugene, I've added a comment into docs/ReleaseNotes.rst to say this is in. I'll create a BugZilla account to update PR. I've also added a new test and code to create FixIts for uses of the Macros as well as

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. In http://reviews.llvm.org/D18035#450258, @rsmith wrote: > Yes, I definitely want us to implement this for GCC compatibility. And now > that we have a specification for this feature, we can evaluate whether this > is doing the right thing. On that basis: > > I st

[PATCH] D21066: Pass MCSubtargetInfo instead of CPU and Triple to createMCAsmBackend

aturetsk created this revision. aturetsk added reviewers: bruno, echristo, ahatanak, RKSimon. aturetsk added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Pass MCSubtargetInfo instead of CPU and Triple to AsmBackend in order to be able to reach feature bits there (e.g. for ck

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman marked an inline comment as done. Comment at: test/clang-tidy/misc-misplaced-const.c:17 @@ +16,3 @@ + const ip i3 = 0; + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified typedef type; results in the type being 'int *const' instead

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman updated this revision to Diff 59868. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback: - Added another two test cases (one for templates and one for const binding to the right of the typedef type). - Updated test cases

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In http://reviews.llvm.org/D21036#450106, @sbenza wrote: > I think this would be more interesting with macros. > Eg triggering in code like this: > > #define FOO(type, op) const type& X = op() > FOO(int*, bar);

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

hokein added inline comments. Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19 @@ -18,3 +18,3 @@ /// Finds and fixes header guards that do not adhere to LLVM style. class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck { hokein wrote: > madsravn wrote:

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg then. http://reviews.llvm.org/D21019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D21022: [ARM] Fix linker emulation for arm 32 big endian

spetrovic updated this revision to Diff 59870. spetrovic marked an inline comment as done. spetrovic added a comment. Comment addressed. http://reviews.llvm.org/D21022 Files: lib/Driver/Tools.cpp test/Driver/linux-ld.c Index: test/Driver/linux-ld.c =

[clang-tools-extra] r272004 - [include-fixer] try to make vim header selection more friendly.

Author: ioeric Date: Tue Jun 7 07:21:43 2016 New Revision: 272004 URL: http://llvm.org/viewvc/llvm-project?rev=272004&view=rev Log: [include-fixer] try to make vim header selection more friendly. Summary: use 'input()' to get user's input so that we can support more options. Reviewers: hokein,

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272004: [include-fixer] try to make vim header selection more friendly. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21019?vs=59858&id=59871#toc Repository: rL LLVM http:/

Re: [PATCH] D18761: [mips] Enable IAS by default for 32-bit MIPS targets (O32).

dsanders closed this revision. dsanders added a comment. This has already been committed. I'm not sure why it didn't auto-close. http://reviews.llvm.org/D18761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

dsanders created this revision. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D21069: [mips] Require that ABI's are passed in the triple within LLVM.. Herald added subscribers: srhines, danalbert, tberghammer. 'clang -cc1' and 'clang -cc1as' will mutate the triple to acco

[PATCH] D21071: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders created this revision. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'. Herald added subscribers: dschuff, jfb. This stops cases such as '-target mips-linux

Re: [PATCH] D21071: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders abandoned this revision. dsanders added a comment. Part of this patch is missing. I'll repost it soon. http://reviews.llvm.org/D21071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders created this revision. dsanders added subscribers: jfb, dschuff, cfe-commits. dsanders added a dependency: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'. Herald added subscribers: sdardis, srhines, danalbert, tberghammer. Thi

Re: [PATCH] D21023: [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r272012 - [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang

Author: mzuckerm Date: Tue Jun 7 09:00:20 2016 New Revision: 272012 URL: http://llvm.org/viewvc/llvm-project?rev=272012&view=rev Log: [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang Differential Revision: http://reviews.llvm.org/D21014 Modified: cfe/trunk/incl

Re: [PATCH] D21014: [Clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL272012: [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D21014?vs=59697&id=59882#toc Repository:

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

hintonda added a comment. Thanks Aaron. If you could commit for me, I'd appreciate it. Thanks again... http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv abandoned this revision. erikjv added a comment. This will give errors about unbalanced #if/#endif for header guards. http://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv abandoned this revision. erikjv added a comment. Wrong patch http://reviews.llvm.org/D21074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau updated this revision to Diff 59887. pgousseau added a comment. Following Bruno's comment: - Remove call to sleep using touch -m -a -t http://reviews.llvm.org/D20867 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendOptions.h lib/Frontend/CompilerInvocati

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau added a comment. > > On Linux, if the timestamp of a header file, included in the pch, is > > modified, then including the pch without regenerating it causes a fatal > > error, which is reasonable. > > > On Windows the check is ifdefed out, allowing the compilation to continue > >

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic added inline comments. Comment at: test/SemaOpenCL/images-typedef.cl:40 @@ +39,3 @@ + myWrite(img); // expected-error {{passing 'img1d_ro_default' (aka '__read_only image1d_t') to parameter of incompatible type '__write_only image1d_t'}} +} + No, but w

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

It seems Phabricator did not picked up Richard's message so I have manually copied and replied to it via Phabricator's web interface. Cheers, Pierre On 6 June 2016 at 21:53, Richard Smith wrote: > On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits < > cfe-commits@lists.llvm.org> w

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. @mclow.lists, @ericwf: Ping. @bcraig: I guess you wouldn't be able to let this through on your own? (in case if there isn't much interest in this functionality from others). Eric might be away though (didn't see many emails from him), so I'll hold off for now. / Asiri

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

sugak added a comment. Thank you for the review! I need someone to commit this for me :) http://reviews.llvm.org/D21050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272018 - Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch.

Author: marshall Date: Tue Jun 7 10:49:39 2016 New Revision: 272018 URL: http://llvm.org/viewvc/llvm-project?rev=272018&view=rev Log: Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch. Modified: libcxx/trunk/test/std/containers/associative/map/map.sp

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 272018 http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

mclow.lists added a comment. Some nits while reading this. More to come. Also, I don't see how this can be retargeted "at runtime"; are you implying that someone can choose at program launch time what threading system to use? How could that work given (say) a constexpr constructor for a mutex t

[PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, dcoughlin, Alexander_Droste. dcoughlin added a subscriber: cfe-commits. (Cloning the revision for the ASan issue since the old one is closed and can't be re-opened) This patch adds a static analysis checker to verify the corr

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic updated this revision to Diff 59890. asavonic added a comment. - Cleanup images-typedef.cl - Fix typo in SemaType.cpp - Change diagnostic: error when access qualifier applied to a typedef http://reviews.llvm.org/D20948 Files: include/clang/Basic/Attr.td include/clang/Basic/Diagnost

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic updated this revision to Diff 59893. asavonic marked 3 inline comments as done. asavonic added a comment. - Fix images-typedef.cl for OpenCL 2.0 http://reviews.llvm.org/D20948 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Attribu

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin added a comment. Alexander, When I committed your patch, the AddressSanitizer bots found a memory corruption issue so I reverted it. This will need to be fixed before we can commit the patch. Since Phabricator automatically closed http://reviews.llvm.org/D12761, I've created a new re

Re: 3.8 Merge Request: r259776

Hi Richard, Is this OK for the 3.8 branch? reviews.llvm.org/rL259776 -Tom On Mon, May 30, 2016 at 11:35:04AM +, Hahnfeld, Jonas wrote: > Assuming I got it right... > > > -Original Message- > > From: Alexey Bataev [mailto:a.bat...@hotmail.com] > > Sent: Monday, May 30, 2016 1:31 PM

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a subscriber: STL_MSFT. rmaprath added a comment. In http://reviews.llvm.org/D20328#451178, @mclow.lists wrote: > Also, I don't see how this can be retargeted "at runtime"; are you implying > that someone can choose at program launch time what threading system to use? Yup, users

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#451197, @rmaprath wrote: > In http://reviews.llvm.org/D20328#451178, @mclow.lists wrote: > > > Also, I don't see how this can be retargeted "at runtime"; are you implying > > that someone can choose at program launch time what threading

Re: 3.8 Merge Request: r259776

It's larger than I'd like for a merge onto the branch, but yes, it looks OK. On 7 Jun 2016 9:20 a.m., "Tom Stellard via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > Is this OK for the 3.8 branch? > > reviews.llvm.org/rL259776 > > -Tom > > On Mon, May 30, 2016 at 11:35:04AM

RE: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

[Asiri Rathnayake] > The `constexpr` mutex constructor is apparently also a > pain point on windows [1], I'm sure @STL_MSFT knows more about it. That's because of MSVC-specific issues, where we need to dynamically switch between WinAPI and ConcRT implementations depending on whether the end user'

[PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

christof created this revision. christof added reviewers: vitalybuka, chapuni. christof added a subscriber: cfe-commits. christof set the repository for this revision to rL LLVM. The asan tests should only run on builds that have LLVM_USE_SANITIZER set. The feature 'asan' reflects this and is req

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin added a comment. Here is the ASan report. It looks to me like the issue is that MPIChecker is holding on a reference to a clang::ento::BugReporter after the lifetime of the BugReporter has ended. The BugReporter lives in ExprEngine and the analyzer creates a new ExprEngine for each to

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#451210, @STL_MSFT wrote: > [Asiri Rathnayake] > > > The `constexpr` mutex constructor is apparently also a > > > pain point on windows [1], I'm sure @STL_MSFT knows more about it. > > > That's because of MSVC-specific issues, where we n

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

On 7 Jun 2016 7:52 a.m., "pierre gousseau" wrote: > > pgousseau added a comment. > > > > On Linux, if the timestamp of a header file, included in the pch, is modified, then including the pch without regenerating it causes a fatal error, which is reasonable. > > > > > > > On Windows the check is i

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

sbenza added a comment. In http://reviews.llvm.org/D21036#450935, @aaron.ballman wrote: > In http://reviews.llvm.org/D21036#450106, @sbenza wrote: > > > I think this would be more interesting with macros. > > Eg triggering in code like this: > > > > #define FOO(type, op) const type& X = op() >

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

sbenza added inline comments. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + valueDecl(allOf(hasType(isConstQualified()), + hasType(typedefType(hasDeclaration( allOf() is unnecessary =

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + valueDecl(allOf(hasType(isConstQualified()), + hasType(typedefType(hasDeclaration( sbenza wrote: > allOf() is

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman updated this revision to Diff 59906. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Corrected more review feedback. http://reviews.llvm.org/D21036 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/Misplac

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

sbenza accepted this revision. This revision is now accepted and ready to land. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + valueDecl(allOf(hasType(isConstQualified()), + hasType(typedefType(hasDeclaration(

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:23 @@ +22,3 @@ + valueDecl(hasType(isConstQualified()), +hasType(typedefType(hasDeclaration( +typedefDecl(hasType(pointerType(unless(pointee( -

[clang-tools-extra] r272025 - Add the misc-misplaced-const check to clang-tidy, which diagnoses when a const-qualifier is applied to a typedef of pointer type rather than to the pointee type.

Author: aaronballman Date: Tue Jun 7 12:22:47 2016 New Revision: 272025 URL: http://llvm.org/viewvc/llvm-project?rev=272025&view=rev Log: Add the misc-misplaced-const check to clang-tidy, which diagnoses when a const-qualifier is applied to a typedef of pointer type rather than to the pointee t

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r272025. http://reviews.llvm.org/D21036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r272026 - Adding a release note for the misc-misplaced-const check added in r272025.

Author: aaronballman Date: Tue Jun 7 12:29:49 2016 New Revision: 272026 URL: http://llvm.org/viewvc/llvm-project?rev=272026&view=rev Log: Adding a release note for the misc-misplaced-const check added in r272025. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-

[clang-tools-extra] r272027 - Fixing a build bot issue with duplicate explicit instantiations.

Author: aaronballman Date: Tue Jun 7 12:32:07 2016 New Revision: 272027 URL: http://llvm.org/viewvc/llvm-project?rev=272027&view=rev Log: Fixing a build bot issue with duplicate explicit instantiations. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-const.cpp Modified: cla

r272028 - Make isNoThrow and hasDynamicExceptionSpec polymorphic so they can be used with both functionDecl and functionPrototype matchers.

Author: aaronballman Date: Tue Jun 7 12:34:45 2016 New Revision: 272028 URL: http://llvm.org/viewvc/llvm-project?rev=272028&view=rev Log: Make isNoThrow and hasDynamicExceptionSpec polymorphic so they can be used with both functionDecl and functionPrototype matchers. Patch by Don Hinton. Modif

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r272028. http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272029 - Added notes about the issues for Oulu

Author: marshall Date: Tue Jun 7 12:54:38 2016 New Revision: 272029 URL: http://llvm.org/viewvc/llvm-project?rev=272029&view=rev Log: Added notes about the issues for Oulu Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

[clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

Author: eugenezelenko Date: Tue Jun 7 13:29:15 2016 New Revision: 272038 URL: http://llvm.org/viewvc/llvm-project?rev=272038&view=rev Log: [Clang-tidy] Documentation style consistency. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/clang-tidy/checks/

Re: [clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

On Tue, Jun 7, 2016 at 2:29 PM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Tue Jun 7 13:29:15 2016 > New Revision: 272038 > > URL: http://llvm.org/viewvc/llvm-project?rev=272038&view=rev > Log: > [Clang-tidy] Documentation style consistency. Thank you for fixing those

[clang-tools-extra] r272042 - [Clang-tidy] Alphabetical checks order in release notes.

Author: eugenezelenko Date: Tue Jun 7 13:38:42 2016 New Revision: 272042 URL: http://llvm.org/viewvc/llvm-project?rev=272042&view=rev Log: [Clang-tidy] Alphabetical checks order in release notes. Highlight return statement in misc-unconventional-assign-operator documentation. Modified: clan

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:262 @@ -261,1 +261,3 @@ +- Updated `readability-identifier-naming-check + `_ Please put this not in alphab

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

kubabrecka added a subscriber: kubabrecka. kubabrecka added a comment. This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing? Repository: rL LLVM http://

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

hokein added a comment. @aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D21036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this in, so I'm closing this. http://reviews.llvm.org/D20922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this one in too, closing. http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

On Tue, Jun 7, 2016 at 3:06 PM, Haojian Wu wrote: > hokein added a comment. > > @aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst. Added in a separate commit (r272026). ~Aaron > > > http://reviews.llvm.org/D21036 > > > ___ cfe-commi

[PATCH] D21092: [libcxx] [test] Fix vector tests that were using ints copy-pasted from vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix vector tests that were using ints copy-pasted from vector tests. I copied the bool a[] 0/1 pattern from another vector test. Fixes MSVC warning C4305 "'argument': truncati

[PATCH] D21093: [libcxx] [test] In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning. Fixes MSVC warning C4305 "'argument': truncation from 'double' to 'const std::hash::_Kty'". ht

[PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In test/support/test_allocator.h, fix construct() to avoid moving immovable types. This improves the allocator's conformance, and fixes compiler errors with MSVC's STL. The s

[PATCH] D21095: [libcxx] [test] Fix another MSVC warning C4101 "unreferenced local variable".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix another MSVC warning C4101 "unreferenced local variable". http://reviews.llvm.org/D21095 Files: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/

[PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix MSVC warning C4125 "decimal digit terminates octal escape sequence". MSVC somewhat justifiably warns when it sees an octal escape immediately followed by a decimal digit,

Re: 3.8 Merge Request: r259776

Hi Alexy, Can you merge this? Thanks, Tom On Tue, Jun 07, 2016 at 09:40:44AM -0700, Richard Smith wrote: > It's larger than I'd like for a merge onto the branch, but yes, it looks OK. > > On 7 Jun 2016 9:20 a.m., "Tom Stellard via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > Hi Ri

[libcxx] r272050 - Added notes for a bunch of the issues

Author: marshall Date: Tue Jun 7 15:05:57 2016 New Revision: 272050 URL: http://llvm.org/viewvc/llvm-project?rev=272050&view=rev Log: Added notes for a bunch of the issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. Sema::CheckCastAlign currently ignores the aligned attribute attached to the declared variables, which causes clang to issue spurious warnings. This patch fixes the bug. http://reviews.llvm.org/D21099 Files: lib/Sema/S

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Jeroen, Thanks for your consideration. I am OK with removing those extensions which do not affect language or builtin functions. After removing them, they will be unknown to Clang. If a user tries to enable them, a warning will be emitted saying the extension is unknown. Anastasia, are you

  1   2   >