hokein added inline comments.
================
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
----------------
hokein wrote:
> madsravn wrote:
> > hokein wrote:
> > > You should add a document for the option `HeaderFileExtensions` here.
> > I'm not sure what you mean here. What is "a document" in this context?
> Sorry for the unclear comment. You actually add an option
> `HeaderFileExtensions` in `LLVMHeaderGuardCheck`, so you need to add a
> document to describe it. See the file `DefinitionsInHeadersCheck.h` for
> details.
You need to add a comment here, like:
```
/// Finds and fixes header guards that do not adhere to LLVM style.
///
/// The check supports these options:
/// - `HeaderFileExtensions`: a comma-separated list of filename extensions of
/// header files (The filename extension should not contain "." prefix).
/// ",h,hh,hpp,hxx" by default.
```
http://reviews.llvm.org/D20512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
