hokein added inline comments. ================ Comment at: include-fixer/IncludeFixer.cpp:104 @@ -103,3 @@ - // class Bar; - // Foo<Bar> foo; - // ---------------- bkramer wrote: > Does this patch do the right thing for the test case in the comment? > Otherwise we'll try add includes to system headers all the time, which both > wrong and invisible to the user. No, the patch doesn't handle this case :(. Currently it is hard to figure out this case. For the system headers, we can probably blacklist them?
http://reviews.llvm.org/D20966 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
