Author: alexfh Date: Tue Jun 7 04:11:19 2016 New Revision: 271992 URL: http://llvm.org/viewvc/llvm-project?rev=271992&view=rev Log: [clang-tidy] readability-identifier-naming - Support for Type Aliases
Summary: Added support for Type Alias declarations. Reviewers: alexfh Subscribers: cfe-commits Patch by James Reynolds! Differential Revision: http://reviews.llvm.org/D20856 Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming.cpp Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp?rev=271992&r1=271991&r2=271992&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp (original) +++ clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Tue Jun 7 04:11:19 2016 @@ -65,6 +65,7 @@ namespace readability { m(ValueTemplateParameter) \ m(TemplateTemplateParameter) \ m(TemplateParameter) \ + m(TypeAlias) \ enum StyleKind { #define ENUMERATE(v) SK_ ## v, @@ -258,6 +259,9 @@ static StyleKind findStyleKind( if (isa<TypedefDecl>(D) && NamingStyles[SK_Typedef].isSet()) return SK_Typedef; + if (isa<TypeAliasDecl>(D) && NamingStyles[SK_TypeAlias].isSet()) + return SK_TypeAlias; + if (const auto *Decl = dyn_cast<NamespaceDecl>(D)) { if (Decl->isAnonymousNamespace()) return SK_Invalid; Modified: clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming.cpp?rev=271992&r1=271991&r2=271992&view=diff ============================================================================== --- clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming.cpp (original) +++ clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming.cpp Tue Jun 7 04:11:19 2016 @@ -61,6 +61,8 @@ // RUN: {key: readability-identifier-naming.VariableCase, value: lower_case}, \ // RUN: {key: readability-identifier-naming.VirtualMethodCase, value: UPPER_CASE}, \ // RUN: {key: readability-identifier-naming.VirtualMethodPrefix, value: 'v_'}, \ +// RUN: {key: readability-identifier-naming.TypeAliasCase, value: lower_case}, \ +// RUN: {key: readability-identifier-naming.TypeAliasSuffix, value: '_t'}, \ // RUN: {key: readability-identifier-naming.IgnoreFailedSplit, value: 0} \ // RUN: ]}' -- -std=c++11 -fno-delayed-template-parsing \ // RUN: -I%S/Inputs/readability-identifier-naming \ @@ -191,8 +193,8 @@ class my_other_templated_class : my_temp // CHECK-FIXES: {{^}}class CMyOtherTemplatedClass : CMyTemplatedClass< CMyClass>, private CMyDerivedClass {};{{$}} template<typename t_t> -using MYSUPER_TPL = my_other_templated_class <:: FOO_NS ::my_class>; -// CHECK-FIXES: {{^}}using MYSUPER_TPL = CMyOtherTemplatedClass <:: foo_ns ::CMyClass>;{{$}} +using mysuper_tpl_t = my_other_templated_class <:: FOO_NS ::my_class>; +// CHECK-FIXES: {{^}}using mysuper_tpl_t = CMyOtherTemplatedClass <:: foo_ns ::CMyClass>;{{$}} const int global_Constant = 6; // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: invalid case style for global constant 'global_Constant' @@ -305,6 +307,15 @@ typedef THIS___Structure struct_type; // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: invalid case style for typedef 'struct_type' // CHECK-FIXES: {{^}}typedef this_structure struct_type_t;{{$}} +using my_struct_type = THIS___Structure; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style for type alias 'my_struct_type' +// CHECK-FIXES: {{^}}using my_struct_type_t = this_structure;{{$}} + +template<typename t_t> +using SomeOtherTemplate = my_other_templated_class <:: FOO_NS ::my_class>; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style for type alias 'SomeOtherTemplate' +// CHECK-FIXES: {{^}}using some_other_template_t = CMyOtherTemplatedClass <:: foo_ns ::CMyClass>;{{$}} + static void static_Function() { // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: invalid case style for function 'static_Function' // CHECK-FIXES: {{^}}static void staticFunction() {{{$}} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
